Allow changing max_sectors_kb above the default 512
PATCH 1/1 Allow changing max_sectors_kb above the default 512
The patch "block: Use accessor functions for queue limits" (ae03bf639a5027d27270123f5f6e3ee6a412781d) changed queue_max_sectors_store() to use blk_queue_max_sectors() instead of directly assigning the value.
But blk_queue_max_sectors() differs a bit
1. It sets both max_sectors_kb, and max_hw_sectors_kb
2. Never allows one to change max_sectors_kb above BLK_DEF_MAX_SECTORS. If one specifies a value greater then max_hw_sectors is set to that value but max_sectors is set to BLK_DEF_MAX_SECTORS
I am not sure whether blk_queue_max_sectors() should be changed, as it seems to be that way for a long time. And there may be callers dependent on that behaviour.
This patch simply reverts to the older way of directly assigning the value to max_sectors as it was before.
---
block/blk-sysfs.c +1 -1
@@ -133,7 +133,7 @@ queue_max_sectors_store(struct request_queue *q, const char *page, size_t count)return -EINVAL ;spin_lock_irq (q->queue_lock); -blk_queue_max_sectors (q, max_sectors_kb <<1 ); + q->limits.max_sectors = max_sectors_kb <<1 ;spin_unlock_irq (q->queue_lock);return ret;
Quoted 10 lines · Nikanth Karthikesan
The patch "block: Use accessor functions for queue limits" (
ae03bf639a5027d27270123f5f6e3ee6a412781d) changedqueue_max_sectors_store()to useblk_queue_max_sectors()instead of directly assigning the value.But
blk_queue_max_sectors()differs a bit
1. It sets bothmax_sectors_kb, andmax_hw_sectors_kb
2. Never allows one to changemax_sectors_kbaboveBLK_DEF_MAX_SECTORS. If one specifies a value greater thenmax_hw_sectorsis set to that value butmax_sectorsis set toBLK_DEF_MAX_SECTORS
Quoted 8 lines
I am not sure whether
blk_queue_max_sectors()should be changed, as it seems to be that way for a long time. And there may be callers dependent on that behaviour.This patch simply reverts to the older way of directly assigning the value to
max_sectorsas it was before.Signed-off-by Nikanth Karthikesan <[email protected]>
Good catch! Applied for 2.6.31.
Signature · 1 line
Jens Axboe