Skip to contentSkip to conversation

xfs: un-static xfs_inobt_lookup

PATCH In review Christoph Hellwig 2 participants 2 messages Sep 1, 2009 – Sep 2, 2009 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: un-static xfs_inobt_lookup

xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC modifier from it's declaration to fix non-debug builds.

This was already fixed in my git tree vs the version last posted to the list.

fs/xfs/xfs_ialloc.c +1 -1
Index: xfs/fs/xfs/xfs_ialloc.c
===================================================================
@@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
 /*
  * Lookup a record by ino in the btree given by cur.
  */
-STATIC int				/* error */
+int					/* error */
 xfs_inobt_lookup(
 	struct xfs_btree_cur	*cur,	/* btree cursor */
 	xfs_agino_t		ino,	/* starting inode of chunk */

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Christoph Hellwig

xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC modifier from it's declaration to fix non-debug builds.

Argh! I think, this or similar thing bit us once in past.

Quoted 4 lines

This was already fixed in my git tree vs the version last posted to the list.

Applying it quickly to the oss as well.

Quoted 1 line
Quoted 16 lines

Index: xfs/fs/xfs/xfs_ialloc.c
===================================================================

fs/xfs/xfs_ialloc.c +1 -1
@@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
 /*
 * Lookup a record by ino in the btree given by cur.
 */
-STATIC int				/* error */
+int					/* error */

xfs_inobt_lookup(
struct xfs_btree_cur *cur, /* btree cursor */
xfs_agino_t ino, /* starting inode of chunk */

Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs