Skip to contentSkip to conversation

Board can override OneNAND IPL image

PATCH New Kyungmin Park 2 participants 3 messages Sep 2, 2009 – Sep 19, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Board can override OneNAND IPL image

Some board use more then 2KiB OneNAND IPL.
E.G., S5PC100 loads 16KiB OneNAND IPL

Makefile +4 -5
index c9727f8..1af42ce 100644
@@ -285,6 +285,7 @@ endif
 ifeq ($(CONFIG_ONENAND_U_BOOT),y)
 ONENAND_IPL = onenand_ipl
 U_BOOT_ONENAND = $(obj)u-boot-onenand.bin
+ONENAND_BIN ?= $(obj)onenand_ipl/onenand-ipl-2k.bin
 endif
 
 __OBJS := $(subst $(obj),,$(OBJS))
@@ -374,8 +375,7 @@ $(ONENAND_IPL):	$(TIMESTAMP_FILE) $(VERSION_FILE) $(obj)include/autoconf.mk
 		$(MAKE) -C onenand_ipl/board/$(BOARDDIR) all
 
 $(U_BOOT_ONENAND):	$(ONENAND_IPL) $(obj)u-boot.bin
-		cat $(obj)onenand_ipl/onenand-ipl-2k.bin $(obj)u-boot.bin > $(obj)u-boot-onenand.bin
-		cat $(obj)onenand_ipl/onenand-ipl-4k.bin $(obj)u-boot.bin > $(obj)u-boot-flexonenand.bin
+		cat $(ONENAND_BIN) $(obj)u-boot.bin > $(obj)u-boot-onenand.bin
 
 $(VERSION_FILE):
 		@( printf '#define U_BOOT_VERSION "U-Boot %s%s"\n' "$(U_BOOT_VERSION)" \
@@ -3229,8 +3229,6 @@ zylonite_config :
 #########################################################################
 
 apollon_config		: unconfig
-	@mkdir -p $(obj)include
-	@mkdir -p $(obj)onenand_ipl/board/apollon
 	@echo "#define CONFIG_ONENAND_U_BOOT" > $(obj)include/config.h
 	@$(MKCONFIG) $(@:_config=) arm arm1136 apollon NULL omap24xx
 	@echo "CONFIG_ONENAND_U_BOOT = y" >> $(obj)include/config.mk
@@ -3716,7 +3714,8 @@ clean:
 	       $(obj)cpu/blackfin/bootrom-asm-offsets.[chs]
 	@rm -f $(obj)include/bmp_logo.h
 	@rm -f $(obj)nand_spl/{u-boot.lds,u-boot-spl,u-boot-spl.map,System.map}
-	@rm -f $(obj)onenand_ipl/onenand-{ipl,ipl.bin,ipl-2k.bin,ipl-4k.bin,ipl.map}
+	@rm -f $(obj)onenand_ipl/onenand-{ipl,ipl.bin,ipl.map}
+	@rm -f $(ONENAND_BIN)
 	@rm -f $(obj)onenand_ipl/u-boot.lds
 	@rm -f $(TIMESTAMP_FILE) $(VERSION_FILE)
 	@find $(OBJTREE) -type f \
#1 lore raw

PATCH 1/1 Board can override OneNAND IPL image

Quoted 2 lines · Kyungmin Park

Some board use more then 2KiB OneNAND IPL.
E.G., S5PC100 loads 16KiB OneNAND IPL

Why do we need a different image name based on how large the loader is?

-Scott

#2 lore raw

PATCH 1/1 Board can override OneNAND IPL image

Quoted 6 lines · Scott Wood
Quoted 2 lines · Kyungmin Park

Some board use more then 2KiB OneNAND IPL.
E.G., S5PC100 loads 16KiB OneNAND IPL

Why do we need a different image name based on how large the loader is?

Actually, S5PC100 has no problem to use 1KiB IPL. Internal boot ROM code read first 16KiB at OneNAND.
We it's enough to use 1KiB.
However, S5PC110 is different. It checks the 16KIB checksum located at latest 16KiB - 4 bytes.

In compatible issue, we conclude that use 16KiB for both cpus.

Thank you,
Kyungmin Park