Skip to contentSkip to conversation

lib_generic/zlib.c breaks when DEBUG are defined

U-Boot Gao Ya'nan 2 participants 3 messages Sep 2, 2009

lore
Share & tools
lore

Gao Ya'nan

author
#0 lore raw

======================
84 /* Diagnostic functions */
85 #ifdef DEBUG
86 #include <stdio.h>
======================

And

======================
1992 #ifdef DEBUG
1993
1994 #ifndef verbose
1995 #define verbose 0
1996 #endif
======================

#1 lore raw

Dear "Gao Ya'nan",

Quoted 8 lines · In message <[email protected]> you…

======================
84 /* Diagnostic functions */
85 #ifdef DEBUG
86 #include <stdio.h>
======================

And

Quoted 7 lines

======================
1992 #ifdef DEBUG
1993
1994 #ifndef verbose
1995 #define verbose 0
1996 #endif
======================

I'm not sure what exactly you want to tell us. If you see a problem and have a fix for it, then please prepare a patch. See
http://www.denx.de/wiki/U-Boot/Patches for details.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is much easier to suggest solutions when you know nothing
author
#2 lore raw

Sorry for my poor English and poor information.

Before meeting this broken, I used U-boot-v2009.06, and no compiling errors.

Then I changed to U-boot-v2009.08, and lib_generic/zlib.c is broken because of finding no stdio.h and fprintf function when debug function enabled. So I checked the source code and found that the DEBUG macro in zlib.c conflict with my global DEBUG macro, and the DEBUG of zlib.c in U-boot-v2009.06 is DEBUG_ZLIB.

And I'm thinking whether it is right to add a global DEBUG macro in PLATFORM_CPPFLAGS.

Thanks.

2009/9/2 Wolfgang Denk <[email protected]>:

Quoted 33 lines

Dear "Gao Ya'nan",

Quoted 8 lines · In message <[email protected]> you…

======================
84 /* Diagnostic functions */
85 #ifdef DEBUG
86 #include <stdio.h>
======================

And

Quoted 7 lines

======================
1992 #ifdef DEBUG
1993
1994 #ifndef verbose
1995 #define verbose 0
1996 #endif
======================

I'm not sure what exactly you want to tell us. If you see a problem and have a fix for it, then please prepare a patch. See
http://www.denx.de/wiki/U-Boot/Patches for details.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is much easier to suggest solutions when you know nothing