2.6.31-rc8 readcd Oops
Subsystems (2)
Sorry to catch this so late in the -rc cycle, but I haven't burned any CDs in a *long* time...
Fired up "xcdroast" to duplicate a CD, and promptly got the following Oops:
BUG: unable to handle kernel NULL pointer dereference at 00000004 IP: [<c105c064>] __free_pages+0x10/0x59 *pde = 00000000 Oops: 0002 [#1] PREEMPT last sysfs file: /sys/devices/pci0000:00/0000:00:01.0/0000:01:00.0/resource Modules linked in: sg snd_seq_midi snd_emu10k1_synth snd_emux_synth snd_seq_virmidi snd_seq_midi_event snd_seq_midi_emul snd_seq snd_emu10k1 snd_rawmidi snd_ac97_codec ac97_bus usbhid snd_pcm snd_seq_device snd_timer snd_page_alloc snd_util_mem snd_hwdep snd soundcore af_packet ipv6 uhci_hcd ehci_hcd usbcore binfmt_misc
Pid: 20682, comm: readcd Not tainted (2.6.31-rc8 #1)
EIP: 0060:[<c105c064>] EFLAGS: 00010246 CPU: 0
EIP is at __free_pages+0x10/0x59
EAX: 00000000 EBX: 00000001 ECX: 00000000 EDX: 00000002
ESI: 00000004 EDI: 00004000 EBP: 00004000 ESP: d3b61ddc
DS: 007b ES: 007b FS: 0000 GS: 00e0 SS: 0068
Process readcd (pid: 20682, ti=d3b60000 task=d4cd6500 task.ti=d3b60000)
Stack: 85ab3aa0 d882aa21 ffffc000 d390f01c 00000001 00000080 00000002 00004220 <0> 00008000 00008000 85ab3aa0 00008000 d390f01c d390f000 00000000 d882aa9d <0> 85ab3aa0 d390f000 d4d89de0 00000246 d882bd33 d39e1420 00000000 d3b61e6c Call Trace: [<d882aa21>] ? sg_build_indirect+0x243/0x272 [sg] [<d882aa9d>] ? sg_build_reserve+0x4d/0x78 [sg] [<d882bd33>] ? sg_open+0x33b/0x415 [sg] [<c107e3b8>] ? exact_match+0x0/0x23 [<c107ee04>] ? chrdev_open+0x16b/0x197 [<c107ec99>] ? chrdev_open+0x0/0x197 [<c1079d31>] ? __dentry_open+0x143/0x23e [<c107ac8d>] ? nameidata_to_filp+0x36/0x5b [<c108753e>] ? do_filp_open+0x441/0x7e5 [<c101d07b>] ? __wake_up+0x38/0x84 [<c1030473>] ? queue_work_on+0x32/0x4d [<c1079a82>] ? do_sys_open+0x5a/0x107 [<c1079ba1>] ? sys_open+0x2c/0x43 [<c1002b3c>] ? syscall_call+0x7/0xb Code: 31 d2 8b 14 24 65 33 15 14 00 00 00 74 05 e8 4c 49 fc ff 59 31 d2 e9 d1 fd ff ff 83 ec 04 89 c1 65 a1 14 00 00 00 89 04 24 31 c0 <ff> 49 04 0f 94 c0 84 c0 74 2c 85 d2 75 14 8b 04 24 65 33 05 14 EIP: [<c105c064>] __free_pages+0x10/0x59 SS:ESP 0068:d3b61ddc CR2: 0000000000000004 ---[ end trace 80d0523f259c41c8 ]---
This is a SCSI system. The PIONEER CD-ROM drive below is the one that was being accessed when the Oops occurred. The HA is an Adaptec 2930U2 (aic7xxx driver).
Attached devices:
Host: scsi0 Channel: 00 Id: 00 Lun: 00
Vendor: WDIGTL Model: WDE18300 ULTRA2 Rev: 1.30
Type: Direct-Access ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 01 Lun: 00
Vendor: SEAGATE Model: SX118273LC Rev: 6367
Type: Direct-Access ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 02 Lun: 00
Vendor: PIONEER Model: CD-ROM DR-U24X Rev: 1.01
Type: CD-ROM ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 03 Lun: 00
Vendor: YAMAHA Model: CRW2200S Rev: 1.0D
Type: CD-ROM ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 04 Lun: 00
Vendor: EXABYTE Model: EXB-82058VQANXR1 Rev: 07T0
Type: Sequential-Access ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 05 Lun: 00
Vendor: RICOH Model: IS60 Rev: 2R02
Type: Scanner ANSI SCSI revision: 02
Host: scsi0 Channel: 00 Id: 06 Lun: 00
Vendor: ARCHIVE Model: VIPER 2525 25462 Rev: -007
Type: Sequential-Access ANSI SCSI revision: 01
Signature · 5 lines
------------------------------------------------------------------------ Bob Tracy | "Every normal man must be tempted at times to spit [email protected] | upon his hands, hoist the black flag, and begin | slitting throats." -- H.L. Mencken ------------------------------------------------------------------------
PATCH 1/1 sg: fix oops in the error path in sg_build_indirect()
When the allocation fails in sg_build_indirect(), an oops happens in the error path. It's caused by an obvious typo.
---
drivers/scsi/sg.c +1 -1
@@ -1811,7 +1811,7 @@ retry:return 0 ; out:for (i =0 ; i < k; i++) -__free_pages (schp->pages[k], order); +__free_pages (schp->pages[i], order);if (--order >=0 ) goto retry;
Douglas Gilbert
maintainerRe: [PATCH] sg: fix oops in the error path in sg_build_indirect()
Quoted 12 lines · Michal Schmidt
When the allocation fails in
sg_build_indirect(), an oops happens in the error path. It's caused by an obvious typo.Signed-off-by Michal Schmidt <[email protected]>Reported-by Bob Tracy <[email protected]>---
drivers/scsi/sg.c +0
-0
drivers/scsi/sg.c retry:
Quoted 9 lines
drivers/scsi/sg.c +1
-2@@ -1811,7 +1811,7 @@ retry:return 0 ; out:for (i =0 ; i < k; i++) -__free_pages (schp->pages[k], order); +__free_pages (schp->pages[i], order);if (--order >=0 ) goto retry; --
Ouch.
Re: [PATCH] sg: fix oops in the error path in sg_build_indirect()
In reply to Michal SchmidtQuoted 5 lines · Michal Schmidt
When the allocation fails in
sg_build_indirect(), an oops happens in the error path. It's caused by an obvious typo.Signed-off-by Michal Schmidt <[email protected]>Reported-by Bob Tracy <[email protected]>
ACK, and thanks.
--Bob