Skip to contentSkip to conversation

ppc4xx: Fix compilation warning in 4xx miiphy.c

PATCH New Stefan Roese 1 participant 2 messages Sep 7, 2009 – Sep 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Fix compilation warning in 4xx miiphy.c

This patch fixes the following compilation warning:

miiphy.c: In function 'emac4xx_miiphy_read':
miiphy.c:353: warning: dereferencing type-punned pointer will break strict-aliasing rules

---
 cpu/ppc4xx/miiphy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/ppc4xx/miiphy.c +1 -1
index 6a92bf8..fa3bfc8 100644
@@ -350,7 +350,7 @@ int emac4xx_miiphy_read (char *devname, unsigned char addr, unsigned char reg,
 		return -1;
 
 	sta_reg = in_be32((void *)EMAC_STACR + emac_reg);
-	*value = *(u16 *)(&sta_reg);
+	*value = sta_reg >> 16;
 
 	return 0;
 }
Signature · 1 line
1.6.4.1
author Applied
#1 lore raw

PATCH 1/1 ppc4xx: Fix compilation warning in 4xx miiphy.c

Quoted 5 lines · On Monday 07 September 2009 13:08:35 Stefan Roese wrote:

This patch fixes the following compilation warning:

miiphy.c: In function 'emac4xx_miiphy_read':
miiphy.c:353: warning: dereferencing type-punned pointer will break strict-aliasing rules

Applied to ppc4xx. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de