ep8248: add support for device tree and secondary Ethernet interface.
PATCH v3 1/1 ep8248: add support for device tree and secondary Ethernet interface.
--- board/ep8248/ep8248.c | 16 ++++++++++++- include/configs/ep8248.h | 53 ++++++++++++++++++++-------------------------- 2 files changed, 37 insertions(+), 32 deletions(-)
board/ep8248/ep8248.c +14 -2
@@ -5,6 +5,10 @@* Support for Embedded Planet EP8248 boards. * Tested on EP8248E. * +* Copyright (C) 2009 Noser Engineering AG +* Marcel Ziswiler <[email protected]> +* Added support for device tree and secondary Ethernet interface +* * See file CREDITS for list of people who contributed to this * project. *
@@ -35,8 +39,8 @@* according to the five values podr/pdir/ppar/psor/pdat for that entry */ -#define CONFIG_SYS_FCC1 (CONFIG_ETHER_INDEX == 1) -#define CONFIG_SYS_FCC2 (CONFIG_ETHER_INDEX == 2) +#define CONFIG_SYS_FCC1 (CONFIG_ETHER_ON_FCC1 == 1) +#define CONFIG_SYS_FCC2 (CONFIG_ETHER_ON_FCC2 == 1)const iop_conf_t iop_conf_tab[4 ][32 ] = {
@@ -261,3 +265,11 @@ int checkboard(void)return 0 ; } + +#if defined(CONFIG_OF_BOARD_SETUP ) && defined(CONFIG_OF_LIBFDT ) +void ft_board_setup (void *blob,bd_t *bd) +{ +ft_cpu_setup ( blob, bd); +} +#endif /* defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) */ +
include/configs/ep8248.h +23 -30
87 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH v3 1/1 ep8248: add support for device tree and secondary Ethernet interface.
Dear Marcel Ziswiler,
Quoted 5 lines · In message <1252424017.5386.19.camel@com-21> you wrote:
Signed-off-by Marcel Ziswiler <[email protected]>--- board/ep8248/ep8248.c | 16 ++++++++++++- include/configs/ep8248.h | 53 ++++++++++++++++++++-------------------------- 2 files changed, 37 insertions(+), 32 deletions(-)
Please put the board maintainer on Cc:
board/ep8248/ep8248.c line 10
Quoted 11 lines
board/ep8248/ep8248.c +3
-0@@ -5,6 +5,10 @@* Support for Embedded Planet EP8248 boards. * Tested on EP8248E. * +* Copyright (C) 2009 Noser Engineering AG +* Marcel Ziswiler <[email protected]> +* Added support for device tree and secondary Ethernet interface
We don't add copyright entries for so few lines of code. And we don;t add a change log either. We have git to track the history of changes for us.
include/configs/ep8248.h line 10
Quoted 12 lines
include/configs/ep8248.h +4
-0@@ -4,6 +4,10 @@* * U-Boot configuration for Embedded Planet EP8248 boards. * +* Copyright (C) 2009 Noser Engineering AG +* Marcel Ziswiler <[email protected]> +* Added support for device tree and secondary Ethernet interface +*
Ditto.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A woman should have compassion. -- Kirk, "Catspaw", stardate 3018.2
PATCH v3 1/1 ep8248: add support for device tree and secondary Ethernet interface.
Dear Wolfgang Denk
Quoted 1 line · Wolfgang Denk
Please put the board maintainer on Cc:
OK, did so now.
Quoted 3 lines
We don't add copyright entries for so few lines of code. And we don;t add a change log either. We have git to track the history of changes for us.
OK, sorry. Will change that.
Cheers
Marcel Ziswiler
PATCH v4 1/1 ep8248: add support for device tree and secondary Ethernet interface.
In reply to Marcel Ziswiler---
Changes since v1:
- Removed redundant commit message as pointed out by Peter Tyser
- Separate patch to move FDT memory node fixup into common CPU code as pointed out by Peter Tyser Changes since v2:
- Fix patch line wrapping
Changes since v3:
- Removed copyright and change log entries as pointed out by Wolfgang Denk
board/ep8248/ep8248.c | 12 +++++++++- include/configs/ep8248.h | 49 +++++++++++++++++---------------------------- 2 files changed, 29 insertions(+), 32 deletions(-)
board/ep8248/ep8248.c +10 -2
@@ -35,8 +35,8 @@* according to the five values podr/pdir/ppar/psor/pdat for that entry */ -#define CONFIG_SYS_FCC1 (CONFIG_ETHER_INDEX == 1) -#define CONFIG_SYS_FCC2 (CONFIG_ETHER_INDEX == 2) +#define CONFIG_SYS_FCC1 (CONFIG_ETHER_ON_FCC1 == 1) +#define CONFIG_SYS_FCC2 (CONFIG_ETHER_ON_FCC2 == 1)const iop_conf_t iop_conf_tab[4 ][32 ] = {
@@ -261,3 +261,11 @@ int checkboard(void)return 0 ; } + +#if defined(CONFIG_OF_BOARD_SETUP ) && defined(CONFIG_OF_LIBFDT ) +void ft_board_setup (void *blob,bd_t *bd) +{ +ft_cpu_setup ( blob, bd); +} +#endif /* defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) */ +
include/configs/ep8248.h +19 -30
77 lines not on this page · raw message
Signature · 1 line
1.6.4.2
Wolfgang Denk
AppliedPATCH v4 1/1 ep8248: add support for device tree and secondary Ethernet interface.
Dear Marcel Ziswiler,
Quoted 10 lines · In message <1252524128.3643.12.camel@com-21> you wrote:
Signed-off-by Marcel Ziswiler <[email protected]>---
Changes since v1:
- Removed redundant commit message as pointed out by Peter Tyser
- Separate patch to move FDT memory node fixup into common CPU code as pointed out by Peter Tyser Changes since v2:
- Fix patch line wrapping
Changes since v3:
- Removed copyright and change log entries as pointed out by Wolfgang Denk
Quoted 3 lines
board/ep8248/ep8248.c | 12 +++++++++- include/configs/ep8248.h | 49 +++++++++++++++++---------------------------- 2 files changed, 29 insertions(+), 32 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"An open mind has but one disadvantage: it collects dirt."
- a saying at RPI