Skip to contentSkip to conversation

ksym_tracer: Remove KSYM_SELFTEST_ENTRY

PATCH In review Li Zefan 3 participants 3 messages Sep 10, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 2/2 ksym_tracer: Remove KSYM_SELFTEST_ENTRY

The macro used to be used in both trace_selftest.c and trace_ksym.c, but no longer, so remove it from header file.

---
 kernel/trace/trace.h          |    1 -
 kernel/trace/trace_selftest.c |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
kernel/trace/trace.h +0 -1
index 76ed0db..e6b1c73 100644
@@ -202,7 +202,6 @@ struct syscall_trace_exit {
 	unsigned long		ret;
 };
 
-#define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
 extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
 
 struct ksym_trace_entry {
kernel/trace/trace_selftest.c +1 -1
index 7179c12..a006f00 100644
@@ -828,7 +828,7 @@ trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
 
 	ksym_selftest_dummy = 0;
 	/* Register the read-write tracing request */
-	ret = process_new_ksym_entry(KSYM_SELFTEST_ENTRY, HW_BREAKPOINT_RW,
+	ret = process_new_ksym_entry("ksym_selftest_dummy", HW_BREAKPOINT_RW,
 					(unsigned long)(&ksym_selftest_dummy));
 
 	if (ret < 0) {
Signature · 1 line
1.6.3
#1 lore raw
Quoted 4 lines · Li Zefan

The macro used to be used in both trace_selftest.c and trace_ksym.c, but no longer, so remove it from header file.

Steve, I should better take this one. I'm currently working on the breakpoint tree and I prepare a pull request so I can bring it inside.

Thanks.

Quoted 32 lines
---
 kernel/trace/trace.h          |    1 -
 kernel/trace/trace_selftest.c |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
kernel/trace/trace.h +0 -1
index 76ed0db..e6b1c73 100644
@@ -202,7 +202,6 @@ struct syscall_trace_exit {
 	unsigned long		ret;
 };
 
-#define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
 extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
 
 struct ksym_trace_entry {
kernel/trace/trace_selftest.c +1 -1
index 7179c12..a006f00 100644
@@ -828,7 +828,7 @@ trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
 
 	ksym_selftest_dummy = 0;
 	/* Register the read-write tracing request */
-	ret = process_new_ksym_entry(KSYM_SELFTEST_ENTRY, HW_BREAKPOINT_RW,
+	ret = process_new_ksym_entry("ksym_selftest_dummy", HW_BREAKPOINT_RW,
 					(unsigned long)(&ksym_selftest_dummy));
 
 	if (ret < 0) {
Signature · 1 line
1.6.3
maintainer
#2 lore raw
Quoted 11 lines · Frederic Weisbecker
Quoted 4 lines · Li Zefan

The macro used to be used in both trace_selftest.c and trace_ksym.c, but no longer, so remove it from header file.

Steve, I should better take this one. I'm currently working on the breakpoint tree and I prepare a pull request so I can bring it inside.

OK, I'll take patch 1, and you can take patch 2 ;-)

-- Steve