Skip to contentSkip to conversation

spi/spidev: remove BLK

PATCH In review Sebastian Andrzej Siewior 2 participants 3 messages Sep 10, 2009 2 messages not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi/spidev: remove BLK

the BLK in open() is not required:
- device_list is protected by device_list_lock
- spidev->user is only access with device_list_lock locked
- spidev->buffer is protected by spidev->buf_lock. Allocation & free is done by the first/last user with device_list_lock locked.

---
 drivers/spi/spidev.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/spi/spidev.c +0 -3
index 606e7a4..f362c40 100644
@@ -30,7 +30,6 @@
 #include <linux/errno.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
-#include <linux/smp_lock.h>
 
 #include <linux/spi/spi.h>
 #include <linux/spi/spidev.h>
@@ -477,7 +476,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
 	struct spidev_data	*spidev;
 	int			status = -ENXIO;
 
-	lock_kernel();
 	mutex_lock(&device_list_lock);
 
 	list_for_each_entry(spidev, &device_list, device_entry) {
@@ -503,7 +501,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
 		pr_debug("spidev: nothing for minor %d\n", iminor(inode));
 
 	mutex_unlock(&device_list_lock);
-	unlock_kernel();
 	return status;
 }
 
Signature · 8 lines
1.6.3.3


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

A message that is not in the archive (sent off-list or not yet received): 20090910130409.GA23433-N26foeg2n7CSQxDm3FYtNwe+0vtP5+jfMa5aj3AfGnc@public.gmane.org

#2 lore raw
Quoted 7 lines · Sebastian Andrzej Siewior

the BLK in open() is not required:
- device_list is protected by device_list_lock
- spidev->user is only access with device_list_lock locked
- spidev->buffer is protected by spidev->buf_lock. Allocation & free is done by the first/last user with device_list_lock locked.

In short: revert 609f9e92b570f390a457a81effe0af6b758dc582 which was not needed (and ISTR that it got a NAK so why it's in the tree is a puzzle).

Quoted 36 lines
---
 drivers/spi/spidev.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/spi/spidev.c +0 -3
index 606e7a4..f362c40 100644
@@ -30,7 +30,6 @@
 #include <linux/errno.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
-#include <linux/smp_lock.h>
 
 #include <linux/spi/spi.h>
 #include <linux/spi/spidev.h>
@@ -477,7 +476,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
 	struct spidev_data	*spidev;
 	int			status = -ENXIO;
 
-	lock_kernel();
 	mutex_lock(&device_list_lock);
 
 	list_for_each_entry(spidev, &device_list, device_entry) {
@@ -503,7 +501,6 @@ static int spidev_open(struct inode *inode, struct file *filp)
 		pr_debug("spidev: nothing for minor %d\n", iminor(inode));
 
 	mutex_unlock(&device_list_lock);
-	unlock_kernel();
 	return status;
 }
 
Signature · 1 line
1.6.3.3

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

A message that is not in the archive (sent off-list or not yet received): 200909101100.34332.david-b-yBeKhBN/[email protected]

#4 lore raw
Quoted 10 lines · * David Brownell | 2009-09-10 11:00:34 [-0700]:
Quoted 7 lines · Sebastian Andrzej Siewior

the BLK in open() is not required:
- device_list is protected by device_list_lock
- spidev->user is only access with device_list_lock locked
- spidev->buffer is protected by spidev->buf_lock. Allocation & free is done by the first/last user with device_list_lock locked.

In short: revert 609f9e92b570f390a457a81effe0af6b758dc582

yup

Quoted 2 lines

which was not needed (and ISTR that it got a NAK so why it's in the tree is a puzzle).

It was for over an year in the tree without anyone noticing :)

Sebastian

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july