Skip to contentSkip to conversation

r7780mp: fix typo in Ethernet chip model number comment.

PATCH New Marcel Ziswiler 2 participants 6 messages Sep 8, 2009 – Sep 10, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 r7780mp: fix typo in Ethernet chip model number comment.

---
 include/configs/r7780mp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/r7780mp.h +1 -1
index 7738a17..71c570e 100644
@@ -154,7 +154,7 @@
 #define CONFIG_NET_MULTI
 #define CONFIG_RTL8169
 */
-/* AX88696L Support(NE2000 base chip) */
+/* AX88796L Support(NE2000 base chip) */
 #define CONFIG_DRIVER_NE2000
 #define CONFIG_DRIVER_AX88796L
 #define CONFIG_DRIVER_NE2000_BASE	0xA4100000
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 r7780mp: fix typo in Ethernet chip model number comment.

Dear Marcel Ziswiler,

Quoted 4 lines · In message <1252423492.5386.7.camel@com-21> you wrote:
---
 include/configs/r7780mp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Your patch numbering is really, really confusing. There is a patch posted for the first time numbered as v2, another one as v3, and this here is the second version of a patch which is still numbered v1.

I completely lost you here.

I don;t understand if these patches are supposed to be part of a series, or if they are independet of each other, or what else these random vN additions might mean. Please eluciadate.

Also please note that new versions of a patch should contain a comment (below the "---" line) that describes what has been changed compared to the old version, i. e. here something like: "v2: added missing SoB line" or so.

Given this confusion, I will ignore the whole batch of 7 patches you just sent. Please work on the other review comments, and then decide how you want to post them - as series or independent patches. Assume version numbering restarts from zero, as I really ignore this current patch series.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whom the gods would destroy, they first teach BASIC.
#2 lore raw

PATCH 1/1 r7780mp: fix typo in Ethernet chip model number comment.

Quoted 3 lines · Wolfgang Denk

Your patch numbering is really, really confusing. There is a patch posted for the first time numbered as v2, another one as v3, and this here is the second version of a patch which is still numbered v1.

Sorry if I confused you, that was not my intention at all, but I truly carefully numbered my patches. Every patch having a v > 1 was already posted here once before:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67275
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197

Quoted 5 lines

I completely lost you here.

I don;t understand if these patches are supposed to be part of a series, or if they are independet of each other, or what else these random vN additions might mean. Please eluciadate.

If it would be a series, one would add something like [3/6] or such. So it is no series, just a few very simple patches.

Quoted 4 lines

Also please note that new versions of a patch should contain a comment (below the "---" line) that describes what has been changed compared to the old version, i. e. here something like: "v2: added missing SoB line" or so.

OK, this one is new for me, sorry. Unfortunately the one I looked at did not include any such history neither:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67181

Quoted 5 lines

Given this confusion, I will ignore the whole batch of 7 patches you just sent. Please work on the other review comments, and then decide how you want to post them - as series or independent patches. Assume version numbering restarts from zero, as I really ignore this current patch series.

That's really sad.

Cheers

Marcel Ziswiler

#3 lore raw

PATCH 1/1 r7780mp: fix typo in Ethernet chip model number comment.

Dear Marcel Ziswiler,

Quoted 9 lines · In message <1252442498.5386.67.camel@com-21> you wrote:
Quoted 3 lines · Wolfgang Denk

Your patch numbering is really, really confusing. There is a patch posted for the first time numbered as v2, another one as v3, and this here is the second version of a patch which is still numbered v1.

Sorry if I confused you, that was not my intention at all, but I truly carefully numbered my patches. Every patch having a v > 1 was already posted here once before:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67275
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197

Could you please make sure not to break threading, then?

Quoted 7 lines
Quoted 5 lines

Given this confusion, I will ignore the whole batch of 7 patches you just sent. Please work on the other review comments, and then decide how you want to post them - as series or independent patches. Assume version numbering restarts from zero, as I really ignore this current patch series.

That's really sad.

Not really; I think most patches need minor changes anyway.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is dangerous to be right on a subject  on  which  the  established
authorities are wrong.                                    -- Voltaire
#4 lore raw

PATCH v2 1/1 r7780mp: fix typo in Ethernet chip model number comment.

In reply to Marcel Ziswiler

---
Changes since v1:
- CC R7780MP maintainer Nobuhiro Iwamatsu

 include/configs/r7780mp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/r7780mp.h +1 -1
index 7738a17..71c570e 100644
@@ -154,7 +154,7 @@
 #define CONFIG_NET_MULTI
 #define CONFIG_RTL8169
 */
-/* AX88696L Support(NE2000 base chip) */
+/* AX88796L Support(NE2000 base chip) */
 #define CONFIG_DRIVER_NE2000
 #define CONFIG_DRIVER_AX88796L
 #define CONFIG_DRIVER_NE2000_BASE	0xA4100000
Signature · 1 line
1.6.4.2
#5 lore raw

PATCH v2 1/1 r7780mp: fix typo in Ethernet chip model number comment.

Dear Marcel Ziswiler,

Quoted 7 lines · In message <1252523340.3643.2.camel@com-21> you wrote:

---
Changes since v1:
- CC R7780MP maintainer Nobuhiro Iwamatsu

 include/configs/r7780mp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One of the advantages of being a captain is being able to ask for ad-
vice without necessarily having to take it.
	-- Kirk, "Dagger of the Mind", stardate 2715.2