Support for the OpenRD base board
PATCH 1/1 Support for the OpenRD base board
Support for the OpenRD base board
The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete.
---
The configuration does not include UBIFS support, which still needs he remaining patches for the bitops cleanup and fixes:
http://lists.denx.de/pipermail/u-boot/2009-August/059285.html
to build. Until those are applied, it's turned off here.
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards). This patch fixes that:
http://lists.denx.de/pipermail/u-boot/2009-September/059896.html
MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 51 +++++++ board/Marvell/openrd_base/config.mk | 25 ++++ board/Marvell/openrd_base/openrd_base.c | 158 ++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 218 +++++++++++++++++++++++++++++++ 8 files changed, 506 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.h
MAINTAINERS +4 -0
@@ -588,6 +588,10 @@ Gary Jennejohn <[email protected]> Konstantin Kletschke <[email protected]> scb9328 ARM920T +Simon Kagstrom <[email protected]> + + openrd_base ARM926EJS (Kirkwood SoC) + Nishant Kamat <[email protected]> omap1610h2 ARM926EJS
MAKEALL +1 -0
@@ -533,6 +533,7 @@ LIST_ARM9=" \ omap1610inn \ omap5912osk \ omap730p2 \ + openrd_base \ rd6281a \ sbc2410x \ scb9328 \
Makefile +3 -0
@@ -3018,6 +3018,9 @@ omap1610h2_cs_autoboot_config: unconfig omap5912osk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs omap5912osk ti omap +openrd_base_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + xtract_omap730p2 = $(subst _cs0boot,,$(subst _cs3boot,, $(subst _config,,$1))) omap730p2_config \
board/Marvell/openrd_base/Makefile new file +51 -0
51 lines not on this page · raw message
board/Marvell/openrd_base/config.mk new file +25 -0
@@ -0,0 +1,25 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +TEXT_BASE = 0x00600000
board/Marvell/openrd_base/openrd_base.c new file +158 -0
158 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.h new file +46 -0
46 lines not on this page · raw message
include/configs/openrd_base.h new file +218 -0
218 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH v2 1/1 Support for the OpenRD base board
Support for the OpenRD base board
The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete.
---
The configuration does not include UBIFS support, which still needs he remaining patches for the bitops cleanup and fixes:
http://lists.denx.de/pipermail/u-boot/2009-August/059285.html
to build. Until those are applied, it's turned off here.
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards). This patch fixes that:
http://lists.denx.de/pipermail/u-boot/2009-September/059896.html
The second version contains the kwbimage.cfg needed to produce an image to install on the NAND flash.
MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 51 +++++++ board/Marvell/openrd_base/config.mk | 28 ++++ board/Marvell/openrd_base/kwbimage.cfg | 168 ++++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.c | 158 ++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 218 +++++++++++++++++++++++++++++++ 9 files changed, 677 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/kwbimage.cfg create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.h
MAINTAINERS +4 -0
@@ -588,6 +588,10 @@ Gary Jennejohn <[email protected]> Konstantin Kletschke <[email protected]> scb9328 ARM920T +Simon Kagstrom <[email protected]> + + openrd_base ARM926EJS (Kirkwood SoC) + Nishant Kamat <[email protected]> omap1610h2 ARM926EJS
MAKEALL +1 -0
@@ -533,6 +533,7 @@ LIST_ARM9=" \ omap1610inn \ omap5912osk \ omap730p2 \ + openrd_base \ rd6281a \ sbc2410x \ scb9328 \
Makefile +3 -0
@@ -3022,6 +3022,9 @@ omap1610h2_cs_autoboot_config: unconfig omap5912osk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs omap5912osk ti omap +openrd_base_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + xtract_omap730p2 = $(subst _cs0boot,,$(subst _cs3boot,, $(subst _config,,$1))) omap730p2_config \
board/Marvell/openrd_base/Makefile new file +51 -0
51 lines not on this page · raw message
board/Marvell/openrd_base/config.mk new file +28 -0
@@ -0,0 +1,28 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +TEXT_BASE = 0x00600000 + +# Kirkwood Boot Image configuration file +KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
board/Marvell/openrd_base/kwbimage.cfg new file +168 -0
168 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.c new file +158 -0
158 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.h new file +46 -0
46 lines not on this page · raw message
include/configs/openrd_base.h new file +218 -0
218 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH v2 1/1 Support for the OpenRD base board
Quoted 11 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Friday, September 11, 2009 1:45 PM
To: U-Boot ML
Cc: Prafulla Wadaskar; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
Subject: [PATCH v2] Support for the OpenRD base boardSupport for the OpenRD base board
Quoted 8 lines
The implementation is borrowed from the sheevaplug board and the Marvell
1.1.4 code and likely to be a bit incomplete.Signed-off-by Simon Kagstrom <[email protected]>---
The configuration does not include UBIFS support, which still needs he remaining patches for the bitops cleanup and fixes:
Pls correct typo here
Quoted 86 lines
http://lists.denx.de/pipermail/u-boot/2009-August/059285.html
to build. Until those are applied, it's turned off here.
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards). This patch fixes that:
http://lists.denx.de/pipermail/u-boot/2009-September/059896.html
The second version contains the kwbimage.cfg needed to produce an image
to install on the NAND flash.MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 51 +++++++ board/Marvell/openrd_base/config.mk | 28 ++++ board/Marvell/openrd_base/kwbimage.cfg | 168 ++++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.c | 158 ++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 218 +++++++++++++++++++++++++++++++ 9 files changed, 677 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/kwbimage.cfg create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.hMAINTAINERS +4
-0@@ -588,6 +588,10 @@ Gary Jennejohn <[email protected]> Konstantin Kletschke <[email protected]> scb9328 ARM920T +Simon Kagstrom <[email protected]> + + openrd_base ARM926EJS (Kirkwood SoC) + Nishant Kamat <[email protected]> omap1610h2 ARM926EJSMAKEALL +1
-0@@ -533,6 +533,7 @@ LIST_ARM9=" \ omap1610inn \ omap5912osk \ omap730p2 \ + openrd_base \ rd6281a \ sbc2410x \ scb9328 \Makefile +2
-0@@ -3022,6 +3022,9 @@ omap1610h2_cs_autoboot_config: unconfig omap5912osk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs omap5912osk ti omap +openrd_base_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=)Marvell kirkwood
+
xtract_omap730p2= $(subst _cs0boot,,$(subst_cs3boot,,
$(subst _config,,$1)))
omap730p2_config\board/Marvell/openrd_base/Makefile new file +0
-0
board/Marvell/openrd_base/Makefile line 4
Quoted 4 lines
board/Marvell/openrd_base/Makefile new file +4
-0@@ -0,0 +1,51 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]>
I think you must add your reference here..
Quoted 1 line
+#
Quoted 55 lines
board/Marvell/openrd_base/Makefile new file +39
-0+# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS := openrd_base.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +#########################################################################
board/Marvell/openrd_base/Makefile new file +7
-0+ +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/Marvell/openrd_base/config.mk new file +0
-0
board/Marvell/openrd_base/config.mk line 4
Quoted 4 lines
board/Marvell/openrd_base/config.mk new file +4
-0@@ -0,0 +1,28 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]>
Same here
Quoted 103 lines
board/Marvell/openrd_base/config.mk new file +24
-0+# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +TEXT_BASE = 0x00600000 + +# Kirkwood Boot Image configuration file +KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfgboard/Marvell/openrd_base/kwbimage.cfg new file +50
-0@@ -0,0 +1,168 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# +# Refer docs/README.kwimage for more details about how-to configure +# and create kirkwood boot image +# + +# Boot Media configurations +BOOT_FROM nand +NAND_ECC_MODE default +NAND_PAGE_SIZE 0x0800 + +# SOC registers configuration using bootrom header extension +# Maximum KWBIMAGE_MAX_CONFIG configurations allowed + +# Configure RGMII-0 interface pad voltage to 1.8V +DATA 0xFFD100e0 0x1b1b1b9b + +#Dram initalization for SINGLE x16 CL=5 @ 400MHz +DATA 0xFFD01400 0x43000c30 # DDR Configuration register +# bit13-0: 0xc30 (3120 DDR2 clks refresh rate) +# bit23-14: zero +# bit24: 1= enable exit self refresh mode on DDR access +# bit25: 1 required +# bit29-26: zero +# bit31-30: 01 + +DATA 0xFFD01404 0x37543000 # DDR Controller Control Low +# bit 4: 0=addr/cmd in smame cycle +# bit 5: 0=clk is driven during self refresh, we don'tcare for APX
board/Marvell/openrd_base/kwbimage.cfg new file +4
-0+# bit 6: 0=use recommended falling edge of clk for addr/cmd +# bit14: 0=input buffer always powered up +# bit18: 1=cpu lock transaction enabled +# bit23-20: 5=recommended value for CL=5 and STARTBURST_DELdisabled bit31=0
+# bit27-24: 7= CL+2, STARTBURST sample stages, for freqs 400MHz, unbuffered DIMMboard/Marvell/openrd_base/kwbimage.cfg new file +4
-0+# bit30-28: 3 required +# bit31: 0=no additional STARTBURST delay + +DATA 0xFFD01408 0x22125451 # DDR Timing (Low) (activecycles value +1)
board/Marvell/openrd_base/kwbimage.cfg new file +9
-0+# bit3-0: TRAS lsbs +# bit7-4: TRCD +# bit11- 8: TRP +# bit15-12: TWR +# bit19-16: TWTR +# bit20: TRAS msb +# bit23-21: 0x0 +# bit27-24: TRRD +# bit31-28: TRTP
board/Marvell/openrd_base/kwbimage.cfg line 78
Quoted 10 lines
board/Marvell/openrd_base/kwbimage.cfg new file +10
-0+ +DATA 0xFFD0140C 0x00000a33 # DDR Timing (High) +# bit6-0: TRFC +# bit8-7: TR2R +# bit10-9: TR2W +# bit12-11: TW2W +# bit31-13: zero required + +DATA 0xFFD01410 0x000000cc # DDR Address Control +# bit1-0: 00, Reserved
This means 0x8 not reserved as per rev-C specification document
board/Marvell/openrd_base/kwbimage.cfg line 80
Quoted 2 lines
board/Marvell/openrd_base/kwbimage.cfg new file +2
-0+# bit3-2: 11, Cs0size=1Gb +# bit5-4: 00, Reserved
Ditto
Quoted 103 lines
board/Marvell/openrd_base/kwbimage.cfg new file +47
-0+# bit7-6: 11, Cs1size=1Gb +# bit9-8: 00, Cs2width=nonexistent +# bit11-10: 00, Cs2size =nonexistent +# bit13-12: 00, Cs3width=nonexistent +# bit15-14: 00, Cs3size =nonexistent +# bit16: 0, Cs0AddrSel +# bit17: 0, Cs1AddrSel +# bit18: 0, Cs2AddrSel +# bit19: 0, Cs3AddrSel +# bit31-20: 0 required + +DATA 0xFFD01414 0x00000000 # DDR Open Pages Control +# bit0: 0, OpenPage enabled +# bit31-1: 0 required + +DATA 0xFFD01418 0x00000000 # DDR Operation +# bit3-0: 0x0, DDR cmd +# bit31-4: 0 required + +DATA 0xFFD0141C 0x00000C52 # DDR Mode +# bit2-0: 2, BurstLen=2 required +# bit3: 0, BurstType=0 required +# bit6-4: 4, CL=5 +# bit7: 0, TestMode=0 normal +# bit8: 0, DLL reset=0 normal +# bit11-9: 6, auto-precharge write recovery ???????????? +# bit12: 0, PD must be zero +# bit31-13: 0 required + +DATA 0xFFD01420 0x00000042 # DDR Extended Mode +# bit0: 0, DDR DLL enabled +# bit1: 1, DDR drive strength reduced +# bit2: 0, DDR ODT control lsd (disabled) +# bit5-3: 000, required +# bit6: 1, DDR ODT control msb, (disabled) +# bit9-7: 000, required +# bit10: 0, differential DQS enabled +# bit11: 0, required +# bit12: 0, DDR output buffer enabled +# bit31-13: 0 required + +DATA 0xFFD01424 0x0000F17F # DDR Controller Control High +# bit2-0: 111, required +# bit3 : 1 , MBUS Burst Chop disabled +# bit6-4: 111, required +# bit7 : 0 +# bit8 : 1 , add writepath sample stage, must be 1 forDDR freq >= 300MHz
board/Marvell/openrd_base/kwbimage.cfg new file +19
-0+# bit9 : 0 , no half clock cycle addition to dataout +# bit10 : 0 , 1/4 clock cycle skew enabled for addr/ctl signals +# bit11 : 0 , 1/4 clock cycle skew disabled for write mesh +# bit15-12: 1111 required +# bit31-16: 0 required + +DATA 0xFFD01428 0x00085520 # DDR2 ODT Read Timing (default values) +DATA 0xFFD0147C 0x00008552 # DDR2 ODT Write Timing (default values) + +DATA 0xFFD01500 0x00000000 # CS[0]n Base address to 0x0 +DATA 0xFFD01504 0x0FFFFFF1 # CS[0]n Size +# bit0: 1, Window enabled +# bit1: 0, Write Protect disabled +# bit3-2: 00, CS0 hit selected +# bit23-4: ones, required +# bit31-24: 0x0F, Size (i.e. 256MB) + +DATA 0xFFD01508 0x10000000 # CS[1]n Base address to 256Mb +DATA 0xFFD0150C 0x0FFFFFF5 # CS[1]n Size 256Mb Windowenabled for CS1
board/Marvell/openrd_base/kwbimage.cfg new file +6
-0+ +DATA 0xFFD01514 0x00000000 # CS[2]n Size, window disabled +DATA 0xFFD0151C 0x00000000 # CS[3]n Size, window disabled + +DATA 0xFFD01494 0x00120012 # DDR ODT Control (Low) +# bit3-0: 0010, (read) M_ODT[0] is asserted during readfrom DRAM CS1
+# bit7-4: 0001, (read) M_ODT[1] is asserted during read
from DRAM CS0
+# bit19-16: 0010, (write) M_ODT[0] is asserted during write to DRAM CS1.
+# bit23-20: 0001, (write) M_ODT[1] is asserted during write to DRAM CS0.board/Marvell/openrd_base/kwbimage.cfg new file +4
-0+DATA 0xFFD01498 0x00000000 # DDR ODT Control (High) + +DATA 0xFFD0149C 0x0000E40f # CPU ODT Control +# bit3-0: 1111, internal ODT is asserted during read fromDRAM bank 0-3
+# bit11-10: 01,M_DQ,M_DM, andM_DQSI/O buffer ODT
Select: 150 ohmboard/Marvell/openrd_base/kwbimage.cfg new file +8
-0+# bit13-12: 10, M_STARTBURST_IN I/O buffer ODT Select: 75 ohm +# bit14: 1, M_STARTBURST_IN ODT: Enabled +# bit15: 1, DDR IO ODT Unit: Use ODT block +DATA 0xFFD01480 0x00000001 # DDR Initialization Control +#bit0=1, enable DDR init upon this register write + +# End of Header extension +DATA 0x0 0x0board/Marvell/openrd_base/openrd_base.c new file +0
-0
board/Marvell/openrd_base/openrd_base.c line 9
Quoted 9 lines
board/Marvell/openrd_base/openrd_base.c new file +9
-0@@ -0,0 +1,158 @@ +/* +* (C) Copyright 2009 +* Net Insight <www.netinsight.net> +* Written-by: Simon Kagstrom <[email protected]> +* +* Based on sheevaplug.c: +* (C) Copyright 2009 +* Marvell Semiconductor <www.marvell.com> +* Written-by: Prafulla Wadaskar <[email protected]>
You can follow the same documentation for above files
Quoted 84 lines
board/Marvell/openrd_base/openrd_base.c new file +33
-0+* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +* MA 02110-1301 USA +*/ + +#include <common.h> +#include <miiphy.h> +#include <asm/arch/kirkwood.h> +#include <asm/arch/mpp.h> +#include "openrd_base.h" + +DECLARE_GLOBAL_DATA_PTR ; + +int board_init (void ) +{ +/* +* default gpio configuration +* There are maximum 64 gpios controlled through 2 sets of registers
board/Marvell/openrd_base/openrd_base.c new file +50
-0+* the below configuration configures mainly initial LED status +*/ +kw_config_gpio (OPENRD_OE_VAL_LOW , +OPENRD_OE_VAL_HIGH , +OPENRD_OE_LOW ,OPENRD_OE_HIGH ); + +/* Multi-Purpose Pins Functionality configuration */ +u32 kwmpp_config[] = { +MPP0_NF_IO2 , +MPP1_NF_IO3 , +MPP2_NF_IO4 , +MPP3_NF_IO5 , +MPP4_NF_IO6 , +MPP5_NF_IO7 , + MPP6_SYSRST_OUTn, +MPP7_GPO , +MPP8_TW_SDA , +MPP9_TW_SCK , +MPP10_UART0_TXD , +MPP11_UART0_RXD , +MPP12_SD_CLK , +MPP13_SD_CMD ,/* Alt UART1_TXD */ +MPP14_SD_D0 ,/* Alt UART1_RXD */ +MPP15_SD_D1 , +MPP16_SD_D2 , +MPP17_SD_D3 , +MPP18_NF_IO0 , +MPP19_NF_IO1 , +MPP20_GE1_0 , +MPP21_GE1_1 , +MPP22_GE1_2 , +MPP23_GE1_3 , +MPP24_GE1_4 , +MPP25_GE1_5 , +MPP26_GE1_6 , +MPP27_GE1_7 , +MPP28_GPIO , +MPP29_TSMP9 , +MPP30_GE1_10 , +MPP31_GE1_11 , +MPP32_GE1_12 , +MPP33_GE1_13 , +MPP34_GPIO ,/* UART1 / SD sel */ +MPP35_TDM_CH0_TX_QL , +MPP36_TDM_SPI_CS1 , +MPP37_TDM_CH2_TX_QL , +MPP38_TDM_CH2_RX_QL , +MPP39_AUDIO_I2SBCLK , +MPP40_AUDIO_I2SDO , +MPP41_AUDIO_I2SLRC ,
board/Marvell/openrd_base/openrd_base.c line 102
Quoted 10 lines
board/Marvell/openrd_base/openrd_base.c new file +10
-0+MPP42_AUDIO_I2SMCLK , +MPP43_AUDIO_I2SDI , +MPP44_AUDIO_EXTCLK , +MPP45_TDM_PCLK , +MPP46_TDM_FS , +MPP47_TDM_DRX , +MPP48_TDM_DTX , +MPP49_TDM_CH0_RX_QL , +0 + };
Looks better if empty line can be inserted here
board/Marvell/openrd_base/openrd_base.c line 112
Quoted 10 lines
board/Marvell/openrd_base/openrd_base.c new file +10
-0+kirkwood_mpp_conf (kwmpp_config); + +/* +* arch number of board +*/ + gd->bd->bi_arch_number =MACH_TYPE_OPENRD_BASE ; + +/* adress of boot parameters */ + gd->bd->bi_boot_params =kw_sdram_bar (0 ) +0x100 ; +return 0 ;
Pls correct indentation b y using tabs only here and everywhere
Quoted 134 lines
board/Marvell/openrd_base/openrd_base.c new file +46
-0+} + +int dram_init (void ) +{ +int i; + +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; i++) { + gd->bd->bi_dram[i].start =kw_sdram_bar (i); + gd->bd->bi_dram[i].size =kw_sdram_bs (i); + } +return 0 ; +} + +#ifdef CONFIG_RESET_PHY_R +void reset_phy (void ) +{ +u16 reg; +u16 devadr; +char *name ="egiga0" ; + +if (miiphy_set_current_dev (name)) +return ; + +/* command to read PHY dev address */ +if (miiphy_read (name,0xEE ,0xEE , (u16 *) &devadr)) { +printf ("Err..%s could not read PHY dev address\n" , + __FUNCTION__); +return ; + } + +/* +* Enable RGMII delay on Tx and Rx for CPU port +* Ref: sec 4.7.2 of chip datasheet +*/ +miiphy_write (name, devadr,MV88E1116_PGADR_REG ,2 ); +miiphy_read (name, devadr,MV88E1116_MAC_CTRL_REG , ®); + reg |= (MV88E1116_RGMII_RXTM_CTRL |MV88E1116_RGMII_TXTM_CTRL ); +miiphy_write (name, devadr,MV88E1116_MAC_CTRL_REG , reg); +miiphy_write (name, devadr,MV88E1116_PGADR_REG ,0 ); + +/* reset the phy */ +miiphy_reset (name, devadr); + +printf ("88E1116 Initialized on %s\n" , name); +} +#endif /* CONFIG_RESET_PHY_R */ board/Marvell/openrd_base/openrd_base.h new file +33
-0@@ -0,0 +1,46 @@ +/* +* (C) Copyright 2009 +* Net Insight <www.netinsight.net> +* Written-by: Simon Kagstrom <[email protected]> +* +* Based on sheevaplug.h: +* (C) Copyright 2009 +* Marvell Semiconductor <www.marvell.com> +* Written-by: Prafulla Wadaskar <[email protected]> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +* MA 02110-1301 USA +*/ + +#ifndef __OPENRD_BASE_H +#define __OPENRD_BASE_H + +#define OPENRD_OE_LOW (~(1<<28))/* RS232 / RS485 */
+#defineOPENRD_OE_HIGH(~(1<<2)) /* SD
/ UART1 */board/Marvell/openrd_base/openrd_base.h new file +12
-0+#define OPENRD_OE_VAL_LOW (0)/* Sel RS232 */ +#define OPENRD_OE_VAL_HIGH (1 << 2)/* Sel SD */ + +/* PHY related */ +#define MV88E1116_LED_FCTRL_REG 10 +#define MV88E1116_CPRSP_CR3_REG 21 +#define MV88E1116_MAC_CTRL_REG 21 +#define MV88E1116_PGADR_REG 22 +#define MV88E1116_RGMII_TXTM_CTRL (1 << 4) +#define MV88E1116_RGMII_RXTM_CTRL (1 << 5) + +#endif /* __OPENRD_BASE_H */ include/configs/openrd_base.h new file +26
-0@@ -0,0 +1,218 @@ +/* +* (C) Copyright 2009 +* Net Insight <www.netinsight.net> +* Written-by: Simon Kagstrom <[email protected]> +* +* Based on sheevaplug.h: +* (C) Copyright 2009 +* Marvell Semiconductor <www.marvell.com> +* Written-by: Prafulla Wadaskar <[email protected]> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
include/configs/openrd_base.h line 36
Quoted 10 lines
include/configs/openrd_base.h new file +10
-0+* MA 02110-1301 USA +*/ + +#ifndef _CONFIG_OPENRD_BASE_H +#define _CONFIG_OPENRD_BASE_H + +/* +* Version number information +*/ +#define CONFIG_IDENT_STRING "\nMarvell-OpenRD_base"
Is this name in synce with what you have registered on armlinux with machin-id? Can you pls use short name here?
Quoted 8 lines
include/configs/openrd_base.h new file +7
-0+ +/* +* High Level Configuration Options (easy to change) +*/ +#define CONFIG_MARVELL 1 +#define CONFIG_ARM926EJS 1/* Basic Architecture */ +#define CONFIG_FEROCEON_88FR131 1/* CPU Core subversion */
Pls Use CONFIG_SHEEVA_88SV131 here
Quoted 5 lines
include/configs/openrd_base.h new file +5
-0+#define CONFIG_KIRKWOOD 1/* SOC Family Name */ +#define CONFIG_KW88F6281 1/* SOC Name */ +#define CONFIG_MACH_OPENRD_BASE /* Machine type */ + +#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5
Quoted 7 lines
support */
+#defineCONFIG_SKIP_LOWLEVEL_INIT/* disable boardlowlevel_init*/
+#defineCONFIG_KIRKWOOD_EGIGA_INIT/* Enable GbePort0/1
for kernel */
+#defineCONFIG_KIRKWOOD_RGMII_PAD_1V8/* Set RGMII
Pad voltage to 1.8V */
Does this board have PCI interface, if yet then pls include following line
#define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */
Quoted 55 lines
+#define
CONFIG_MV88E1116/* Support for the
MV88E1116 PHY */include/configs/openrd_base.h new file +18
-0+ +/* +* CLKs configurations +*/ +#define CONFIG_SYS_HZ 1000 + +/* +* NS16550 Configuration +*/ +#define CONFIG_SYS_NS16550 +#define CONFIG_SYS_NS16550_SERIAL +#define CONFIG_SYS_NS16550_REG_SIZE (-4) +#define CONFIG_SYS_NS16550_CLK CONFIG_SYS_TCLK +#define CONFIG_SYS_NS16550_COM1 KW_UART0_BASE + +/* +* Serial Port configuration +* The following definitions let you select what serial you want to use
+ * for your console driver.
+ */include/configs/openrd_base.h new file +5
-0+ +#define CONFIG_CONS_INDEX 1/*Console on UART0 */ +#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, \ + 115200,230400,460800, 921600 }
include/configs/openrd_base.h new file +13
-0+/* auto boot */ +#define CONFIG_BOOTDELAY 3/* default enable autoboot */ + +/* +* For booting Linux, the board info and command line data +* have to be in the first 8 MB of memory, since this is +* the maximum mapped by the Linux kernel during initialization. +*/ +#define CONFIG_CMDLINE_TAG 1/* enable passing of ATAGs */ +#define CONFIG_INITRD_TAG 1/* enable INITRD tag */ +#define CONFIG_SETUP_MEMORY_TAGS 1/* enable memory tag */ + +#define CONFIG_SYS_PROMPT "Marvell>> "/* Command Prompt */
+#defineCONFIG_SYS_CBSIZE1024 /* Console I/O
Buff Size */include/configs/openrd_base.h new file +10
-0+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE \ + +sizeof(CONFIG_SYS_PROMPT) + 16)/* Print Buff */ +/* +* Commands configuration +*/ +#define CONFIG_CMD_AUTOSCRIPT +#define CONFIG_CMD_BOOTD +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_ENV +#define CONFIG_CMD_FAT
include/configs/openrd_base.h line 111
Quoted 10 lines
include/configs/openrd_base.h new file +10
-0+#define CONFIG_CMD_LOADB +#define CONFIG_CMD_MEMORY +#define CONFIG_CMD_NAND +#define CONFIG_CMD_NET +#define CONFIG_CMD_MII +#define CONFIG_CMD_PING +#define CONFIG_CMD_RUN +#define CONFIG_CMD_SAVEENV +#define CONFIG_CMD_USB +#define CONFIG_CMD_IMI
Again I suggest to use config_cmd_default.h here :-) to bring it in sync with other Marvell and arm boards configuration
Quoted 29 lines
include/configs/openrd_base.h new file +5
-0+/* +* Flash configuration +*/ +#ifndef CONFIG_CMD_FLASH +#define CONFIG_SYS_NO_FLASH 1/* Declare no flash (NOR/SPI) */
include/configs/openrd_base.h new file +10
-0+#endif + +/* +* NAND configuration +*/ +#ifdef CONFIG_CMD_NAND +#define CONFIG_NAND_KIRKWOOD +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define NAND_MAX_CHIPS 1 +#define CONFIG_SYS_NAND_BASE 0xD8000000/*
KW_DEFADR_NANDF*/include/configs/openrd_base.h new file +11
-0+#define NAND_ALLOW_ERASE_ALL 1 +#endif + +/* +* Environment variables configurations +*/ +#ifdef CONFIG_CMD_NAND +#define CONFIG_ENV_IS_IN_NAND 1 +#define CONFIG_ENV_SECT_SIZE 0x20000/* 128K */ +#else +#define CONFIG_ENV_IS_NOWHERE 1/* if env in SDRAM */
include/configs/openrd_base.h line 145
Quoted 8 lines
include/configs/openrd_base.h new file +8
-0+#endif +/* +* max 4k env size is enough, but in case of nand +* it has to be rounded to sector size +*/ +#define CONFIG_ENV_SIZE 0x20000/* 128k */ +#define CONFIG_ENV_ADDR 0xa0000 +#define CONFIG_ENV_OFFSET 0xa0000/* env starts here */
Do you really need this address? the u-boot binary is within 256kb, at the most it can go till 512kb
Quoted 10 lines
include/configs/openrd_base.h new file +10
-0+ +/* +* Default environment variables +*/ +#define CONFIG_BOOTCOMMAND "${x_bootcmd_kernel}; " \ + "setenv bootargs ${x_bootargs} ${x_bootargs_root}; " \ + "${x_bootcmd_usb}; bootm 0x6400000;" + +#define MTDIDS_DEFAULT "nand0=nand_mtd" +#define MTDPARTS_DEFAULT
Quoted 3 lines
"mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000( uImage),"\
+ "0x1fb00000at 0x500000(rootfs)"
This is must be the default setup in board setup file for openrd_base (if it is again derived from sheevaplug) In that case this settings not required
include/configs/openrd_base.h line 161
Quoted 5 lines
include/configs/openrd_base.h new file +5
-0+ +#define CONFIG_EXTRA_ENV_SETTINGS "x_bootargs=console" \ + "=ttyS0,115200 "MTDPARTS_DEFAULT " rw ubi.mtd=2,2048\0" \ + "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \ + "x_bootcmd_usb=usb start\0" \
You must add x_bootcmd_eth for program MAC addrss in hardware before kernel boot.
Quoted 56 lines
include/configs/openrd_base.h new file +8
-0+"x_bootargs_root=root=ubi0:rootfs rootfstype=ubifs\0" \ +"mtdids=" MTDIDS_DEFAULT "\0" \ +"mtdparts=" MTDPARTS_DEFAULT "\0" + +/* +* Size of malloc() pool +*/ +#define CONFIG_SYS_MALLOC_LEN (1024 * 1024) /* 1MiBfor
malloc()*/include/configs/openrd_base.h new file +15
-0+/* size in bytes reserved for initial data */ +#define CONFIG_SYS_GBL_DATA_SIZE 128 + +/* +* Other required minimal configurations +*/ +#define CONFIG_SYS_LONGHELP +#define CONFIG_AUTO_COMPLETE +#define CONFIG_CMDLINE_EDITING +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */ +#define CONFIG_ARCH_MISC_INIT /* call arch_misc_init() */ +#define CONFIG_DISPLAY_CPUINFO /* Display cpu info */ +#define CONFIG_NR_DRAM_BANKS 4 +#define CONFIG_STACKSIZE 0x00100000/* regular stack- 1M */ +#define CONFIG_SYS_LOAD_ADDR 0x00800000/* default load adr- 8M */
include/configs/openrd_base.h new file +11
-0+#define CONFIG_SYS_MEMTEST_START 0x00400000/* 4M */ +#define CONFIG_SYS_MEMTEST_END 0x007fffff/*(_8M -1) */ +#define CONFIG_SYS_RESET_ADDRESS 0xffff0000/* Rst Vector Adr */ +#define CONFIG_SYS_MAXARGS 16/* max number of command args */ + +/* +* Ethernet Driver configuration +*/ +#ifdef CONFIG_CMD_NET +#define CONFIG_NETCONSOLE /* include NetConsole support */ +#define CONFIG_NET_MULTI /* specify more that one ports available */
+#defineCONFIG_MII/* expose smi ove
miiphy interface */
+#defineCONFIG_KIRKWOOD_EGIGA/* Enable kirkwood Gbe
Controller Driver */
+#defineCONFIG_SYS_FAULT_ECHO_LINK_DOWN/* detect link
using phy */include/configs/openrd_base.h new file +4
-0+#define CONFIG_KIRKWOOD_EGIGA_PORTS {1,0}/* enable port 0 only */ +#define CONFIG_PHY_BASE_ADR 0x8 +#define CONFIG_ENV_OVERWRITE /* ethaddr can be reprogrammed */ +#define CONFIG_RESET_PHY_R /* use reset_phy() to init mv8831116 PHY */
include/configs/openrd_base.h new file +7
-0+#endif /* CONFIG_CMD_NET */ + +/* +* USB/EHCI +*/ +#ifdef CONFIG_CMD_USB +#define CONFIG_USB_EHCI /* Enable EHCI USB support */
include/configs/openrd_base.h
Quoted 10 lines
include/configs/openrd_base.h new file +9
-1+#define CONFIG_USB_EHCI_KIRKWOOD /* on Kirkwood platform */ +#define CONFIG_EHCI_IS_TDI +#define CONFIG_USB_STORAGE +#define CONFIG_DOS_PARTITION +#define CONFIG_ISO_PARTITION +#define CONFIG_SUPPORT_VFAT +#endif /* CONFIG_CMD_USB */ + +#endif /* _CONFIG_OPENRD_BASE_H */ --
Regards..
Prafulla . .
Quoted 3 lines
1.6.0.4
PATCH v2 1/1 Support for the OpenRD base board
Thanks for the comments Prafulla!
I'll update the patch according to them, but have some questions:
Quoted 4 lines · On Fri, 11 Sep 2009 03:43:04 -0700 Prafulla Wadaskar <[email protected]>…
include/configs/openrd_base.h line 145
Quoted 3 lines
include/configs/openrd_base.h new file +3
-0+#define CONFIG_ENV_SIZE 0x20000/* 128k */ +#define CONFIG_ENV_ADDR 0xa0000 +#define CONFIG_ENV_OFFSET 0xa0000/* env starts here */ Do you really need this address? the u-boot binary is within 256kb, at the most it can go till 512kb
This is where the default environment (for the U-boot shipped by Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC, so current U-boot won't be able to read it, but I know you're working on it.
Quoted 7 lines
Quoted 5 lines
(quoted diff) +2
-0+#define MTDIDS_DEFAULT "nand0=nand_mtd" +#define MTDPARTS_DEFAULT"mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000( uImage),"\
+ "0x1fb00000at 0x500000(rootfs)"This is must be the default setup in board setup file for
openrd_base(if it is again derived from sheevaplug) In that case this settings not required
I don't quite understand this. This is also the default addresses shipped with the board.
Quoted 5 lines
include/configs/openrd_base.h line 161
Quoted 4 lines
include/configs/openrd_base.h new file +4
-0+#define CONFIG_EXTRA_ENV_SETTINGS "x_bootargs=console" \ + "=ttyS0,115200 "MTDPARTS_DEFAULT " rw ubi.mtd=2,2048\0" \ + "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \ + "x_bootcmd_usb=usb start\0" \You must add
x_bootcmd_ethfor program MAC addrss in hardware before kernel boot.
Well, we need to figure out some generic way of giving Linux the MAC address on these boards, but I've understood that initializing the interface without using it is not popular, so in this case I'd just let the problem remain (no x_bootcmd_eth).
Or did I misunderstand your comment?
// Simon
PATCH v2 1/1 Support for the OpenRD base board
Quoted 20 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Friday, September 11, 2009 5:48 PM
To: Prafulla Wadaskar
Cc: U-Boot ML; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
Subject: Re: [PATCH v2] Support for the OpenRD base boardThanks for the comments Prafulla!
I'll update the patch according to them, but have some questions:
Quoted 3 lines · On Fri, 11 Sep 2009 03:43:04 -0700 Prafulla Wadaskar <[email protected]>…
include/configs/openrd_base.h
Quoted 3 lines
include/configs/openrd_base.h new file +3
-0+#define CONFIG_ENV_SIZE 0x20000/* 128k */ +#define CONFIG_ENV_ADDR 0xa0000 +#define CONFIG_ENV_OFFSET 0xa0000/* env starts here */
Quoted 6 lines
Quoted 1 line
Do you really need this address? the u-boot binary is
within 256kb, at the most it can go till 512kb
This is where the default environment (for the U-boot shipped by Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC, so current U-boot won't be able to read it, but I know you're working on it.
So I think, you want to retain both environment variables untouched
( i.e. latest u-boot and u-boot shipped by Marvell)
But so far as mainlined u-boot is considered,
doesn't it make sense to pack uboot-bin and environment sector together?
like sheevaplug, I think first 2 sectors for u-boot and next once sector for env should be better to choose.
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
(quoted diff) +2
-0+#define MTDIDS_DEFAULT "nand0=nand_mtd" +#define MTDPARTS_DEFAULT"mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000( uImage),"\
+ "0x1fb00000at 0x500000(rootfs)"This is must be the default setup in board setup file for
Quoted 5 lines
openrd_base(if it is again derived from sheevaplug)Quoted 1 line
In that case this settings not required
I don't quite understand this. This is also the default addresses shipped with the board.
W..r.to line 24 at http://git.marvell.com/?p=orion.git;a=blob;f=arch/arm/mach-kirkwood/openrd_base-setup.c;h=947dfb8cd5b252bf326d691ee5179e29ad07a9a9;hb=HEAD
By default kernel has same mdtpart configuration as you are describing here.
So you don't need this default setup here, you should skip it
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
include/configs/openrd_base.h new file +4
-0+#define CONFIG_EXTRA_ENV_SETTINGS "x_bootargs=console" \ + "=ttyS0,115200 "MTDPARTS_DEFAULT " rw ubi.mtd=2,2048\0" \ + "x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \ + "x_bootcmd_usb=usb start\0" \
Quoted 8 lines
Quoted 1 line
You must add
x_bootcmd_ethfor program MAC addrss inhardware before kernel boot.
Well, we need to figure out some generic way of giving Linux the MAC address on these boards, but I've understood that initializing the interface without using it is not popular, so in this case I'd just let
the problem remain (nox_bootcmd_eth).
Okay,
Quoted 2 lines
Or did I misunderstand your comment?
No you understood it properly
As per my knowledge, I don't this the any hack for this in kernel will be accepted. The same is with u-boot arm net drivers.
At both places fingures are crossed. s/w guys thinks h/w should take care of this. But unfortunately this is not happening with this h/w (may be there are few more). I personally feel that u-boot should handle this (copying ben for this)
Regards..
Prafulla . .
Quoted 3 lines
// Simon
PATCH v2 1/1 Support for the OpenRD base board
Quoted 7 lines · On Fri, 11 Sep 2009 06:33:44 -0700 Prafulla Wadaskar <[email protected]>…
Quoted 7 lines
Quoted 3 lines
include/configs/openrd_base.h
Quoted 3 lines
include/configs/openrd_base.h new file +3
-0+#define CONFIG_ENV_SIZE 0x20000/* 128k */ +#define CONFIG_ENV_ADDR 0xa0000 +#define CONFIG_ENV_OFFSET 0xa0000/* env starts here */
Quoted 1 line
Do you really need this address? the u-boot binary is
within 256kb, at the most it can go till 512kb
Quoted 8 lines
Quoted 3 lines
This is where the default environment (for the U-boot shipped by Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC, so current U-boot won't be able to read it, but I know you're working on it.
So I think, you want to retain both environment variables untouched
( i.e. latest u-boot and u-boot shipped by Marvell)
But so far as mainlined u-boot is considered,
doesn't it make sense to pack uboot-bin and environment sector together?
like sheevaplug, I think first 2 sectors for u-boot and next once sector for env should be better to choose.
Right, makes sense. I'll update that and skip the current address.
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +2
-0+#define MTDIDS_DEFAULT "nand0=nand_mtd" +#define MTDPARTS_DEFAULT"mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000( uImage),"\
+ "0x1fb00000at 0x500000(rootfs)"I don't quite understand this. This is also the default addresses shipped with the board.
Quoted 3 lines
W..r.to line 24 at http://git.marvell.com/?p=orion.git;a=blob;f=arch/arm/mach-kirkwood/openrd_base-setup.c;h=947dfb8cd5b252bf326d691ee5179e29ad07a9a9;hb=HEAD
By default kernel has same mdtpart configuration as you are describing here.
So you don't need this default setup here, you should skip it
OK, I understand. However, but it might also be useful from U-boot. Locally, I've loaded the kernel from the ubifs partition, and then it's useful to have this defined in U-boot as well. If it shouldn't be there by default, I'll remove it though.
// Simon
PATCH v2 1/1 Support for the OpenRD base board
Quoted 50 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Friday, September 11, 2009 7:22 PM
To: Prafulla Wadaskar
Cc: U-Boot ML; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare; Ben Warren
Subject: Re: [PATCH v2] Support for the OpenRD base boardQuoted 1 line · On Fri, 11 Sep 2009 06:33:44 -0700 Prafulla Wadaskar <[email protected]>…
Quoted 1 line
Quoted 1 line
Quoted 1 line
+#define
CONFIG_ENV_SIZE0x20000/* 128k */
Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+#define CONFIG_ENV_ADDR 0xa0000 +#define CONFIG_ENV_OFFSET 0xa0000 /* envstarts here */
Quoted 1 line
Do you really need this address? the u-boot binary is
within 256kb, at the most it can go till 512kb
This is where the default environment (for the U-boot shipped by Marvell) resides. Like on Sheevaplug, it uses 4-bit ECC,
so current
Quoted 5 lines
Quoted 1 line
U-boot won't be able to read it, but I know you're working on it.
So I think, you want to retain both environment variables untouched
( i.e. latest u-boot and u-boot shipped by Marvell)
But so far as mainlined u-boot is considered,
doesn't it make sense to pack uboot-bin and environmentsector together?
Quoted 1 line
like sheevaplug, I think first 2 sectors for u-boot and
next once sector for env should be better to choose.
Right, makes sense. I'll update that and skip the current address.
Quoted 10 lines
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +2
-0+#define MTDIDS_DEFAULT "nand0=nand_mtd" +#define MTDPARTS_DEFAULT"mtdparts=nand_mtd:0x100000 at 0x000000(uboot),0x400000 at 0x100000( uImage),"\
+ "0x1fb00000at 0x500000(rootfs)"I don't quite understand this. This is also the default addresses shipped with the board.
W..r.to line 24 at
http://git.marvell.com/?p=orion.git;a=blob;f=arch/arm/mach-kir
kwood/openrd_base-setup.c;h=947dfb8cd5b252bf326d691ee5179e29ad 07a9a9;hb=HEADQuoted 1 line
By default kernel has same mdtpart configuration as you are
describing here.
Quoted 8 lines
Quoted 1 line
So you don't need this default setup here, you should skip it
OK, I understand. However, but it might also be useful from U-boot. Locally, I've loaded the kernel from the ubifs partition, and then it's
useful to have this defined in U-boot as well. If it shouldn't be there
by default, I'll remove it though.
Yes.
I leave decision up to you for this. My intension was to save some thing which is not required
Regards..
Prafulla. . .
Quoted 3 lines
// Simon
PATCH v3 1/1 Support for the OpenRD base board
In reply to Simon KagstromSupport for the OpenRD base board
The implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code and likely to be a bit incomplete.
---
The configuration does not include UBIFS support, which still needs the remaining patches for the bitops cleanup and fixes:
http://lists.denx.de/pipermail/u-boot/2009-August/059285.html
to build. Until those are applied, it's turned off here.
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards). This patch fixes that:
http://lists.denx.de/pipermail/u-boot/2009-September/059896.html
ChangeLog:
v2: kwbimage.cfg, which is needed to produce an image to install on the
NAND flash, has been added
v3: Updated after Prafullas review:
* Correct typo in comment section :-)
* Update copyright references
* Correct bit meaning in kwbimage.cfg according to new specification
* Add empty line after MPP configuration
* Use short name for board identity string in config
* Use CONFIG_SHEEVA_88SV131 instead of Feroceon
* Add CONFIG_KIRKWOOD_PCIE_INIT to config
* Use config_cmd_default.h and remove options which are not needed anymore
* Move config address to 0x60000 (384KB). I'd like it at this address since adding UBI/UBIFS support to U-boot makes the binary a bit more than 300KB and would thus overlap a config address at 0x40000.
Not updated in v3:
* The default MTD options are kept (useful for UBIFS)
* eth init is not done, this needs to be done in a generic way
MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 56 ++++++++ board/Marvell/openrd_base/config.mk | 33 +++++ board/Marvell/openrd_base/kwbimage.cfg | 168 +++++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.c | 160 +++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 209 +++++++++++++++++++++++++++++++ 9 files changed, 680 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/kwbimage.cfg create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.h
MAINTAINERS +4 -0
@@ -588,6 +588,10 @@ Gary Jennejohn <[email protected]> Konstantin Kletschke <[email protected]> scb9328 ARM920T +Simon Kagstrom <[email protected]> + + openrd_base ARM926EJS (Kirkwood SoC) + Nishant Kamat <[email protected]> omap1610h2 ARM926EJS
MAKEALL +1 -0
@@ -533,6 +533,7 @@ LIST_ARM9=" \ omap1610inn \ omap5912osk \ omap730p2 \ + openrd_base \ rd6281a \ sbc2410x \ scb9328 \
Makefile +3 -0
@@ -3022,6 +3022,9 @@ omap1610h2_cs_autoboot_config: unconfig omap5912osk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs omap5912osk ti omap +openrd_base_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + xtract_omap730p2 = $(subst _cs0boot,,$(subst _cs3boot,, $(subst _config,,$1))) omap730p2_config \
board/Marvell/openrd_base/Makefile new file +56 -0
56 lines not on this page · raw message
board/Marvell/openrd_base/config.mk new file +33 -0
@@ -0,0 +1,33 @@ +# +# (C) Copyright 2009 +# Net Insight <www.netinsight.net> +# Written-by: Simon Kagstrom <[email protected]> +# +# Based on sheevaplug: +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +TEXT_BASE = 0x00600000 + +# Kirkwood Boot Image configuration file +KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
board/Marvell/openrd_base/kwbimage.cfg new file +168 -0
168 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.c new file +160 -0
160 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.h new file +46 -0
46 lines not on this page · raw message
include/configs/openrd_base.h new file +209 -0
209 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH v3 1/1 Support for the OpenRD base board
Quoted 10 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Monday, September 14, 2009 1:17 PM
To: U-Boot ML
Cc: Prafulla Wadaskar; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
Subject: [PATCH v3] Support for the OpenRD base boardSupport for the OpenRD base board
Hi Simon
Two small things-
Can you pls remove this line, git log shows two lines since subject is also the same
Quoted 4 lines
The implementation is borrowed from the sheevaplug board and the Marvell
1.1.4 code and likely to be a bit incomplete.
Though you have specified below ---,
it is better if you can specify what's incomplete here since it will appear in git log. If that is UBIFS only, then I don't think it is incomplete :-)
Rest is okay
Regards..
Prafulla . .
PATCH v4 1/1 Support for the OpenRD base board
In reply to Simon KagstromThe implementation is borrowed from the sheevaplug board and the Marvell 1.1.4 code. Unsupported (or untested) is the SD card, PCIe and SATA.
---
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards).
ChangeLog:
v2: kwbimage.cfg, which is needed to produce an image to install on the
NAND flash, has been added
v3: Updated after Prafullas review:
* Correct typo in comment section :-)
* Update copyright references
* Correct bit meaning in kwbimage.cfg according to new specification
* Add empty line after MPP configuration
* Use short name for board identity string in config
* Use CONFIG_SHEEVA_88SV131 instead of Feroceon
* Add CONFIG_KIRKWOOD_PCIE_INIT to config
* Use config_cmd_default.h and remove options which are not needed anymore
* Move config address to 0x60000 (384KB). I'd like it at this address since adding UBI/UBIFS support to U-boot makes the binary a bit more than 300KB and would thus overlap a config address at 0x40000.
Not updated in v3:
* The default MTD options are kept (useful for UBIFS)
* eth init is not done, this needs to be done in a generic way
v4: Updated after Prafullas second review:
* Remove the double title line
* Change the description to note what's not tested
* Re-enable UBIFS since the bitops patch was merged
Thanks for the reviews, Prafulla!
MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 56 ++++++++ board/Marvell/openrd_base/config.mk | 33 +++++ board/Marvell/openrd_base/kwbimage.cfg | 168 +++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.c | 160 ++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 220 +++++++++++++++++++++++++++++++ 9 files changed, 691 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/kwbimage.cfg create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.h
MAINTAINERS +4 -0
@@ -588,6 +588,10 @@ Gary Jennejohn <[email protected]> Konstantin Kletschke <[email protected]> scb9328 ARM920T +Simon Kagstrom <[email protected]> + + openrd_base ARM926EJS (Kirkwood SoC) + Nishant Kamat <[email protected]> omap1610h2 ARM926EJS
MAKEALL +1 -0
@@ -533,6 +533,7 @@ LIST_ARM9=" \ omap1610inn \ omap5912osk \ omap730p2 \ + openrd_base \ rd6281a \ sbc2410x \ scb9328 \
Makefile +3 -0
@@ -3022,6 +3022,9 @@ omap1610h2_cs_autoboot_config: unconfig omap5912osk_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs omap5912osk ti omap +openrd_base_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + xtract_omap730p2 = $(subst _cs0boot,,$(subst _cs3boot,, $(subst _config,,$1))) omap730p2_config \
board/Marvell/openrd_base/Makefile new file +56 -0
56 lines not on this page · raw message
board/Marvell/openrd_base/config.mk new file +33 -0
@@ -0,0 +1,33 @@ +# +# (C) Copyright 2009 +# Net Insight <www.netinsight.net> +# Written-by: Simon Kagstrom <[email protected]> +# +# Based on sheevaplug: +# (C) Copyright 2009 +# Marvell Semiconductor <www.marvell.com> +# Written-by: Prafulla Wadaskar <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +TEXT_BASE = 0x00600000 + +# Kirkwood Boot Image configuration file +KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
board/Marvell/openrd_base/kwbimage.cfg new file +168 -0
168 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.c new file +160 -0
160 lines not on this page · raw message
board/Marvell/openrd_base/openrd_base.h new file +46 -0
46 lines not on this page · raw message
include/configs/openrd_base.h new file +220 -0
220 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH v4 1/1 Support for the OpenRD base board
Quoted 38 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Monday, September 21, 2009 4:24 PM
To: U-Boot ML
Cc: Prafulla Wadaskar; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
Subject: Re: [U-Boot] [PATCH v4] Support for the OpenRD base boardThe implementation is borrowed from the sheevaplug board and the Marvell
1.1.4 code. Unsupported (or untested) is the SD card, PCIe and SATA.Signed-off-by Simon Kagstrom <[email protected]>---
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards).ChangeLog:
v2: kwbimage.cfg, which is needed to produce an image to install on the
NAND flash, has been added
v3: Updated after Prafullas review:
* Correct typo in comment section :-)
* Update copyright references
* Correct bit meaning in kwbimage.cfg according to new specification
* Add empty line after MPP configuration
* Use short name for board identity string in config
* UseCONFIG_SHEEVA_88SV131instead of Feroceon
* AddCONFIG_KIRKWOOD_PCIE_INITto config
* Useconfig_cmd_default.hand remove options which are not
needed anymore
* Move config address to0x60000(384KB). I'd like it at
this address since
adding UBI/UBIFS support to U-boot makes the binary a bit
more than 300KB
Quoted 8 lines
and would thus overlap a config address at 0x40000.Not updated in v3:
* The default MTD options are kept (useful for UBIFS)
* eth init is not done, this needs to be done in a generic way
v4: Updated after Prafullas second review:
* Remove the double title line
* Change the description to note what's not tested
* Re-enable UBIFS since the bitops patch was merged
Oh that's great, so it's perfect now.
Quoted 2 lines
Thanks for the reviews, Prafulla!
That's my pleasure too :-)
Regards..
Prafulla . .
PATCH v4 1/1 Support for the OpenRD base board
In reply to Simon KagstromQuoted 59 lines
-----Original Message-----
From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
Sent: Monday, September 21, 2009 4:24 PM
To: U-Boot ML
Cc: Prafulla Wadaskar; Dhaval Vasa; Prabhanjan Sarnaik; Ashish Karkare
Subject: Re: [U-Boot] [PATCH v4] Support for the OpenRD base boardThe implementation is borrowed from the sheevaplug board and the Marvell
1.1.4 code. Unsupported (or untested) is the SD card, PCIe and SATA.Signed-off-by Simon Kagstrom <[email protected]>---
I get run-time problems when building for armv5te for OpenRD base (apparently the same problem occurs for other Kirkwood boards).ChangeLog:
v2: kwbimage.cfg, which is needed to produce an image to install on the
NAND flash, has been added
v3: Updated after Prafullas review:
* Correct typo in comment section :-)
* Update copyright references
* Correct bit meaning in kwbimage.cfg according to new specification
* Add empty line after MPP configuration
* Use short name for board identity string in config
* UseCONFIG_SHEEVA_88SV131instead of Feroceon
* AddCONFIG_KIRKWOOD_PCIE_INITto config
* Useconfig_cmd_default.hand remove options which are not
needed anymore
* Move config address to0x60000(384KB). I'd like it at
this address since
adding UBI/UBIFS support to U-boot makes the binary a bit
more than 300KBand would thus overlap a config address at 0x40000.Not updated in v3:
* The default MTD options are kept (useful for UBIFS)
* eth init is not done, this needs to be done in a generic way
v4: Updated after Prafullas second review:
* Remove the double title line
* Change the description to note what's not tested
* Re-enable UBIFS since the bitops patch was mergedThanks for the reviews, Prafulla!
MAINTAINERS | 4 + MAKEALL | 1 + Makefile | 3 + board/Marvell/openrd_base/Makefile | 56 ++++++++ board/Marvell/openrd_base/config.mk | 33 +++++ board/Marvell/openrd_base/kwbimage.cfg | 168 +++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.c | 160 ++++++++++++++++++++++ board/Marvell/openrd_base/openrd_base.h | 46 +++++++ include/configs/openrd_base.h | 220
Quoted 9 lines
+++++++++++++++++++++++++++++++
9 files changed, 691 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/openrd_base/Makefile create mode 100644 board/Marvell/openrd_base/config.mk create mode 100644 board/Marvell/openrd_base/kwbimage.cfg create mode 100644 board/Marvell/openrd_base/openrd_base.c create mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd_base.h
Applied to u-boot-marvell master branch
Regards..
Prafulla . .