Skip to contentSkip to conversation

dca: module load should not be an error message

PATCH Stephen Hemminger 3 participants 3 messages Sep 13, 2009 – Sep 14, 2009

lore
Share & tools
lore
#0 lore raw

The message (if it must exist) should not be an error message. IMHO such messages are useless.

---
I sent patch for this previously, but it seems to have been ignored.

drivers/dca/dca-core.c +1 -1
@@ -276,7 +276,7 @@ EXPORT_SYMBOL_GPL(dca_unregister_notify)
 
 static int __init dca_init(void)
 {
-	printk(KERN_ERR "dca service started, version %s\n", DCA_VERSION);
+	pr_info("dca service started, version %s\n", DCA_VERSION);
 	return dca_sysfs_init();
 }
 
#1 lore raw
Quoted 8 lines · Stephen Hemminger

The message (if it must exist) should not be an error message. IMHO such messages are useless.

---
I sent patch for this previously, but it seems to have been ignored.

Sorry about that... applied now. There are a couple other messages in drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be de-clawed. I'll take care of those.

Thanks,
Dan

#2 lore raw
Quoted 10 lines · Dan J
Quoted 8 lines · Stephen Hemminger

The message (if it must exist) should not be an error message. IMHO such messages are useless.

---
I sent patch for this previously, but it seems to have been ignored.

Quoted 6 lines

Sorry about that... applied now. There are a couple other messages in drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be de-clawed. I'll take care of those.

Thanks,
Dan

Thanks,
Maciej