mlx4: Fix access to freed memory
Subsystems (2)
PATCH 1/1 mlx4: Fix access to freed memory
catas_reset() uses pointer to mlx4_priv, but mlx4_priv is not valid after call mlx4_restart_one().
Signed-off-by Vitaliy Gusev <[email protected]>
drivers/net/mlx4/catas.c +8 -3
@@ -96,12 +96,17 @@ static void catas_reset(struct work_struct *work)spin_unlock_irq (&catas_lock);list_for_each_entry_safe (priv, tmppriv, &tlist, catas_err.list) { +struct pci_dev *pdev = priv->dev.pdev; + ret =mlx4_restart_one (priv->dev.pdev); - dev = &priv->dev; +/* 'priv' now is not valid */ if (ret) -mlx4_err (dev,"Reset failed (%d)\n" , ret); -else +printk (KERN_ERR "mlx4 %s: Reset failed (%d)\n" , +pci_name (pdev), ret); +else { + dev =pci_get_drvdata (pdev);mlx4_dbg (dev,"Reset succeeded\n" ); + } } }
Quoted 5 lines
catas_reset()uses pointer tomlx4_priv, butmlx4_privis not valid after callmlx4_restart_one().Signed-off-by Vitaliy Gusev <[email protected]>
Good catch. Dave, if you want me to take this, let me know, otherwise:
Acked-by Roland Dreier <[email protected]>
David Miller
maintainerFrom: Roland Dreier <[email protected]>
Date: Tue, 15 Sep 2009 11:23:33 -0700
Quoted 9 lines
Quoted 5 lines
catas_reset()uses pointer tomlx4_priv, butmlx4_privis not valid after callmlx4_restart_one().Signed-off-by Vitaliy Gusev <[email protected]>Good catch. Dave, if you want me to take this, let me know, otherwise:
Acked-by Roland Dreier <[email protected]>
I've got it, thanks everyone.