Skip to contentSkip to conversation

S3C64xx DMA: 'size' argument of dma_pool_create

PATCH New Jassi 2 participants 2 messages Sep 15, 2009

Subsystems (3)
lore
Share & tools
lore

Jassi

author
#0 lore raw

PATCH 2/7 S3C64xx DMA: 'size' argument of dma_pool_create

Provide actual minimum(struct pl080s_lli) size of block to dma_pool_create call, instead of hardcoded 32 bytes.

---
 arch/arm/plat-s3c64xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c64xx/dma.c +1 -1
index 67aa93d..b26d2a2 100644
@@ -697,7 +697,7 @@ static int __init s3c64xx_dma_init(void)
 
 	printk(KERN_INFO "%s: Registering DMA channels\n", __func__);
 
-	dma_pool = dma_pool_create("DMA-LLI", NULL, 32, 16, 0);
+	dma_pool = dma_pool_create("DMA-LLI", NULL, sizeof(struct pl080s_lli), 16, 0);
 	if (!dma_pool) {
 		printk(KERN_ERR "%s: failed to create pool\n", __func__);
 		return -ENOMEM;
Signature · 1 line
1.6.2.5
Applied
#1 lore raw

PATCH 2/7 S3C64xx DMA: 'size' argument of dma_pool_create

Quoted 4 lines · Jassi

Provide actual minimum(struct pl080s_lli) size of block to dma_pool_create call, instead of hardcoded 32 bytes.

Applied to next-s3c64xx-fixes

Quoted 25 lines
---
 arch/arm/plat-s3c64xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c64xx/dma.c +1 -1
index 67aa93d..b26d2a2 100644
@@ -697,7 +697,7 @@ static int __init s3c64xx_dma_init(void)
 
 	printk(KERN_INFO "%s: Registering DMA channels\n", __func__);
 
-	dma_pool = dma_pool_create("DMA-LLI", NULL, 32, 16, 0);
+	dma_pool = dma_pool_create("DMA-LLI", NULL, sizeof(struct pl080s_lli), 16, 0);
 	if (!dma_pool) {
 		printk(KERN_ERR "%s: failed to create pool\n", __func__);
 		return -ENOMEM;
Signature · 7 lines
1.6.2.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.