s3c6410: sdhci: Adding additional data in sdhci platform data structure.
Subsystems (2)
PATCH 2/8 s3c6410: sdhci: Adding additional data in sdhci platform data structure.
Hi,
this breaks hsmmc1 (and hsmmc2).
Attached patch fixes hsmmc1.
Regards,
Maurus Cuelenaere
From a743b9c3b7a6b63e2c0ccf22a45a06952920dff4 Mon Sep 17 00:00:00 2001
From: Maurus Cuelenaere <[email protected]>
Date: Sat, 12 Sep 2009 17:40:33 +0200
This patch adds additional information about the parent clock name, sdhci clock name and desired sdhci operating frequency for hsmmc1 (based on e52782df345ec3e826701438ef42d2a8425bb973).
--- arch/arm/plat-s3c/dev-hsmmc1.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/plat-s3c/dev-hsmmc1.c +3 -0
@@ -41,6 +41,9 @@ struct s3c_sdhci_platdata s3c_hsmmc1_def_platdata = { .max_width = 4, .host_caps = (MMC_CAP_4_BIT_DATA | MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED), + .clk_parent_name = "dout_mpll", + .clk_source_name = "mmc_bus", + .clk_speed = 50*MHZ, };struct platform_device s3c_device_hsmmc1 = {
Signature · 1 line
1.6.3.3
PATCH 2/8 s3c6410: sdhci: Adding additional data in sdhci platform data structure.
Hi Maurus,
The patch "[PATCH 6/8] s3c6410: sdhci: Modify platform data for sdhci-1" was submitted to populate the hsmmc1 platform data.
Thanks,
Thomas.
----- Original Message -----
From: "Maurus Cuelenaere" <[email protected]>
To: <[email protected]>; <[email protected]>
Sent: Saturday, September 12, 2009 9:34 PM
Subject: Re: [PATCH 2/8] s3c6410: sdhci: Adding additional data in sdhci platform data structure.
Quoted 40 lines
Hi,
this breaks hsmmc1 (and hsmmc2).
Attached patch fixes hsmmc1.
Regards,
Maurus CuelenaereFrom
a743b9c3b7a6b63e2c0ccf22a45a06952920dff4Mon Sep 17 00:00:00 2001
From: Maurus Cuelenaere <[email protected]>
Date: Sat, 12 Sep 2009 17:40:33 +0200This patch adds additional information about the parent clock name, sdhci clock name and desired sdhci operating frequency for hsmmc1 (based on
e52782df345ec3e826701438ef42d2a8425bb973).Signed-off-by Maurus Cuelenaere <[email protected]>--- arch/arm/plat-s3c/dev-hsmmc1.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)arch/arm/plat-s3c/dev-hsmmc1.c +3
-0@@ -41,6 +41,9 @@ struct s3c_sdhci_platdata s3c_hsmmc1_def_platdata = { .max_width = 4, .host_caps = (MMC_CAP_4_BIT_DATA | MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED), + .clk_parent_name = "dout_mpll", + .clk_source_name = "mmc_bus", + .clk_speed = 50*MHZ, };struct platform_device s3c_device_hsmmc1 = {Signature · 1 line
1.6.3.3
PATCH 2/8 s3c6410: sdhci: Adding additional data in sdhci platform data structure.
Thomas P. Abraham schreef:
Quoted 4 lines
Hi Maurus,
The patch "[PATCH 6/8] s3c6410: sdhci: Modify platform data for sdhci-1" was submitted to populate the hsmmc1 platform data.
Oh, I am sorry. I based myself upon
http://git.kernel.org/?p=linux/kernel/git/kki_ap/linux-2.6-samsung.git;a=shortlog;h=s3c6410-all
and probably forget to look at the actual patches you posted :)
Regards,
Maurus Cuelenaere
PATCH 2/8 s3c6410: sdhci: Adding additional data in sdhci platform data structure.
In reply to Thomas P. AbrahamQuoted 4 lines · Thomas P. Abraham
Hi Maurus,
The patch "[PATCH 6/8] s3c6410: sdhci: Modify platform data for sdhci-1" was submitted to populate the hsmmc1 platform data.
Please do not split the changes up like this, the best thing to do is that if a change in the setup is required for >1 device, then place them in one go so that changes applied do not leave the kernel broken in between commits.
Quoted 58 lines
Thanks,
Thomas.----- Original Message -----
From: "Maurus Cuelenaere" <[email protected]>
To: <[email protected]>; <[email protected]>
Sent: Saturday, September 12, 2009 9:34 PM
Subject: Re: [PATCH 2/8] s3c6410: sdhci: Adding additional data in sdhci platform data structure.Quoted 40 lines
Hi,
this breaks hsmmc1 (and hsmmc2).
Attached patch fixes hsmmc1.
Regards,
Maurus CuelenaereFrom
a743b9c3b7a6b63e2c0ccf22a45a06952920dff4Mon Sep 17 00:00:00 2001
From: Maurus Cuelenaere <[email protected]>
Date: Sat, 12 Sep 2009 17:40:33 +0200This patch adds additional information about the parent clock name, sdhci clock name and desired sdhci operating frequency for hsmmc1 (based on
e52782df345ec3e826701438ef42d2a8425bb973).Signed-off-by Maurus Cuelenaere <[email protected]>---
arch/arm/plat-s3c/dev-hsmmc1.c| 3 +++1 files changed, 3 insertions(+), 0 deletions(-)arch/arm/plat-s3c/dev-hsmmc1.c +3
-0@@ -41,6 +41,9 @@ struct s3c_sdhci_platdata s3c_hsmmc1_def_platdata = { .max_width = 4, .host_caps = (MMC_CAP_4_BIT_DATA | MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED), + .clk_parent_name = "dout_mpll", + .clk_source_name = "mmc_bus", + .clk_speed = 50*MHZ, };struct platform_device s3c_device_hsmmc1 = {Signature · 1 line
1.6.3.3_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.