Skip to contentSkip to conversation

I2C: add driver for SMBus Control Method Interface

PATCH Superseded Crane Cai 2 participants 4 messages Aug 27, 2009 – Sep 16, 2009 1 message not in the archive I2C subsystem host drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Crane Cai

author
#0 lore raw

PATCH 1/1 I2C: add driver for SMBus Control Method Interface

This driver supports the SMBus Control Method Interface. It needs BIOS declare ACPI control methods via SMBus Control Method Interface Spec.
http://smbus.org/specs/smbus_cmi10.pdf

Hi Jean,
This driver can give BIOS a chance to avoid SMBus access conflicts on runtime. And it obeys the SMBus CMI spec.
Please apply.

---
 drivers/i2c/busses/Kconfig   |   11 ++
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/cmi_i2c.c |  391 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 403 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/cmi_i2c.c
drivers/i2c/busses/Kconfig +11 -0
index 8206442..c4a5d6c 100644
@@ -761,4 +761,15 @@ config SCx200_ACB
 	  This support is also available as a module.  If so, the module
 	  will be called scx200_acb.
 
+config CMI_I2C
+	tristate "SMBus Control Method Interface"
+	depends on X86 && ACPI
+	help
+	  This driver supports the SMBus Control Method Interface. It needs
+	  BIOS declare ACPI control methods via SMBus Control Method Interface
+	  Spec.
+
+	  To compile this driver as a module, choose M here:
+	  the modules will be called cmi_i2c.
+
 endmenu
drivers/i2c/busses/Makefile +1 -0
index e654263..12806df 100644
@@ -71,6 +71,7 @@ obj-$(CONFIG_I2C_SIBYTE)	+= i2c-sibyte.o
 obj-$(CONFIG_I2C_STUB)		+= i2c-stub.o
 obj-$(CONFIG_SCx200_ACB)	+= scx200_acb.o
 obj-$(CONFIG_SCx200_I2C)	+= scx200_i2c.o
+obj-$(CONFIG_CMI_I2C)		+= cmi_i2c.o
 
 ifeq ($(CONFIG_I2C_DEBUG_BUS),y)
 EXTRA_CFLAGS += -DDEBUG
drivers/i2c/busses/cmi_i2c.c new file +391 -0

391 lines not on this page · raw message

Signature · 1 line
1.6.0.4
#1 lore raw

Hi Crane,

Quoted 8 lines · Crane Cai

This driver supports the SMBus Control Method Interface. It needs BIOS declare ACPI control methods via SMBus Control Method Interface Spec.
http://smbus.org/specs/smbus_cmi10.pdf

Hi Jean,
This driver can give BIOS a chance to avoid SMBus access conflicts on runtime. And it obeys the SMBus CMI spec.
Please apply.

This is very interesting. Do you happen to have, or know, systems which actually implement this? Were you able to test your code?

How can I check if any of my systems do implement this?

Full review below, inline. I had many comments but they are really small things, overall your code is very good and getting the driver in shape for 2.6.32 seems totally feasible.

Quoted 6 lines
---
 drivers/i2c/busses/Kconfig   |   11 ++
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/cmi_i2c.c |  391 ++++++++++++++++++++++++++++++++++++++++++

To comply with the naming scheme of all other drivers, the driver file should be named i2c-cmi.c.

drivers/i2c/busses/Kconfig config SCx200_ACB · line 764

Quoted 12 lines
 3 files changed, 403 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/cmi_i2c.c
drivers/i2c/busses/Kconfig +1 -0
index 8206442..c4a5d6c 100644
@@ -761,4 +761,15 @@ config SCx200_ACB
 	  This support is also available as a module.  If so, the module
 	  will be called scx200_acb.
 
+config CMI_I2C

I2C_CMI

drivers/i2c/busses/Kconfig config SCx200_ACB · line 766

Quoted 2 lines
drivers/i2c/busses/Kconfig +2 -0
+	tristate "SMBus Control Method Interface"
+	depends on X86 && ACPI

Why depend on X86? As far as I know, IA64 systems can support ACPI too. And this dependency is already handled by CONFIG_ACPI so drivers shouldn't have to care.

drivers/i2c/busses/Kconfig config SCx200_ACB · line 770

Quoted 4 lines
drivers/i2c/busses/Kconfig +4 -0
+	help
+	  This driver supports the SMBus Control Method Interface. It needs
+	  BIOS declare ACPI control methods via SMBus Control Method Interface
+	  Spec.

I suggest rewording the second sentence as follows: "It needs the BIOS to declare ACPI control methods as described in the SMBus Control Method Interface specification."

drivers/i2c/busses/Kconfig config SCx200_ACB · line 773

Quoted 3 lines
drivers/i2c/busses/Kconfig +3 -0
+
+	  To compile this driver as a module, choose M here:
+	  the modules will be called cmi_i2c.

module (no s)

drivers/i2c/busses/Makefile obj-$(CONFIG_I2C_SIBYTE) += i2c-sibyte.o · line 74

Quoted 11 lines
drivers/i2c/busses/Kconfig +1 -0
+
 endmenu
drivers/i2c/busses/Makefile +1 -0
index e654263..12806df 100644
@@ -71,6 +71,7 @@ obj-$(CONFIG_I2C_SIBYTE)	+= i2c-sibyte.o
 obj-$(CONFIG_I2C_STUB)		+= i2c-stub.o
 obj-$(CONFIG_SCx200_ACB)	+= scx200_acb.o
 obj-$(CONFIG_SCx200_I2C)	+= scx200_i2c.o
+obj-$(CONFIG_CMI_I2C)		+= cmi_i2c.o

The i2c-cmi driver should probably be listed first: if built into the kernel, it should be loaded before native drivers.

Quoted 10 lines
drivers/i2c/busses/Makefile +0 -0
 ifeq ($(CONFIG_I2C_DEBUG_BUS),y)
 EXTRA_CFLAGS += -DDEBUG
drivers/i2c/busses/cmi_i2c.c new file +1 -0
new file mode 100644
index 0000000..69f3202
@@ -0,0 +1,391 @@
+/*

drivers/i2c/busses/cmi_i2c.c line 11

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+ * SMBus driver for ACPI SMBus CMI
+ *
+ * Copyright (C) 2009 Crane Cai <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation version 2.
+ */
+
+#include <linux/version.h>

This header file should never be included by in-tree drivers.

drivers/i2c/busses/cmi_i2c.c line 19

Quoted 8 lines
drivers/i2c/busses/cmi_i2c.c new file +8 -0
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/kernel.h>
+#include <linux/stddef.h>
+#include <linux/init.h>
+#include <linux/i2c.h>
+#include <linux/acpi.h>
+#include <linux/delay.h>

Your driver doesn't seem to delay or sleep, so not needed.

drivers/i2c/busses/cmi_i2c.c line 24

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+
+#define ACPI_SMB_HC_COMPONENT	0x00080000
+#define ACPI_SMB_HC_CLASS	"smbus"
+#define ACPI_SMB_HC_DEVICE_NAME	"smbus cmi"
+#define SMB_HC_DEVICE_NAME	"SMBus CMI adapter"

This last define is not used anywhere.

drivers/i2c/busses/cmi_i2c.c line 26

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+
+#define _COMPONENT		ACPI_SMB_HC_COMPONENT

Nor this one.

drivers/i2c/busses/cmi_i2c.c line 33

Quoted 7 lines
drivers/i2c/busses/cmi_i2c.c new file +7 -0
+
+ACPI_MODULE_NAME("smbus_cmi");
+
+struct smbus_methods {
+	char *mt_info;
+	char *mt_sbr;
+	char *mt_sbw;

Shouldn't these be const char*?

drivers/i2c/busses/cmi_i2c.c line 42

Quoted 9 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+};
+
+struct acpi_smbus_cmi {
+	acpi_handle handle;
+	struct i2c_adapter adapter;
+	struct smbus_methods *methods;
+};
+
+static const struct smbus_methods smb_mtds = {

I suggest that you never use "smb" as an abbreviation for "SMBus":
"smb" stands for a number of different things in computer science, so it can easily get confusing. And "smbus" isn't much longer.

Likewise, "mtds" as an abbreviation for "methods" doesn't save much space and somewhat hurts readability IMHO.

drivers/i2c/busses/cmi_i2c.c line 46

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+	.mt_info = "_SBI",
+	.mt_sbr = "_SBR",
+	.mt_sbw = "_SBW",
+};

What's the point of having a per-device structure for this if all devices end up using the same hard-coded structure?

drivers/i2c/busses/cmi_i2c.c line 48

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+
+static const struct acpi_device_id i2c_device_ids[] = {

I would suggest a different name than i2c_device_ids, because it's almost similar to an existing type (i2c_device_id). What about "acpi_smbus_cmi_ids"?

drivers/i2c/busses/cmi_i2c.c line 50

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+	{"SMBUS01", 0},
+	{"", 0},

Trailing comma isn't needed, as you have a list terminator.

drivers/i2c/busses/cmi_i2c.c line 63

Quoted 13 lines
drivers/i2c/busses/cmi_i2c.c new file +13 -0
+};
+
+static int acpi_smb_cmi_add(struct acpi_device *device);
+static int acpi_smb_cmi_remove(struct acpi_device *device, int type);
+
+static struct acpi_driver acpi_smb_cmi_driver = {
+	.name = ACPI_SMB_HC_DEVICE_NAME,
+	.class = ACPI_SMB_HC_CLASS,
+	.ids = i2c_device_ids,
+	.ops = {
+		.add = acpi_smb_cmi_add,
+		.remove = acpi_smb_cmi_remove,
+		},

Bad indentation for the last curly brace (should be aligned with ".ops".

drivers/i2c/busses/cmi_i2c.c line 64

Quoted 1 line
drivers/i2c/busses/cmi_i2c.c new file +1 -0
+};

What about moving this driver definition later in the file, so that you no longer need to forward-declare the _add and _remove methods?

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+
+#define ACPI_SMB_STATUS_OK		0x00
+#define ACPI_SMB_STATUS_FAIL		0x07
+#define ACPI_SMB_STATUS_DNAK		0x10

drivers/i2c/busses/cmi_i2c.c line 78

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+#define ACPI_SMB_STATUS_DERR		0x11
+#define ACPI_SMB_STATUS_CMD_DENY	0x12
+#define ACPI_SMB_STATUS_UNKNOWN		0x13
+#define ACPI_SMB_STATUS_ACC_DENY	0x17
+#define ACPI_SMB_STATUS_TIMEOUT		0x18
+#define ACPI_SMB_STATUS_NOTSUP		0x19
+#define ACPI_SMB_STATUS_BUSY		0x1A
+#define ACPI_SMB_STATUS_PEC		0x1F
+
+#define ACPI_SMB_PRTCL_WRITE			0x0

0x00 for consistency.

drivers/i2c/busses/cmi_i2c.c line 86

Quoted 8 lines
drivers/i2c/busses/cmi_i2c.c new file +8 -0
+#define ACPI_SMB_PRTCL_READ			0x01
+#define ACPI_SMB_PRTCL_QUICK			0x02
+#define ACPI_SMB_PRTCL_BYTE			0x04
+#define ACPI_SMB_PRTCL_BYTE_DATA		0x06
+#define ACPI_SMB_PRTCL_WORD_DATA		0x08
+#define ACPI_SMB_PRTCL_BLOCK_DATA		0x0a
+#define ACPI_SMB_PRTCL_PROC_CALL		0x0c
+#define ACPI_SMB_PRTCL_BLOCK_PROC_CALL		0x0d

Can't see this one in the CMI specification, and your driver doesn't use it anyway.

drivers/i2c/busses/cmi_i2c.c line 87

Quoted 1 line
drivers/i2c/busses/cmi_i2c.c new file +1 -0
+#define ACPI_SMB_PRTCL_PEC			0x80

It would also look better if the two blocks above had the same indentation, and if you stuck to capitals or not capitals for hexadecimal numbers.

Quoted 112 lines
drivers/i2c/busses/cmi_i2c.c new file +112 -0
+
+
+static int
+acpi_smb_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
+		   char read_write, u8 command, int size,
+		   union i2c_smbus_data *data)
+{
+	int result = 0;
+	struct acpi_smbus_cmi *smbus_cmi = adap->algo_data;
+	unsigned char protocol, len = 0;
+	acpi_status status = 0;
+	struct acpi_object_list input;
+	union acpi_object mt_params[5];
+	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+	union acpi_object *obj;
+	union acpi_object *pkg;
+	char *mthd;
+
+	switch (size) {
+	case I2C_SMBUS_QUICK:
+		protocol = ACPI_SMB_PRTCL_QUICK;
+		command = 0;
+		if (read_write == I2C_SMBUS_WRITE) {
+			mt_params[3].type = ACPI_TYPE_INTEGER;
+			mt_params[3].integer.value = 0;
+			mt_params[4].type = ACPI_TYPE_INTEGER;
+			mt_params[4].integer.value = 0;
+		}
+		break;
+
+	case I2C_SMBUS_BYTE:
+		protocol = ACPI_SMB_PRTCL_BYTE;
+		if (read_write == I2C_SMBUS_WRITE) {
+			mt_params[3].type = ACPI_TYPE_INTEGER;
+			mt_params[3].integer.value = 0;
+			mt_params[4].type = ACPI_TYPE_INTEGER;
+			mt_params[4].integer.value = 0;
+		} else {
+			command = 0;
+		}
+		break;
+
+	case I2C_SMBUS_BYTE_DATA:
+		protocol = ACPI_SMB_PRTCL_BYTE_DATA;
+		if (read_write == I2C_SMBUS_WRITE) {
+			mt_params[3].type = ACPI_TYPE_INTEGER;
+			mt_params[3].integer.value = 1;
+			mt_params[4].type = ACPI_TYPE_INTEGER;
+			mt_params[4].integer.value = data->byte;
+		}
+		break;
+
+	case I2C_SMBUS_WORD_DATA:
+		protocol = ACPI_SMB_PRTCL_WORD_DATA;
+		if (read_write == I2C_SMBUS_WRITE) {
+			mt_params[3].type = ACPI_TYPE_INTEGER;
+			mt_params[3].integer.value = 2;
+			mt_params[4].type = ACPI_TYPE_INTEGER;
+			mt_params[4].integer.value = data->word;
+		}
+		break;
+
+	case I2C_SMBUS_BLOCK_DATA:
+		protocol = ACPI_SMB_PRTCL_BLOCK_DATA;
+		if (read_write == I2C_SMBUS_WRITE) {
+			len = data->block[0];
+			if (len == 0 || len > I2C_SMBUS_BLOCK_MAX)
+				return -EINVAL;
+			mt_params[3].type = ACPI_TYPE_INTEGER;
+			mt_params[3].integer.value = len;
+			mt_params[4].type = ACPI_TYPE_BUFFER;
+			mt_params[4].buffer.pointer = data->block + 1;
+		}
+		break;
+
+	default:
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI adapter: "
+				  "Unsupported transaction %d\n", size));
+		return -EOPNOTSUPP;
+	}
+
+	if (read_write == I2C_SMBUS_READ) {
+		protocol |= ACPI_SMB_PRTCL_READ;
+		mthd = smbus_cmi->methods->mt_sbr;
+		input.count = 3;
+	} else {
+		protocol |= ACPI_SMB_PRTCL_WRITE;
+		mthd = smbus_cmi->methods->mt_sbw;
+		input.count = 5;
+	}
+
+	input.pointer = mt_params;
+	mt_params[0].type = ACPI_TYPE_INTEGER;
+	mt_params[0].integer.value = protocol;
+	mt_params[1].type = ACPI_TYPE_INTEGER;
+	mt_params[1].integer.value = addr;
+	mt_params[2].type = ACPI_TYPE_INTEGER;
+	mt_params[2].integer.value = command;
+
+	status = acpi_evaluate_object(smbus_cmi->handle, mthd, &input, &buffer);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Error evaluate %s\n", mthd));
+		return -EIO;
+	}
+
+	pkg = buffer.pointer;
+	if (pkg && pkg->type == ACPI_TYPE_PACKAGE)
+		obj = pkg->package.elements;
+	else {
+		result = -EIO;
+		goto out;
+	}

drivers/i2c/busses/cmi_i2c.c line 209

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+	if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus status object type \
+						error\n"));
+		result = -EIO;
+		goto out;
+	}
+
+	result = obj->integer.value;
+	switch (result) {
+	case ACPI_SMB_STATUS_OK:

This assumes that ACPI_SMB_STATUS_OK == 0, which is true but is only a coincidence.

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+		break;
+	case ACPI_SMB_STATUS_BUSY:
+		result = -EBUSY;
+		goto out;

drivers/i2c/busses/cmi_i2c.c line 223

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+	case ACPI_SMB_STATUS_TIMEOUT:
+		result = -ETIMEDOUT;
+		goto out;
+	case ACPI_SMB_STATUS_DNAK:
+		result = -ENXIO;
+		goto out;
+	default:
+		result = -EIO;
+		goto out;
+	}

You might want to log error messages for unknown errors, and maybe debug messages for known errors too.

drivers/i2c/busses/cmi_i2c.c line 225

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+
+	if (read_write == I2C_SMBUS_WRITE)

I think you also want to quit here on size == SMBUS_QUICK. What the CMI specification names "quick read" is really a write from a functional perspective.

drivers/i2c/busses/cmi_i2c.c line 231

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+		goto out;
+
+	obj = pkg->package.elements + 1;
+	if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package object \
+						type error\n"));

Not the right way to split a string.

drivers/i2c/busses/cmi_i2c.c line 244

Quoted 13 lines
drivers/i2c/busses/cmi_i2c.c new file +13 -0
+		result = -EIO;
+		goto out;
+	}
+
+	len = obj->integer.value;
+	obj = pkg->package.elements + 2;
+	switch (size) {
+	case I2C_SMBUS_BYTE:
+	case I2C_SMBUS_BYTE_DATA:
+	case I2C_SMBUS_WORD_DATA:
+		if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
+			ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package \
+						object type error\n"));

Same here.

drivers/i2c/busses/cmi_i2c.c line 251

Quoted 7 lines
drivers/i2c/busses/cmi_i2c.c new file +7 -0
+			result = -EIO;
+			goto out;
+		}
+		if (len == 2)
+			data->word = obj->integer.value & 0xffff;
+		else
+			data->byte = obj->integer.value & 0xff;

Masking is a no-op.

drivers/i2c/busses/cmi_i2c.c line 256

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+		break;
+	case I2C_SMBUS_BLOCK_DATA:
+		if (obj == NULL || obj->type != ACPI_TYPE_BUFFER) {
+			ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package \
+						object type error\n"));

Not the right way to split a string.

drivers/i2c/busses/cmi_i2c.c line 262

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+			result = -EIO;
+			goto out;
+		}
+		data->block[0] = len;
+		if (data->block[0] == 0 || data->block[0] > I2C_SMBUS_BLOCK_MAX)
+			return -EPROTO;

You should check the value of len before copying it to data->block[0]. data->block[0] is a u8 so you might get wrapping issues.

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+		memcpy(data->block + 1, obj->buffer.pointer, len);
+		break;
+	}
+
+out:
+	kfree(buffer.pointer);

drivers/i2c/busses/cmi_i2c.c line 278

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+	return result;
+}
+
+static u32 acpi_smb_cmi_func(struct i2c_adapter *adapter)
+{
+
+	return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
+		I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
+		I2C_FUNC_SMBUS_BLOCK_DATA;
+}

It doesn't look correct to hard-code this. As I read the CMI specification, each SMBus segment exposed may or may not support each type of SMBus transaction. Unfortunately there doesn't seem to be any way to know the exact subset of transactions that are supported. But at least you could use the presence or absence of methods _SBR and _SBW to determine whether reading, writing or both are supported.

I hope this limitation won't cause too much trouble... some drivers really test for adapter functionality, and use different methods depending on the result.

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+
+static const struct i2c_algorithm acpi_smbus_cmi_algorithm = {
+	.smbus_xfer = acpi_smb_cmi_access,
+	.functionality = acpi_smb_cmi_func,
+};

drivers/i2c/busses/cmi_i2c.c line 293

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+
+static int acpi_smb_cmi_add(struct acpi_device *device)
+{
+	int status;
+	struct acpi_smbus_cmi *smb_cmi;
+	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+	union acpi_object *obj;
+
+	if (!device)
+		return -EINVAL;

How could this ever happen?

Quoted 20 lines
drivers/i2c/busses/cmi_i2c.c new file +20 -0
+
+	smb_cmi = kzalloc(sizeof(struct acpi_smbus_cmi), GFP_KERNEL);
+	if (!smb_cmi)
+		return -ENOMEM;
+
+	smb_cmi->handle = device->handle;
+	strcpy(acpi_device_name(device), ACPI_SMB_HC_DEVICE_NAME);
+	strcpy(acpi_device_class(device), ACPI_SMB_HC_CLASS);
+	device->driver_data = smb_cmi;
+	smb_cmi->methods = (struct smbus_methods *)(&smb_mtds);
+
+	status = acpi_evaluate_object(smb_cmi->handle,
+					smb_cmi->methods->mt_info,
+					NULL, &buffer);
+	if (ACPI_FAILURE(status)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Error obtaining _SBI\n"));
+		goto err;
+	}
+
+	obj = buffer.pointer;

drivers/i2c/busses/cmi_i2c.c line 323

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+	if (obj && obj->type == ACPI_TYPE_PACKAGE)
+		obj = obj->package.elements;
+	else {
+		kfree(buffer.pointer);
+		goto err;
+	}
+
+	if (obj->type != ACPI_TYPE_INTEGER) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version object type \
+								error\n"));

This isn't how strings are split in C. Instead, do:

		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version object type "
								"error\n"));

drivers/i2c/busses/cmi_i2c.c line 325

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+	} else
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version %0x\n",

How does %0x differ from %x? This might be displayed nicer anyway, as we know this byte is encoded in BCD.

drivers/i2c/busses/cmi_i2c.c line 327

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+					(int)obj->integer.value));
+	kfree(buffer.pointer);

Maybe list some more information from the SMB_INFO object, in particular the version of SMBus that is supported, and the number of devices on the bus? Icing on the cake would be the complete list of devices, but this can be added later.

drivers/i2c/busses/cmi_i2c.c line 330

Quoted 3 lines
drivers/i2c/busses/cmi_i2c.c new file +3 -0
+
+	snprintf(smb_cmi->adapter.name, sizeof(smb_cmi->adapter.name),
+		"SMBus CMI adapter");

Isn't it possible for a given systems to have more than one SMBus adapter of this type? The CMI specification suggests so. The i2c_adapter name is supposed to be unique within a given system. We usually add the device address or any other unique identifier at the end of the name. As I read the CMI specification, we should be able to use _UID for this purpose?

drivers/i2c/busses/cmi_i2c.c line 341

Quoted 11 lines
drivers/i2c/busses/cmi_i2c.c new file +11 -0
+	smb_cmi->adapter.owner = THIS_MODULE;
+	smb_cmi->adapter.algo = &acpi_smbus_cmi_algorithm;
+	smb_cmi->adapter.algo_data = smb_cmi;
+	smb_cmi->adapter.class	= I2C_CLASS_HWMON | I2C_CLASS_SPD;
+	smb_cmi->adapter.dev.parent = &device->dev;
+
+	if (i2c_add_adapter(&smb_cmi->adapter)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN,
+			  "SMBus CMI adapter: Failed to register adapter\n"));
+		kfree(smb_cmi);
+		return -EIO;

Why not just "goto err"?

drivers/i2c/busses/cmi_i2c.c line 345

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+	}
+
+	printk(KERN_INFO PREFIX "%s [%s]\n",
+	       acpi_device_name(device), acpi_device_bid(device));

That's a little rough IMHO.

drivers/i2c/busses/cmi_i2c.c line 347

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+
+	return AE_OK;

I am surprised that you mix regular error codes with ACPI-specific ones.

drivers/i2c/busses/cmi_i2c.c line 360

Quoted 13 lines
drivers/i2c/busses/cmi_i2c.c new file +13 -0
+
+err:
+	kfree(smb_cmi);
+	device->driver_data = NULL;
+	return -EIO;
+}
+
+static int acpi_smb_cmi_remove(struct acpi_device *device, int type)
+{
+	struct acpi_smbus_cmi *smbus_cmi;
+
+	if (!device)
+		return -EINVAL;

I fail to see how this would be possible.

drivers/i2c/busses/cmi_i2c.c line 365

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+
+	smbus_cmi = acpi_driver_data(device);
+
+	i2c_del_adapter(&smbus_cmi->adapter);
+	kfree(smbus_cmi);

Care to reset driver data to NULL?

drivers/i2c/busses/cmi_i2c.c line 367

Quoted 2 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+
+	return AE_OK;

Here again, I am surprised by the mix of regular error codes and ACPI ones.

drivers/i2c/busses/cmi_i2c.c line 376

Quoted 9 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+}
+
+static int __init acpi_smb_cmi_init(void)
+{
+	int result;
+
+	result = acpi_bus_register_driver(&acpi_smb_cmi_driver);
+	if (result < 0)
+		return -ENODEV;

Why don't you simply return the error code? Would be simpler and more informative too.

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+
+	return 0;
+}
+

drivers/i2c/busses/cmi_i2c.c line 390

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+static void __exit acpi_smb_cmi_exit(void)
+{
+	acpi_bus_unregister_driver(&acpi_smb_cmi_driver);
+}
+
+module_init(acpi_smb_cmi_init);
+module_exit(acpi_smb_cmi_exit);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Crane Cai");

No e-mail address?

drivers/i2c/busses/cmi_i2c.c line 391

Quoted 1 line
drivers/i2c/busses/cmi_i2c.c new file +1 -0
+MODULE_DESCRIPTION("ACPI SMBus CMI driver");

And lastly a general comment: is it OK that you always use ACPI_DEBUG_PRINT((ACPI_DB_WARN for all kernel messages, be they errors, warning or informational?

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#3 lore raw

Hi Jean,

Quoted 7 lines · Jean Delvare

Hi Crane,

Quoted 4 lines · Crane Cai

This driver supports the SMBus Control Method Interface. It needs BIOS declare ACPI control methods via SMBus Control Method Interface Spec.
http://smbus.org/specs/smbus_cmi10.pdf

Quoted 7 lines
Quoted 4 lines

Hi Jean,
This driver can give BIOS a chance to avoid SMBus access conflicts on runtime. And it obeys the SMBus CMI spec.
Please apply.

This is very interesting. Do you happen to have, or know, systems which actually implement this? Were you able to test your code?

Till now I only know our internal BIOS implement this control method. The code has been tested.

Quoted 2 lines

How can I check if any of my systems do implement this?

Now BIOS team give us an option to let these control methods exported.

Quoted 4 lines

Full review below, inline. I had many comments but they are really small things, overall your code is very good and getting the driver in shape for 2.6.32 seems totally feasible.

Thanks, these comments are very important to me. I will rework my code on them and retest and resubmit a new version. It needs some days.

Quoted 1 line
Signature · 2 lines
Best Regards,
- Crane
author Applied
#4 lore raw
In reply to a message not in the archive

Hi Jean,

I revised the driver and resubmit a new new for you. I listed the changes below so that it can make your review a little easy. One thing I missed:

Quoted 3 lines

It would also look better if the two blocks above had the same indentation, and if you stuck to capitals or not capitals for hexadecimal numbers.

applied, removed it, sorry I missed the capital issue.

Quoted 3 lines · Jean Delvare
Quoted 1 line

+config CMI_I2C

I2C_CMI

applied

Quoted 7 lines

drivers/i2c/busses/Kconfig config SCx200_ACB · line 766

Quoted 3 lines
drivers/i2c/busses/Kconfig +2 -0
+	tristate "SMBus Control Method Interface"
+	depends on X86 && ACPI

Why depend on X86? As far as I know, IA64 systems can support ACPI too. And this dependency is already handled by CONFIG_ACPI so drivers shouldn't have to care.

applied

Quoted 9 lines

drivers/i2c/busses/Kconfig config SCx200_ACB · line 770

Quoted 5 lines
drivers/i2c/busses/Kconfig +4 -0
+	help
+	  This driver supports the SMBus Control Method Interface. It needs
+	  BIOS declare ACPI control methods via SMBus Control Method Interface
+	  Spec.

I suggest rewording the second sentence as follows: "It needs the BIOS to declare ACPI control methods as described in the SMBus Control Method Interface specification."

applied

Quoted 6 lines

drivers/i2c/busses/Kconfig config SCx200_ACB · line 773

Quoted 4 lines
drivers/i2c/busses/Kconfig +3 -0
+
+	  To compile this driver as a module, choose M here:
+	  the modules will be called cmi_i2c.

module (no s)

applied

Quoted 7 lines
Quoted 4 lines

obj-$(CONFIG_SCx200_ACB) += scx200_acb.o
obj-$(CONFIG_SCx200_I2C) += scx200_i2c.o
+obj-$(CONFIG_CMI_I2C) += cmi_i2c.o

The i2c-cmi driver should probably be listed first: if built into the kernel, it should be loaded before native drivers.

applied

Quoted 4 lines
Quoted 2 lines

+#include <linux/version.h>

This header file should never be included by in-tree drivers.

applied

Quoted 4 lines
Quoted 2 lines

+#include <linux/delay.h>

Your driver doesn't seem to delay or sleep, so not needed.

applied

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 24

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+
+#define ACPI_SMB_HC_COMPONENT	0x00080000
+#define ACPI_SMB_HC_CLASS	"smbus"
+#define ACPI_SMB_HC_DEVICE_NAME	"smbus cmi"
+#define SMB_HC_DEVICE_NAME	"SMBus CMI adapter"

This last define is not used anywhere.

applied

Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+#define _COMPONENT		ACPI_SMB_HC_COMPONENT

Nor this one.

applied

Quoted 10 lines

drivers/i2c/busses/cmi_i2c.c line 33

Quoted 8 lines
drivers/i2c/busses/cmi_i2c.c new file +7 -0
+
+ACPI_MODULE_NAME("smbus_cmi");
+
+struct smbus_methods {
+	char *mt_info;
+	char *mt_sbr;
+	char *mt_sbw;

Shouldn't these be const char*?

applied

Quoted 15 lines

drivers/i2c/busses/cmi_i2c.c line 42

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+};
+
+struct acpi_smbus_cmi {
+	acpi_handle handle;
+	struct i2c_adapter adapter;
+	struct smbus_methods *methods;
+};
+
+static const struct smbus_methods smb_mtds = {

I suggest that you never use "smb" as an abbreviation for "SMBus":
"smb" stands for a number of different things in computer science, so it can easily get confusing. And "smbus" isn't much longer.

Quoted 2 lines

Likewise, "mtds" as an abbreviation for "methods" doesn't save much space and somewhat hurts readability IMHO.

applied, smb -> smbus, mtds-> methods

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 46

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+	.mt_info = "_SBI",
+	.mt_sbr = "_SBR",
+	.mt_sbw = "_SBW",
+};

What's the point of having a per-device structure for this if all devices end up using the same hard-coded structure?

applied, remove it from per-device structure

Quoted 7 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+static const struct acpi_device_id i2c_device_ids[] = {

I would suggest a different name than i2c_device_ids, because it's almost similar to an existing type (i2c_device_id). What about "acpi_smbus_cmi_ids"?

applied

Quoted 5 lines

drivers/i2c/busses/cmi_i2c.c line 50

Quoted 3 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+	{"SMBUS01", 0},
+	{"", 0},

Trailing comma isn't needed, as you have a list terminator.

applied

Quoted 11 lines

drivers/i2c/busses/cmi_i2c.c line 63

Quoted 9 lines
drivers/i2c/busses/cmi_i2c.c new file +8 -0
+static struct acpi_driver acpi_smb_cmi_driver = {
+	.name = ACPI_SMB_HC_DEVICE_NAME,
+	.class = ACPI_SMB_HC_CLASS,
+	.ids = i2c_device_ids,
+	.ops = {
+		.add = acpi_smb_cmi_add,
+		.remove = acpi_smb_cmi_remove,
+		},

Bad indentation for the last curly brace (should be aligned with ".ops".

applied

Quoted 5 lines
Quoted 2 lines

+};

What about moving this driver definition later in the file, so that you no longer need to forward-declare the _add and _remove methods?

applied

Quoted 7 lines

drivers/i2c/busses/cmi_i2c.c line 78

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+
+#define ACPI_SMB_STATUS_PEC		0x1F
+
+#define ACPI_SMB_PRTCL_WRITE			0x0

0x00 for consistency.

applied

Quoted 12 lines

drivers/i2c/busses/cmi_i2c.c line 86

Quoted 9 lines
drivers/i2c/busses/cmi_i2c.c new file +8 -0
+#define ACPI_SMB_PRTCL_READ			0x01
+#define ACPI_SMB_PRTCL_QUICK			0x02
+#define ACPI_SMB_PRTCL_BYTE			0x04
+#define ACPI_SMB_PRTCL_BYTE_DATA		0x06
+#define ACPI_SMB_PRTCL_WORD_DATA		0x08
+#define ACPI_SMB_PRTCL_BLOCK_DATA		0x0a
+#define ACPI_SMB_PRTCL_PROC_CALL		0x0c
+#define ACPI_SMB_PRTCL_BLOCK_PROC_CALL		0x0d

Can't see this one in the CMI specification, and your driver doesn't use it anyway.

applied, removed it

Quoted 6 lines
Quoted 2 lines

+#define ACPI_SMB_PRTCL_PEC 0x80

It would also look better if the two blocks above had the same indentation, and if you stuck to capitals or not capitals for hexadecimal numbers.

applied, removed it, sorry I missed the capital issue.

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 209

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+
+	result = obj->integer.value;
+	switch (result) {
+	case ACPI_SMB_STATUS_OK:

This assumes that ACPI_SMB_STATUS_OK == 0, which is true but is only a coincidence.

applied, add debug message

Quoted 10 lines
Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+		break;
+	case ACPI_SMB_STATUS_BUSY:
+		result = -EBUSY;
+		goto out;
+	case ACPI_SMB_STATUS_TIMEOUT:
+		result = -ETIMEDOUT;
+		goto out;
+	case ACPI_SMB_STATUS_DNAK:
+		result = -ENXIO;
Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 223

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+		goto out;
+	default:
+		result = -EIO;
+		goto out;
+	}

You might want to log error messages for unknown errors, and maybe debug messages for known errors too.

applied, add dev_dbg for debug usage

Quoted 7 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+	if (read_write == I2C_SMBUS_WRITE)

I think you also want to quit here on size == SMBUS_QUICK. What the CMI specification names "quick read" is really a write from a functional perspective.

applied

Quoted 9 lines

drivers/i2c/busses/cmi_i2c.c line 231

Quoted 7 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+		goto out;
+
+	obj = pkg->package.elements + 1;
+	if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package object \
+						type error\n"));

Not the right way to split a string.

applied

Quoted 16 lines
Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +3 -0
+		result = -EIO;
+		goto out;
+	}

drivers/i2c/busses/cmi_i2c.c line 244

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+
+	len = obj->integer.value;
+	obj = pkg->package.elements + 2;
+	switch (size) {
+	case I2C_SMBUS_BYTE:
+	case I2C_SMBUS_BYTE_DATA:
+	case I2C_SMBUS_WORD_DATA:
+		if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
+			ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package \
+						object type error\n"));

Same here.

applied

Quoted 10 lines

drivers/i2c/busses/cmi_i2c.c line 251

Quoted 8 lines
drivers/i2c/busses/cmi_i2c.c new file +7 -0
+			result = -EIO;
+			goto out;
+		}
+		if (len == 2)
+			data->word = obj->integer.value & 0xffff;
+		else
+			data->byte = obj->integer.value & 0xff;

Masking is a no-op.

applied, removed them

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 256

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+		break;
+	case I2C_SMBUS_BLOCK_DATA:
+		if (obj == NULL || obj->type != ACPI_TYPE_BUFFER) {
+			ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus return package \
+						object type error\n"));

Not the right way to split a string.

applied

Quoted 10 lines

drivers/i2c/busses/cmi_i2c.c line 262

Quoted 7 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+			result = -EIO;
+			goto out;
+		}
+		data->block[0] = len;
+		if (data->block[0] == 0 || data->block[0] > I2C_SMBUS_BLOCK_MAX)
+			return -EPROTO;

You should check the value of len before copying it to data->block[0]. data->block[0] is a u8 so you might get wrapping issues.

applied

Quoted 25 lines
Quoted 7 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+		memcpy(data->block + 1, obj->buffer.pointer, len);
+		break;
+	}
+
+out:
+	kfree(buffer.pointer);

drivers/i2c/busses/cmi_i2c.c line 278

Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +10 -0
+	return result;
+}
+
+static u32 acpi_smb_cmi_func(struct i2c_adapter *adapter)
+{
+
+	return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
+		I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
+		I2C_FUNC_SMBUS_BLOCK_DATA;
+}

It doesn't look correct to hard-code this. As I read the CMI specification, each SMBus segment exposed may or may not support each type of SMBus transaction. Unfortunately there doesn't seem to be any way to know the exact subset of transactions that are supported. But at least you could use the presence or absence of methods _SBR and _SBW to determine whether reading, writing or both are supported.

Quoted 3 lines

I hope this limitation won't cause too much trouble... some drivers really test for adapter functionality, and use different methods depending on the result.

applied, scan methods to determined its capability.

Quoted 10 lines
Quoted 10 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+
+static const struct i2c_algorithm acpi_smbus_cmi_algorithm = {
+	.smbus_xfer = acpi_smb_cmi_access,
+	.functionality = acpi_smb_cmi_func,
+};
+
+static int acpi_smb_cmi_add(struct acpi_device *device)
+{
+	int status;
Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 293

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +6 -0
+	struct acpi_smbus_cmi *smb_cmi;
+	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+	union acpi_object *obj;
+
+	if (!device)
+		return -EINVAL;

How could this ever happen?

applied, removed it

Quoted 9 lines

drivers/i2c/busses/cmi_i2c.c line 323

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +3 -0
+	if (obj->type != ACPI_TYPE_INTEGER) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version object type \
+								error\n"));

This isn't how strings are split in C. Instead, do:

		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version object type "
								"error\n"));

applied

Quoted 6 lines

drivers/i2c/busses/cmi_i2c.c line 325

Quoted 3 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+	} else
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "SMBus CMI Version %0x\n",

How does %0x differ from %x? This might be displayed nicer anyway, as we know this byte is encoded in BCD.

applied

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 327

Quoted 3 lines
drivers/i2c/busses/cmi_i2c.c new file +2 -0
+					(int)obj->integer.value));
+	kfree(buffer.pointer);

Maybe list some more information from the SMB_INFO object, in particular the version of SMBus that is supported, and the number of devices on the bus? Icing on the cake would be the complete list of devices, but this can be added later.

applied, printed SMB_INFO out in debug message.

Quoted 11 lines

drivers/i2c/busses/cmi_i2c.c line 330

Quoted 4 lines
drivers/i2c/busses/cmi_i2c.c new file +3 -0
+
+	snprintf(smb_cmi->adapter.name, sizeof(smb_cmi->adapter.name),
+		"SMBus CMI adapter");

Isn't it possible for a given systems to have more than one SMBus adapter of this type? The CMI specification suggests so. The i2c_adapter name is supposed to be unique within a given system. We usually add the device address or any other unique identifier at the end of the name. As I read the CMI specification, we should be able to use _UID for this purpose?

applied

Quoted 14 lines

drivers/i2c/busses/cmi_i2c.c line 341

Quoted 12 lines
drivers/i2c/busses/cmi_i2c.c new file +11 -0
+	smb_cmi->adapter.owner = THIS_MODULE;
+	smb_cmi->adapter.algo = &acpi_smbus_cmi_algorithm;
+	smb_cmi->adapter.algo_data = smb_cmi;
+	smb_cmi->adapter.class	= I2C_CLASS_HWMON | I2C_CLASS_SPD;
+	smb_cmi->adapter.dev.parent = &device->dev;
+
+	if (i2c_add_adapter(&smb_cmi->adapter)) {
+		ACPI_DEBUG_PRINT((ACPI_DB_WARN,
+			  "SMBus CMI adapter: Failed to register adapter\n"));
+		kfree(smb_cmi);
+		return -EIO;

Why not just "goto err"?

applied

Quoted 7 lines

drivers/i2c/busses/cmi_i2c.c line 345

Quoted 5 lines
drivers/i2c/busses/cmi_i2c.c new file +4 -0
+	}
+
+	printk(KERN_INFO PREFIX "%s [%s]\n",
+	       acpi_device_name(device), acpi_device_bid(device));

That's a little rough IMHO.

applied, removed

Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+	return AE_OK;

I am surprised that you mix regular error codes with ACPI-specific ones.

applied

Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+	if (!device)
+		return -EINVAL;

I fail to see how this would be possible.

applied

Quoted 8 lines

drivers/i2c/busses/cmi_i2c.c line 365

Quoted 6 lines
drivers/i2c/busses/cmi_i2c.c new file +5 -0
+
+	smbus_cmi = acpi_driver_data(device);
+
+	i2c_del_adapter(&smbus_cmi->adapter);
+	kfree(smbus_cmi);

Care to reset driver data to NULL?

applied

Quoted 7 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+
+	return AE_OK;

Here again, I am surprised by the mix of regular error codes and ACPI ones.

Quoted 12 lines

drivers/i2c/busses/cmi_i2c.c line 376

Quoted 9 lines
drivers/i2c/busses/cmi_i2c.c new file +9 -0
+}
+
+static int __init acpi_smb_cmi_init(void)
+{
+	int result;
+
+	result = acpi_bus_register_driver(&acpi_smb_cmi_driver);
+	if (result < 0)
+		return -ENODEV;

Why don't you simply return the error code? Would be simpler and more informative too.

applied

Quoted 4 lines
Quoted 2 lines

+MODULE_AUTHOR("Crane Cai");

No e-mail address?

applied

Quoted 4 lines

And lastly a general comment: is it OK that you always use ACPI_DEBUG_PRINT((ACPI_DB_WARN for all kernel messages, be they errors, warning or informational?

applied, ACPI_DEBUG_PRINT -> ACPI_ERROR etc.

Quoted 3 lines
Signature · 2 lines
-- 
Jean Delvare
Signature · 2 lines
Best Regards,
- Crane