Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP
PATCH 1/1 Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP
commit 85bac32c4a52c592b857f2c360cc5ec93a097d70
ring-buffer: only enable ring_buffer_swap_cpu when needed
broke oprofile (at least on s390, but likely on all platforms).
this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make ring_buffer_swap_cpu usable for oprofile.
CC-ed: Steven Rostedt <[email protected]>
CC-ed: Ingo Molnar <[email protected]>
CC-ed: Robert Richter <[email protected]>
--- arch/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/Kconfig +1 -0
@@ -9,6 +9,7 @@ config OPROFILE depends on TRACING_SUPPORT select TRACING select RING_BUFFER + select RING_BUFFER_ALLOW_SWAP help OProfile is a profiling system capable of profiling the whole system, include the kernel, kernel modules, libraries,
Quoted 6 lines · Christian Borntraeger
commit
85bac32c4a52c592b857f2c360cc5ec93a097d70
ring-buffer: only enablering_buffer_swap_cpuwhen needed
broke oprofile (at least on s390, but likely on all platforms).this patch lets oprofile select
RING_BUFER_ALLOW_SWAPto makering_buffer_swap_cpuusable for oprofile.
Thanks, I'll apply this for the 32 queue.
-- Steve
PS. Please send patches to my [email protected] account. I don't always read my Red Hat email.
Quoted 21 lines
Signed-off-by Christian Borntraeger <[email protected]>CC-ed: Steven Rostedt <[email protected]>
CC-ed: Ingo Molnar <[email protected]>
CC-ed: Robert Richter <[email protected]>--- arch/Kconfig | 1 + 1 file changed, 1 insertion(+)Index: linux-2.6/arch/Kconfig
===================================================================arch/Kconfig +1
-0@@ -9,6 +9,7 @@ config OPROFILE depends on TRACING_SUPPORT select TRACING select RING_BUFFER + select RING_BUFFER_ALLOW_SWAP help OProfile is a profiling system capable of profiling the whole system, include the kernel, kernel modules, libraries,
Quoted 9 lines · Steven Rostedt
Quoted 6 lines · Christian Borntraeger
commit
85bac32c4a52c592b857f2c360cc5ec93a097d70
ring-buffer: only enablering_buffer_swap_cpuwhen needed
broke oprofile (at least on s390, but likely on all platforms).this patch lets oprofile select
RING_BUFER_ALLOW_SWAPto makering_buffer_swap_cpuusable for oprofile.Thanks, I'll apply this for the 32 queue.
Thanks Christian,
I was just debugging it for x86 too and narrowed it to the tracing-core merge already.
-Robert
Signature · 3 lines
Advanced Micro Devices, Inc. Operating System Research Center email: [email protected]
[tip:tracing/core] oprofile: fix oprofile regression: select RING_BUFFER_ALLOW_SWAP
In reply to Christian BorntraegerCommit-ID: 9a5963eb494c8a7be65199e15854551df7d2d939 Gitweb: http://git.kernel.org/tip/9a5963eb494c8a7be65199e15854551df7d2d939 Author: Christian Borntraeger <[email protected]> AuthorDate: Wed, 16 Sep 2009 21:56:49 +0200 Committer: Steven Rostedt <[email protected]> CommitDate: Thu, 17 Sep 2009 15:53:42 -0400
oprofile: fix oprofile regression: select RING_BUFFER_ALLOW_SWAP
commit 85bac32c4a52c592b857f2c360cc5ec93a097d70
ring-buffer: only enable ring_buffer_swap_cpu when needed
broke oprofile (at least on s390, but likely on all platforms).
this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make ring_buffer_swap_cpu usable for oprofile.
LKML-Reference: <[email protected]>
--- arch/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/Kconfig +1 -0
@@ -9,6 +9,7 @@ config OPROFILE depends on TRACING_SUPPORT select TRACING select RING_BUFFER + select RING_BUFFER_ALLOW_SWAP help OProfile is a profiling system capable of profiling the whole system, include the kernel, kernel modules, libraries,