Skip to contentSkip to conversation

armv5te mentioned twice on eabi-capable list

PATCH In review Aleksandr Koltsoff 4 participants 4 messages Sep 16, 2009 – Sep 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 armv5te mentioned twice on eabi-capable list

(My first patch generated with git, please be gentle :-).

armv5te is mentioned twice in the arm_eabi_supporting_arches list of sane-toolchain.inc. Remove the latter occurance.

ak.

From 0776995c4668d744ff96397639ac646fc4b5133c Mon Sep 17 00:00:00 2001
From: Aleksandr Koltsoff <[email protected]>
Date: Wed, 16 Sep 2009 13:12:05 +0300
Subject: [PATCH] fix armv5te mentioned twice in the eabi-capable list

---
 conf/distro/include/sane-toolchain.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
conf/distro/include/sane-toolchain.inc +1 -1
index e2c6740..d0bb8bc 100644
@@ -157,7 +157,7 @@ def detect_arm_abi (d):
 def compute_os_portion_of_target_triplet (d):
 	import bb
 	arm_eabi_supporting_arches = "armv6 armv6-novfp \
-	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv5te armv4t"
+	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv4t"
 	ppc_spe_supporting_arches = "ppce500v2 ppce500"
 
   	if bb.data.getVar("LIBC", d, 1) == "uclibc":
Signature · 1 line
1.6.4
#1 lore raw
Quoted 4 lines · Aleksandr Koltsoff

(My first patch generated with git, please be gentle :-).

armv5te is mentioned twice in the arm_eabi_supporting_arches list of sane-toolchain.inc. Remove the latter occurance.

Looks good. I'll let Khem or some who is more familiar with toolchains apply.

One suggestion, we have a commit policy
(http://wiki.openembedded.net/index.php/Commit_Policy), so if you follow that on future patches, we can directly git-am your patches and push them with no extra work.

So the commit message for this might be:

sane-toolchain.inc: remove extra armv5te in eabi-capable list

This allows people to very quickly get an idea what this patch applies to, and makes for nice formatting in the weekly change logs.

Thanks,
Cliff

#2 lore raw
Quoted 13 lines · Cliff Brake
Quoted 4 lines · Aleksandr Koltsoff

(My first patch generated with git, please be gentle :-).

armv5te is mentioned twice in the arm_eabi_supporting_arches list of sane-toolchain.inc. Remove the latter occurance.

Looks good. I'll let Khem or some who is more familiar with toolchains apply.

One suggestion, we have a commit policy
(http://wiki.openembedded.net/index.php/Commit_Policy), so if you follow that on future patches, we can directly git-am your patches and push them with no extra work.

Quoted 6 lines

So the commit message for this might be:

sane-toolchain.inc: remove extra armv5te in eabi-capable list

This allows people to very quickly get an idea what this patch applies to, and makes for nice formatting in the weekly change logs.

Note that in general we don't like putting the filename in the commit message.

regards,

Koen

#3 lore raw
In reply to Aleksandr Koltsoff

conf/distro/include/sane-toolchain.inc def detect_arm_abi (d): · line 160

Quoted 10 lines · Aleksandr Koltsoff

(My first patch generated with git, please be gentle :-).

armv5te is mentioned twice in the arm_eabi_supporting_arches list of sane-toolchain.inc. Remove the latter occurance.

def compute_os_portion_of_target_triplet (d):

conf/distro/include/sane-toolchain.inc +1 -1
 	import bb
 	arm_eabi_supporting_arches = "armv6 armv6-novfp \
-	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv5te armv4t"
+	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv4t"

Looks like armv6 is also mentioned twice...

Quoted 1 line

ppc_spe_supporting_arches = "ppce500v2 ppce500"

Denys