Skip to contentSkip to conversation

Retry ADD_TO_MLQUEUE return value for EH commands

PATCH New Hannes Reinecke 1 participant 1 message Sep 17, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Retry ADD_TO_MLQUEUE return value for EH commands

A target reset when I/O is ongoing might result
an eventual device offline, as scsi_eh_completed_normally() might return ADD_TO_MLQUEUE in addition to the advertised SUCCESS, FAILED, and NEEDS_RETRY.

Which is unfortunate as scsi_send_eh_cmnd() will therefore map ADD_TO_MLQUEUE to FAILED instead of the more appropriate NEEDS_RETRY.

drivers/scsi/scsi_error.c +3 -0
index 39ce3ab..dd6d344 100644
@@ -793,6 +793,9 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
 		case NEEDS_RETRY:
 		case FAILED:
 			break;
+		case ADD_TO_MLQUEUE:
+			rtn = NEEDS_RETRY;
+			break;
 		default:
 			rtn = FAILED;
 			break;