rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
Hi Ivo,
Apologies if this has already been reported. Building today's mainline kernel (ab86e5) I'm seeing this error:
drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a cast drivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
$ grep RT2 .config CONFIG_RT2X00=y # CONFIG_RT2400PCI is not set CONFIG_RT2500PCI=y # CONFIG_RT2500USB is not set # CONFIG_RT2800USB is not set CONFIG_RT2X00_LIB_PCI=y CONFIG_RT2X00_LIB=y CONFIG_RT2X00_LIB_LEDS=y # CONFIG_RT2X00_DEBUG is not set # CONFIG_RT2860 is not set # CONFIG_RT2870 is not set
Andrew
Quoted 8 lines · Andrew Price
Hi Ivo,
Apologies if this has already been reported. Building today's mainline kernel (ab86e5) I'm seeing this error:
drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a castdrivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
Strange...I don't see this warning. Are you sure you have a clean checkout?
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 11 lines · John W. Linville
Quoted 8 lines · Andrew Price
Hi Ivo,
Apologies if this has already been reported. Building today's mainline kernel (ab86e5) I'm seeing this error:
drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a castdrivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’Strange...I don't see this warning. Are you sure you have a clean checkout?
I double-checked:
- git status returned no changes
- git clean -fqdx
- ccache -C
- Retried the build
and still got the same error. Is this something to do with the second definition of rt2x00crypto_rx_insert_iv still having an l2pad parameter...
This (untested) patch fixes the build for me:
--
drivers/net/wireless/rt2x00/rt2x00lib.h +1 -1
@@ -380,7 +380,7 @@ static inline void rt2x00crypto_tx_insert_iv(struct sk_buff *skb, { } -static inline void rt2x00crypto_rx_insert_iv (struct sk_buff *skb,bool l2pad, +static inline void rt2x00crypto_rx_insert_iv (struct sk_buff *skb,unsigned int header_length,struct rxdone_entry_desc *rxdesc) {
Quoted 20 lines · Andrew Price
Quoted 11 lines · John W. Linville
Quoted 8 lines · Andrew Price
Hi Ivo,
Apologies if this has already been reported. Building today's mainline kernel (ab86e5) I'm seeing this error:
drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a castdrivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’Strange...I don't see this warning. Are you sure you have a clean checkout?
I double-checked:
- git status returned no changes
- git clean -fqdx
- ccache -C
- Retried the build
Quoted 4 lines
and still got the same error. Is this something to do with the second definition of
rt2x00crypto_rx_insert_ivstill having an l2pad parameter...This (untested) patch fixes the build for me:
Oh, I see now -- thanks for the patch! FWIW, it would seem to only show-up when you have CONFIG_RT2500PCI but none of the other rt2x00 family drivers in your .config...
John
P.S. Could you resubmit to [email protected], following the normal patch submission guidelines as discussed here?
http://linux.yyz.us/patch-format.html
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 21 lines · John W. Linville
Quoted 20 lines · Andrew Price
Quoted 11 lines · John W. Linville
Quoted 8 lines · Andrew Price
Hi Ivo,
Apologies if this has already been reported. Building today's mainline kernel (ab86e5) I'm seeing this error:
drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a castdrivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’Strange...I don't see this warning. Are you sure you have a clean checkout?
I double-checked:
- git status returned no changes
- git clean -fqdx
- ccache -C
- Retried the build
Quoted 8 lines
Quoted 4 lines
and still got the same error. Is this something to do with the second definition of
rt2x00crypto_rx_insert_ivstill having an l2pad parameter...This (untested) patch fixes the build for me:
Oh, I see now -- thanks for the patch! FWIW, it would seem to only show-up when you have
CONFIG_RT2500PCIbut none of the other rt2x00 family drivers in your .config...
Ah yes, that patch looks correct, indeed this is only triggered when only CONFIG_RT2400PCI and/or CONFIG_RT2500PCI are selected without the other drivers (which support HW crypto).
Ivo
Quoted 10 lines · John W. Linville
Oh, I see now -- thanks for the patch! FWIW, it would seem to only show-up when you have
CONFIG_RT2500PCIbut none of the other rt2x00 family drivers in your .config...John
P.S. Could you resubmit to [email protected], following the normal patch submission guidelines as discussed here?
Done. Just waiting for the greylist to let it through :-)
Cheers,
Andrew