Skip to contentSkip to conversation

generalise Treo680 code and add support for Palm Centro - round 3

PATCH New Tomáš Čech 3 participants 15 messages Sep 11, 2009 – Oct 12, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi,

this is round 3 of generalisation Treo680 code and consequential add Palm Centro 685 support.

Changes since last round:
- filename is now palmtreo.c to remain Palm devices consistency
- generic functions are now beginning with treo_ (instead of previous palmgsm_)
- pxamci_platform_data now contains also '.gpio_card_ro = -1,'
- added MAINTAINERS entry
- reduced patchset (patches preceding these are already applied)

Thanks for your time.

Round 3 - fight!

Best regards,

Tomas Cech

#1 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

From: Tom?? ?ech <sleep [email protected]>

---
 arch/arm/mach-pxa/Kconfig                   |    5 +
 arch/arm/mach-pxa/Makefile                  |    2 +-
 arch/arm/mach-pxa/include/mach/palmtreo.h   |   60 ++++++++
 arch/arm/mach-pxa/include/mach/treo680.h    |   49 -------
 arch/arm/mach-pxa/{treo680.c => palmtreo.c} |  202 ++++++++++++++++-----------
 5 files changed, 183 insertions(+), 135 deletions(-)
 create mode 100644 arch/arm/mach-pxa/include/mach/palmtreo.h
 delete mode 100644 arch/arm/mach-pxa/include/mach/treo680.h
 rename arch/arm/mach-pxa/{treo680.c => palmtreo.c} (69%)
arch/arm/mach-pxa/Kconfig +5 -0
index a6f8eab..ce6519c 100644
@@ -421,12 +421,17 @@ config MACH_PALMZ72
 	  Say Y here if you intend to run this kernel on Palm Zire 72
 	  handheld computer.
 
+config PALM_TREO
+	bool
+	depends on ARCH_PXA_PALM
+
 config MACH_TREO680
 	bool "Palm Treo 680"
 	default y
 	depends on ARCH_PXA_PALM
 	select PXA27x
 	select IWMMXT
+	select PALM_TREO
 	help
 	  Say Y here if you intend to run this kernel on Palm Treo 680
 	  smartphone.
arch/arm/mach-pxa/Makefile +1 -1
index f10e152..e5d450c 100644
@@ -64,7 +64,7 @@ obj-$(CONFIG_MACH_PALMT5)	+= palmt5.o
 obj-$(CONFIG_MACH_PALMTX)	+= palmtx.o
 obj-$(CONFIG_MACH_PALMLD)	+= palmld.o
 obj-$(CONFIG_MACH_PALMZ72)	+= palmz72.o
-obj-$(CONFIG_MACH_TREO680)	+= treo680.o
+obj-$(CONFIG_PALM_TREO)		+= palmtreo.o
 obj-$(CONFIG_ARCH_VIPER)	+= viper.o
 
 ifeq ($(CONFIG_MACH_ZYLONITE),y)
arch/arm/mach-pxa/include/mach/palmtreo.h new file +60 -0

60 lines not on this page · raw message

arch/arm/mach-pxa/include/mach/treo680.h deleted +0 -49

49 lines not on this page · raw message

arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +117 -85

439 lines not on this page · raw message

Signature · 1 line
1.6.4.2
#3 lore raw

PATCH 2/2 PalmTreo: add Palm Centro 685 support

In reply to Tomáš Čech

From: Tom?? ?ech <sleep [email protected]>

---
 arch/arm/mach-pxa/Kconfig                 |   13 ++-
 arch/arm/mach-pxa/include/mach/palmtreo.h |    7 ++
 arch/arm/mach-pxa/palmtreo.c              |  161 +++++++++++++++++++++++++++++
 arch/arm/mm/mmu.c                         |    2 +-
 4 files changed, 181 insertions(+), 2 deletions(-)
arch/arm/mach-pxa/Kconfig +12 -1
index ce6519c..57eceb8 100644
@@ -425,6 +425,17 @@ config PALM_TREO
 	bool
 	depends on ARCH_PXA_PALM
 
+config MACH_CENTRO
+	bool "Palm Centro 685 (GSM)"
+	default y
+	depends on ARCH_PXA_PALM
+	select PXA27x
+	select IWMMXT
+	select PALM_TREO
+	help
+	  Say Y here if you intend to run this kernel on Palm Centro 685 (GSM)
+	  smartphone.
+
 config MACH_TREO680
 	bool "Palm Treo 680"
 	default y
@@ -433,7 +444,7 @@ config MACH_TREO680
 	select IWMMXT
 	select PALM_TREO
 	help
-	  Say Y here if you intend to run this kernel on Palm Treo 680
+	  Say Y here if you intend to run this kernel on Palm Treo 680 (GSM)
 	  smartphone.
 
 config MACH_PALMLD
arch/arm/mach-pxa/include/mach/palmtreo.h +7 -0
index 8cb0bca..2d3f14e 100644
@@ -3,6 +3,7 @@
  *
  * currently supported:
  *     Palm Treo 680 (GSM)
+ *     Palm Centro 685 (GSM)
  *
  * Author:     Tomas Cech <[email protected]>
  *
@@ -45,6 +46,12 @@
 #define GPIO_NR_TREO680_BT_EN		43
 #endif /* CONFIG_MACH_TREO680 */
 
+/* Centro685 specific GPIOs */
+#define GPIO_NR_CENTRO_SD_POWER		21
+#define GPIO_NR_CENTRO_VIBRATE_EN	22
+#define GPIO_NR_CENTRO_KEYB_BL		33
+#define GPIO_NR_CENTRO_BT_EN		80
+
 /* Various addresses  */
 #define TREO_PHYS_RAM_START	0xa0000000
 #define TREO_PHYS_IO_START	0x40000000
arch/arm/mach-pxa/palmtreo.c +161 -0

200 lines not on this page · raw message

arch/arm/mm/mmu.c +1 -1
index 4426ee6..92b27ab 100644
@@ -843,7 +843,7 @@ void __init reserve_node_zero(pg_data_t *pgdat)
 				BOOTMEM_EXCLUSIVE);
 	}
 
-	if (machine_is_treo680()) {
+	if (machine_is_treo680() || machine_is_centro()) {
 		reserve_bootmem_node(pgdat, 0xa0000000, 0x1000,
 				BOOTMEM_EXCLUSIVE);
 		reserve_bootmem_node(pgdat, 0xa2000000, 0x1000,
Signature · 1 line
1.6.4.2
#4 lore raw

PATCH 2/2 PalmTreo: add Palm Centro 685 support

Dne P? 11. z??? 2009 13:57:02 Tom?? ?ech napsal(a):

Quoted 35 lines

From: Tom?? ?ech <sleep [email protected]>

---
 arch/arm/mach-pxa/Kconfig                 |   13 ++-
 arch/arm/mach-pxa/include/mach/palmtreo.h |    7 ++
 arch/arm/mach-pxa/palmtreo.c              |  161
+++++++++++++++++++++++++++++ arch/arm/mm/mmu.c                         |  
 2 +-
 4 files changed, 181 insertions(+), 2 deletions(-)
arch/arm/mach-pxa/Kconfig +11 -0
index ce6519c..57eceb8 100644
@@ -425,6 +425,17 @@ config PALM_TREO
 	bool
 	depends on ARCH_PXA_PALM
 
+config MACH_CENTRO
+	bool "Palm Centro 685 (GSM)"
+	default y
+	depends on ARCH_PXA_PALM
+	select PXA27x
+	select IWMMXT
+	select PALM_TREO
+	help
+	  Say Y here if you intend to run this kernel on Palm Centro 685 (GSM)
+	  smartphone.
+
 config MACH_TREO680
 	bool "Palm Treo 680"
 	default y

arch/arm/mach-pxa/Kconfig config MACH_TREO680 · line 447

Quoted 5 lines
arch/arm/mach-pxa/Kconfig +1 -1
@@ -433,7 +444,7 @@ config MACH_TREO680
 	select IWMMXT
 	select PALM_TREO
 	help
-	  Say Y here if you intend to run this kernel on Palm Treo 680
+	  Say Y here if you intend to run this kernel on Palm Treo 680 (GSM)

This change certainly should not be in this patch, maybe in previous one ?

arch/arm/mach-pxa/Kconfig config MACH_TREO680 · line 450

Quoted 3 lines
arch/arm/mach-pxa/Kconfig +0 -0
 	  smartphone.
 
 config MACH_PALMLD

...
Cheers!

#5 lore raw

PATCH 2/2 PalmTreo: add Palm Centro 685 support

Hi,

Dne So 12. z??? 2009 21:31:15 Marek Vasut napsal(a):

Quoted 35 lines

Dne P? 11. z??? 2009 13:57:02 Tom?? ?ech napsal(a):

Quoted 34 lines

From: Tom?? ?ech <sleep [email protected]>

---
 arch/arm/mach-pxa/Kconfig                 |   13 ++-
 arch/arm/mach-pxa/include/mach/palmtreo.h |    7 ++
 arch/arm/mach-pxa/palmtreo.c              |  161
+++++++++++++++++++++++++++++ arch/arm/mm/mmu.c                         |  
 2 +-
 4 files changed, 181 insertions(+), 2 deletions(-)
arch/arm/mach-pxa/Kconfig +11 -0
index ce6519c..57eceb8 100644
@@ -425,6 +425,17 @@ config PALM_TREO
 	bool
 	depends on ARCH_PXA_PALM
 
+config MACH_CENTRO
+	bool "Palm Centro 685 (GSM)"
+	default y
+	depends on ARCH_PXA_PALM
+	select PXA27x
+	select IWMMXT
+	select PALM_TREO
+	help
+	  Say Y here if you intend to run this kernel on Palm Centro 685 (GSM)
+	  smartphone.
+
 config MACH_TREO680
 	bool "Palm Treo 680"
 	default y
Quoted 8 lines

arch/arm/mach-pxa/Kconfig config MACH_TREO680 · line 447

Quoted 6 lines
arch/arm/mach-pxa/Kconfig +1 -1
@@ -433,7 +444,7 @@ config MACH_TREO680
 	select IWMMXT
 	select PALM_TREO
 	help
-	  Say Y here if you intend to run this kernel on Palm Treo 680
+	  Say Y here if you intend to run this kernel on Palm Treo 680 (GSM)

This change certainly should not be in this patch, maybe in previous one ?

Ah, right. I'll change it in next round, but I think I'll wait until someone have a look to code not to flood ML much.

Best regards,

Tomas Cech

Applied
#6 lore raw

PATCH 2/2 PalmTreo: add Palm Centro 685 support

Quoted 47 lines · Tom?? 'Sleep_Walker' ?ech

Hi,

Dne So 12. z??? 2009 21:31:15 Marek Vasut napsal(a):

Quoted 35 lines

Dne P? 11. z??? 2009 13:57:02 Tom?? ?ech napsal(a):

Quoted 34 lines

From: Tom?? ?ech <sleep [email protected]>

---

?arch/arm/mach-pxa/Kconfig ? ? ? ? ? ? ? ? | ? 13 ++-
?arch/arm/mach-pxa/include/mach/palmtreo.h | ? ?7 ++
?arch/arm/mach-pxa/palmtreo.c ? ? ? ? ? ? ?| ?161

+++++++++++++++++++++++++++++ arch/arm/mm/mmu.c ? ? ? ? ? ? ? ? ? ? ? ? | ?2 +-
?4 files changed, 181 insertions(+), 2 deletions(-)

arch/arm/mach-pxa/Kconfig +0 -0
index ce6519c..57eceb8 100644
@@ -425,6 +425,17 @@ config PALM_TREO

? ? bool
? ? depends on ARCH_PXA_PALM

arch/arm/mach-pxa/Kconfig +11 -0
+config MACH_CENTRO
+ ? bool "Palm Centro 685 (GSM)"
+ ? default y
+ ? depends on ARCH_PXA_PALM
+ ? select PXA27x
+ ? select IWMMXT
+ ? select PALM_TREO
+ ? help
+ ? ? Say Y here if you intend to run this kernel on Palm Centro 685 (GSM)
+ ? ? smartphone.
+

?config MACH_TREO680
? ? bool "Palm Treo 680"
? ? default y

Quoted 8 lines
Quoted 6 lines
arch/arm/mach-pxa/Kconfig +0 -0
@@ -433,7 +444,7 @@ config MACH_TREO680

? ? select IWMMXT
? ? select PALM_TREO
? ? help
- ? ? Say Y here if you intend to run this kernel on Palm Treo 680
+ ? ? Say Y here if you intend to run this kernel on Palm Treo 680 (GSM)

This change certainly should not be in this patch, maybe in previous one ?

Quoted 2 lines

Ah, right. I'll change it in next round, but I think I'll wait until someone have a look to code not to flood ML much.

Applied to 'devel' without this change - file another one if this is necessary. Thanks.

#7 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

In reply to Tomáš Čech

Dne P? 11. z??? 2009 13:57:01 Tom?? ?ech napsal(a):

Quoted 15 lines

From: Tom?? ?ech <sleep [email protected]>

---
 arch/arm/mach-pxa/Kconfig                   |    5 +
 arch/arm/mach-pxa/Makefile                  |    2 +-
 arch/arm/mach-pxa/include/mach/palmtreo.h   |   60 ++++++++
 arch/arm/mach-pxa/include/mach/treo680.h    |   49 -------
 arch/arm/mach-pxa/{treo680.c => palmtreo.c} |  202
++++++++++++++++----------- 5 files changed, 183 insertions(+), 135
deletions(-)
 create mode 100644 arch/arm/mach-pxa/include/mach/palmtreo.h
 delete mode 100644 arch/arm/mach-pxa/include/mach/treo680.h
 rename arch/arm/mach-pxa/{treo680.c => palmtreo.c} (69%)

...

arch/arm/mach-pxa/palmtreo.c static struct gpio_led gpio_leds[] = { · line 415

Quoted 7 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +3 -3
-static struct gpio_led_platform_data gpio_led_info = {
-	.leds		= gpio_leds,
-	.num_leds	= ARRAY_SIZE(gpio_leds),
+static struct gpio_led_platform_data treo680_gpio_led_info = {
+	.leds		= treo680_gpio_leds,
+	.num_leds	= ARRAY_SIZE(treo680_gpio_leds),
 };

Be careful so you dont run into symbol redefinition here (gpio_led_info) in case the kernel supports more than this one device ...

Quoted 9 lines

static struct platform_device treo680_leds = {

arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +1 -1
 	.name   = "leds-gpio",
 	.id     = -1,
 	.dev    = {
-		.platform_data  = &gpio_led_info,
+		.platform_data  = &treo680_gpio_led_info,
 	}
 };

...

Quoted 5 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +2 -1
+#endif /* CONFIG_MACH_TREO680 */
+
 /* setup udc GPIOs initial state */
-static void __init treo680_udc_init(void)

arch/arm/mach-pxa/palmtreo.c static void __init treo680_pm_init(void) · line 494

Quoted 10 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +4 -3
+static void __init treo_udc_init(void)
 {
-	if (!gpio_request(GPIO_NR_TREO680_USB_PULLUP, "UDC Vbus")) {
-		gpio_direction_output(GPIO_NR_TREO680_USB_PULLUP, 1);
-		gpio_free(GPIO_NR_TREO680_USB_PULLUP);
+	if (!gpio_request(GPIO_NR_TREO_USB_PULLUP, "UDC Vbus")) {
+		gpio_direction_output(GPIO_NR_TREO_USB_PULLUP, 1);
+		gpio_free(GPIO_NR_TREO_USB_PULLUP);
 	}
 }

Is this really needed or is it just a copy-paste from other Palm device?

arch/arm/mach-pxa/palmtreo.c static void __init treo680_pm_init(void) · line 504

Quoted 11 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +2 -2
-static void __init treo680_lcd_power_init(void)
+static void __init treo_lcd_power_init(void)
 {
 	int ret;
 
-	ret = gpio_request(GPIO_NR_TREO680_LCD_POWER, "LCD POWER");
+	ret = gpio_request(GPIO_NR_TREO_LCD_POWER, "LCD POWER");
 	if (ret) {
 		pr_err("Treo680: LCD power GPIO request failed!\n");
 		return;
 	}

...

Cheers!

#8 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

Hi,

thanks for reading my patch!

Dne So 12. z??? 2009 21:29:06 Marek Vasut napsal(a):

Quoted 11 lines

...

arch/arm/mach-pxa/palmtreo.c static struct gpio_led gpio_leds[] = { · line 415

Quoted 7 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +3 -3
-static struct gpio_led_platform_data gpio_led_info = {
-	.leds		= gpio_leds,
-	.num_leds	= ARRAY_SIZE(gpio_leds),
+static struct gpio_led_platform_data treo680_gpio_led_info = {
+	.leds		= treo680_gpio_leds,
+	.num_leds	= ARRAY_SIZE(treo680_gpio_leds),
 };

Be careful so you dont run into symbol redefinition here (gpio_led_info) in case the kernel supports more than this one device ...

That's why I change the name. It's called now 'treo680_gpio_led_info' as you can see.

Quoted 10 lines

...

Quoted 9 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +3 -4
+#endif /* CONFIG_MACH_TREO680 */
+
 /* setup udc GPIOs initial state */
-static void __init treo680_udc_init(void)
+static void __init treo_udc_init(void)
 {
-	if (!gpio_request(GPIO_NR_TREO680_USB_PULLUP, "UDC Vbus")) {
-		gpio_direction_output(GPIO_NR_TREO680_USB_PULLUP, 1);
-		gpio_free(GPIO_NR_TREO680_USB_PULLUP);
Quoted 8 lines

arch/arm/mach-pxa/palmtreo.c static void __init treo680_pm_init(void) · line 494

Quoted 6 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +3 -0
+	if (!gpio_request(GPIO_NR_TREO_USB_PULLUP, "UDC Vbus")) {
+		gpio_direction_output(GPIO_NR_TREO_USB_PULLUP, 1);
+		gpio_free(GPIO_NR_TREO_USB_PULLUP);
 	}
 }

Is this really needed or is it just a copy-paste from other Palm device?

Unfortunately yes. There is no copy-paste in this code which wasn't checked and tested. It doesn't work correctly without that.

Best regards,

Tomas Cech

#9 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

Dne Ne 13. z??? 2009 11:03:37 Tom?? 'Sleep_Walker' ?ech napsal(a):

Quoted 40 lines

Hi,

thanks for reading my patch!

Dne So 12. z??? 2009 21:29:06 Marek Vasut napsal(a):

Quoted 12 lines

...

arch/arm/mach-pxa/palmtreo.c static struct gpio_led gpio_leds[] = { · line 415

Quoted 7 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +3 -3
-static struct gpio_led_platform_data gpio_led_info = {
-	.leds		= gpio_leds,
-	.num_leds	= ARRAY_SIZE(gpio_leds),
+static struct gpio_led_platform_data treo680_gpio_led_info = {
+	.leds		= treo680_gpio_leds,
+	.num_leds	= ARRAY_SIZE(treo680_gpio_leds),
 };

Be careful so you dont run into symbol redefinition here (gpio_led_info) in case the kernel supports more than this one device ...

That's why I change the name. It's called now 'treo680_gpio_led_info' as
you can see.

Quoted 18 lines

...

Quoted 4 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +2 -1
+#endif /* CONFIG_MACH_TREO680 */
+
 /* setup udc GPIOs initial state */
-static void __init treo680_udc_init(void)

arch/arm/mach-pxa/palmtreo.c static void __init treo680_pm_init(void) · line 494

Quoted 10 lines
arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +4 -3
+static void __init treo_udc_init(void)
 {
-	if (!gpio_request(GPIO_NR_TREO680_USB_PULLUP, "UDC Vbus")) {
-		gpio_direction_output(GPIO_NR_TREO680_USB_PULLUP, 1);
-		gpio_free(GPIO_NR_TREO680_USB_PULLUP);
+	if (!gpio_request(GPIO_NR_TREO_USB_PULLUP, "UDC Vbus")) {
+		gpio_direction_output(GPIO_NR_TREO_USB_PULLUP, 1);
+		gpio_free(GPIO_NR_TREO_USB_PULLUP);
 	}
 }

Is this really needed or is it just a copy-paste from other Palm device?

Quoted 7 lines

Unfortunately yes. There is no copy-paste in this code which wasn't checked
and tested. It doesn't work correctly without that.

Best regards,

Tomas Cech

Oh ok, you have my Ack on both then.

#10 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

Sorry for late response. Applied to 'devel'.

Quoted 51 lines · Marek Vasut

Dne Ne 13. z??? 2009 11:03:37 Tom?? 'Sleep_Walker' ?ech napsal(a):

Quoted 40 lines

Hi,

thanks for reading my patch!

Dne So 12. z??? 2009 21:29:06 Marek Vasut napsal(a):

Quoted 12 lines

...

Quoted 7 lines
(quoted diff) +3 -3
-static struct gpio_led_platform_data gpio_led_info = {
- .leds ? ? ? ? ? = gpio_leds,
- .num_leds ? ? ? = ARRAY_SIZE(gpio_leds),
+static struct gpio_led_platform_data treo680_gpio_led_info = {
+ .leds ? ? ? ? ? = treo680_gpio_leds,
+ .num_leds ? ? ? = ARRAY_SIZE(treo680_gpio_leds),

?};

Be careful so you dont run into symbol redefinition here (gpio_led_info) in case the kernel supports more than this one device ...

That's why I change the name. It's called now 'treo680_gpio_led_info' as ?you can see.

Quoted 18 lines

...

Quoted 6 lines
(quoted diff) +2 -0
+#endif /* CONFIG_MACH_TREO680 */
+

?/* setup udc GPIOs initial state */

arch/arm/mach-pxa/palmtreo.c renamed from arch/arm/mach-pxa/treo680.c +1 -1
-static void __init treo680_udc_init(void)
+static void __init treo_udc_init(void)

?{

Quoted 8 lines

- if (!gpio_request(GPIO_NR_TREO680_USB_PULLUP, "UDC Vbus")) {
- ? ? ? ? gpio_direction_output(GPIO_NR_TREO680_USB_PULLUP, 1);
- ? ? ? ? gpio_free(GPIO_NR_TREO680_USB_PULLUP);
+ if (!gpio_request(GPIO_NR_TREO_USB_PULLUP, "UDC Vbus")) {
+ ? ? ? ? gpio_direction_output(GPIO_NR_TREO_USB_PULLUP, 1);
+ ? ? ? ? gpio_free(GPIO_NR_TREO_USB_PULLUP);
? }
?}

Is this really needed or is it just a copy-paste from other Palm device?

Quoted 7 lines

Unfortunately yes. There is no copy-paste in this code which wasn't checked ?and tested. It doesn't work correctly without that.

Best regards,

Tomas Cech

Oh ok, you have my Ack on both then.

#11 lore raw

PATCH 1/2 PalmTreo: generalisation of Treo680 code

Dne So 10. ??jna 2009 16:06:59 Eric Miao napsal(a):

Quoted 1 line

Sorry for late response. Applied to 'devel'.

Thanks.

Best regards,

Tomas Cech

#12 lore raw
In reply to Tomáš Čech

Hi,
Dne P? 11. z??? 2009 13:57:00 Tom?? ?ech napsal(a):

Quoted 11 lines

Hi,

this is round 3 of generalisation Treo680 code and consequential add Palm Centro 685 support.

Changes since last round:
- filename is now palmtreo.c to remain Palm devices consistency
- generic functions are now beginning with treo_ (instead of previous palmgsm_)
- pxamci_platform_data now contains also '.gpio_card_ro = -1,'
- added MAINTAINERS entry
- reduced patchset (patches preceding these are already applied)

Quoted 3 lines

Thanks for your time.

Round 3 - fight!

Any progress here?

Thanks.

Best regards,

Tomas Cech

#13 lore raw

Dne ?t 17. z??? 2009 23:08:40 Tom?? 'Sleep_Walker' ?ech napsal(a):

Quoted 15 lines

Hi,

Dne P? 11. z??? 2009 13:57:00 Tom?? ?ech napsal(a):

Quoted 12 lines

Hi,

this is round 3 of generalisation Treo680 code and consequential add Palm Centro 685 support.

Changes since last round:
- filename is now palmtreo.c to remain Palm devices consistency
- generic functions are now beginning with treo_ (instead of previous
palmgsm_) - pxamci_platform_data now contains also '.gpio_card_ro = -1,'
- added MAINTAINERS entry
- reduced patchset (patches preceding these are already applied)

Quoted 5 lines
Quoted 3 lines

Thanks for your time.

Round 3 - fight!

Any progress here?

No, stop reopening! (people familiar with glibc will understand here ;-) )

Eric, could you merge this with my ack then ?

Thanks

Quoted 7 lines

Thanks.

Best regards,

Tomas Cech

#14 lore raw
Quoted 18 lines · Marek Vasut

Dne ?t 17. z??? 2009 23:08:40 Tom?? 'Sleep_Walker' ?ech napsal(a):

Quoted 17 lines

Hi,

Dne P? 11. z??? 2009 13:57:00 Tom?? ?ech napsal(a):

Quoted 14 lines

Hi,

this is round 3 of generalisation Treo680 code and consequential add Palm Centro 685 support.

Changes since last round:
? ? - filename is now palmtreo.c to remain Palm devices consistency
? ? - generic functions are now beginning with treo_ (instead of previous palmgsm_) - pxamci_platform_data now contains also '.gpio_card_ro ? ? ? ? ? = -1,'
- added MAINTAINERS entry
? ? - reduced patchset (patches preceding these are already applied)

Thanks for your time.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Round 3 - fight!

Any progress here?

No, stop reopening! (people familiar with glibc will understand here ;-) )

Eric, could you merge this with my ack then ?

Not this merge window, so I guess have to postpone this a little bit.