Skip to contentSkip to conversation

mtd: register orion_nand using platform_driver_probe()

PATCH Applied [email protected] 1 participant 1 message Sep 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/13 mtd: register orion_nand using platform_driver_probe()

From: Uwe Kleine-König <[email protected]>

orion_nand_probe lives in .init.text, so using platform_driver_register to register it is wrong because binding a device after the init memory is discarded (e.g. via sysfs) results in an oops.

As requested by Nicolas Pitre platform_driver_probe is used instead of moving the probe function to .devinit.text as proposed initially. This saves some memory, but devices registered after the driver is probed are not bound (probably there are none) and binding via sysfs isn't possible.

Cc Lennert Buytenhek <[email protected]>
Cc Saeed Bishara <[email protected]>
Cc Joern Engel <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc David Woodhouse <[email protected]>

---

 drivers/mtd/nand/orion_nand.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mtd/nand/orion_nand.c renamed from drivers/mtd/nand/orion_nand.c~mtd-register-orion_nand-using-platform_driver_probe +1 -2
diff -puN drivers/mtd/nand/orion_nand.c~mtd-register-orion_nand-using-platform_driver_probe drivers/mtd/nand/orion_nand.c
@@ -171,7 +171,6 @@ static int __devexit orion_nand_remove(s
 }
 
 static struct platform_driver orion_nand_driver = {
-	.probe		= orion_nand_probe,
 	.remove		= __devexit_p(orion_nand_remove),
 	.driver		= {
 		.name	= "orion_nand",
@@ -181,7 +180,7 @@ static struct platform_driver orion_nand
 
 static int __init orion_nand_init(void)
 {
-	return platform_driver_register(&orion_nand_driver);
+	return platform_driver_probe(&orion_nand_driver, orion_nand_probe);
 }
 
 static void __exit orion_nand_exit(void)

_