Skip to contentSkip to conversation

lguest: use PGDIR_SHIFT for PAE code to allow different PAGE_OFFSET

PATCH New Rusty Russell 1 participant 1 message Sep 21, 2009 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 3/5 lguest: use PGDIR_SHIFT for PAE code to allow different PAGE_OFFSET

We still assume the Guest and Host have the same PAGE_OFFSET settings, but now we don't assume 0xC0000000.

---
 drivers/lguest/page_tables.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/lguest/page_tables.c +2 -4
@@ -996,11 +996,9 @@ static unsigned long setup_pagetables(st
 	if (copy_to_user(&pgdir[0], &pgd, sizeof(pgd)) != 0)
 		return -EFAULT;
 	/*
-	 * And the third PGD entry (ie. addresses 3G-4G).
-	 *
-	 * FIXME: This assumes that PAGE_OFFSET for the Guest is 0xC0000000.
+	 * And the other PGD entry to make the linear mapping at PAGE_OFFSET
 	 */
-	if (copy_to_user(&pgdir[3], &pgd, sizeof(pgd)) != 0)
+	if (copy_to_user(&pgdir[KERNEL_PGD_BOUNDARY], &pgd, sizeof(pgd)))
 		return -EFAULT;
 #else
 	/*