Skip to contentSkip to conversation

Bitbake filterProviders does not respect sorted priorities

PATCH In review Chris Conroy 4 participants 4 messages Sep 21, 2009 – Sep 22, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bitbake filterProviders does not respect sorted priorities

Cross-posting to the OE list since I haven't heard anything from the bitbake list after posting this last week. The providers code ignores package priorities and as a result unexpected packages can get chosen when using overlays with different priority settings.

Original message posted to bitbake mailing list:

I am using bitbake 1.8.13 within OE, and I ran into a problem today where the wrong package was being selected.

Digging into the problem, I found that the code that sorts packages does not respect the priority order.

By iterating over sortpkg_pn.keys() instead of pkg_pn.keys(), it produces the expected order based on the priorities I have set. Patch below:

lib/bb/providers.py +0 -0
index 8970fb3..6c1cf78 100644
@@ -191,7 +191,7 @@ def _filterProviders(providers, item, cfgData,

dataCache):
eligible.append(preferred_versions[pn][1])

# Now add latest verisons
- for pn in pkg_pn.keys():
+ for pn in sortpkg_pn.keys():
if pn in preferred_versions and preferred_versions[pn][1]:
continue
preferred_versions[pn] = findLatestProvider(pn, cfgData,
dataCache, sortpkg_pn[pn][0])

#1 lore raw
Quoted 4 lines · Chris Conroy

Cross-posting to the OE list since I haven't heard anything from the bitbake list after posting this last week. The providers code ignores package priorities and as a result unexpected packages can get chosen when using overlays with different priority settings.

Nice. I usually enforce specific preferred providers when there are uncertainties, but it would be great to have it work properly even when I forget to do that... :)

Quoted 32 lines

Original message posted to bitbake mailing list:

I am using bitbake 1.8.13 within OE, and I ran into a problem today where the wrong package was being selected.

Digging into the problem, I found that the code that sorts packages does not respect the priority order.

By iterating over sortpkg_pn.keys() instead of pkg_pn.keys(), it produces the expected order based on the priorities I have set. Patch below:

lib/bb/providers.py +0 -0
index 8970fb3..6c1cf78 100644
@@ -191,7 +191,7 @@ def _filterProviders(providers, item, cfgData,

dataCache):
eligible.append(preferred_versions[pn][1])

# Now add latest verisons

lib/bb/providers.py +1 -1
-    for pn in pkg_pn.keys():
+    for pn in sortpkg_pn.keys():
         if pn in preferred_versions and preferred_versions[pn][1]:
             continue
         preferred_versions[pn] = findLatestProvider(pn, cfgData,

dataCache, sortpkg_pn[pn][0])

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#2 lore raw
In reply to Chris Conroy

Hi,

Quoted 4 lines · Chris Conroy

Cross-posting to the OE list since I haven't heard anything from the bitbake list after posting this last week. The providers code ignores package priorities and as a result unexpected packages can get chosen when using overlays with different priority settings.

I agree... would be good to see this fixed.

Anyone from the bitbake developers who can comment on the patch? It looks quite trivial :-)

Greetings

Florian

Signature · 5 lines
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        [email protected]
                                        http://www.kernelconcepts.de/en
#3 lore raw
In reply to Chris Conroy
Quoted 10 lines · On Monday 21 September 2009 22:07:40 Chris Conroy wrote:

Cross-posting to the OE list since I haven't heard anything from the bitbake list after posting this last week. The providers code ignores package priorities and as a result unexpected packages can get chosen when using overlays with different priority settings.

Original message posted to bitbake mailing list:

I am using bitbake 1.8.13 within OE, and I ran into a problem today where the wrong package was being selected.

Quoted 6 lines

Digging into the problem, I found that the code that sorts packages does not respect the priority order.

By iterating over sortpkg_pn.keys() instead of pkg_pn.keys(), it produces the expected order based on the priorities I have set. Patch below:

Thanks again, I had hoped Richard would be able to comment. One of the biggest problems with bitbake is that the only regression testing possible is trying to build things, your description looks sound.

It would be great if someone could test and I'm happy to apply it then.

holger