Skip to contentSkip to conversation

OMAP3 Overo: Fix ethernet related warnings

PATCH New Dirk Behme 3 participants 3 messages Sep 13, 2009 – Sep 22, 2009

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 OMAP3 Overo: Fix ethernet related warnings

Fix warning

'setup_net_chip' declared 'static' but never defined

with CONFIG_OMAP3_OVERO_TOBI disabled and

implicit declaration of function 'smc911x_initialize'

with CONFIG_OMAP3_OVERO_TOBI enabled.

---

Patch against recent u-boot-ti git f4f92c81835ccc43f74925737dfd478edb0182f2 "TI: OMAP3: Overo Tobi ethernet support"

Compile tested only ./MAKEALL omap3_overo with and without CONFIG_OMAP3_OVERO_TOBI enabled.

 board/overo/overo.c |    1 +
 board/overo/overo.h |    2 ++
 2 files changed, 3 insertions(+)
board/overo/overo.h +2 -0
Index: u-boot-ti/board/overo/overo.h
===================================================================
@@ -33,7 +33,9 @@ const omap3_sysinfo sysinfo = {
 #endif
 };
 
+#if defined(CONFIG_OMAP3_OVERO_TOBI)
 static void setup_net_chip(void);
+#endif
 
 /*
  * IEN  - Input Enable
board/overo/overo.c +1 -0
Index: u-boot-ti/board/overo/overo.c
===================================================================
@@ -29,6 +29,7 @@
  * MA 02111-1307 USA
  */
 #include <common.h>
+#include <netdev.h>
 #include <twl4030.h>
 #include <asm/io.h>
 #include <asm/arch/mux.h>
#1 lore raw

PATCH 1/1 OMAP3 Overo: Fix ethernet related warnings

Quoted 7 lines

Fix warning

'setup_net_chip' declared 'static' but never defined

Quoted 8 lines

with CONFIG_OMAP3_OVERO_TOBI disabled and

implicit declaration of function 'smc911x_initialize'

with CONFIG_OMAP3_OVERO_TOBI enabled.

Pushed to u-boot-ti

Thanks,
Sandeep

#2 lore raw

PATCH 1/1 OMAP3 Overo: Fix ethernet related warnings

Dear "Paulraj, Sandeep",

Quoted 9 lines · In message <[email protected]> you…
Quoted 9 lines

Fix warning

'setup_net_chip' declared 'static' but never defined

with CONFIG_OMAP3_OVERO_TOBI disabled and

Quoted 8 lines
Quoted 6 lines

implicit declaration of function 'smc911x_initialize'

with CONFIG_OMAP3_OVERO_TOBI enabled.

Pushed to u-boot-ti

I think all these cleanup patches by Dirk should be merged into a cleaned up version of the Overo patch which is needed anyway due to my other comments.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
COBOL is for morons.                                 -- E.W. Dijkstra