Skip to contentSkip to conversation

infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

PATCH Applied Ira Weiny 3 participants 4 messages Sep 23, 2009 – Sep 29, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore

Ira Weiny

author
#0 lore raw

PATCH 1/1 infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

From: Ira Weiny <[email protected]>
Date: Wed, 23 Sep 2009 14:26:55 -0700
Subject: [PATCH] infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

Also ibd_sm_id is never valid in this tool as the "-s" option is used for "suppress"

---
 infiniband-diags/src/ibqueryerrors.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
infiniband-diags/src/ibqueryerrors.c +2 -2
index f73ca6f..892e539 100644
@@ -441,8 +441,8 @@ int main(int argc, char **argv)
 	} else if (switch_guid_str) {
 		if ((resolved =
 		     ib_resolve_portid_str_via(&portid, switch_guid_str,
-					       IB_DEST_GUID, ibd_sm_id,
-					       ibmad_port)) >= 0)
+					       IB_DEST_GUID, NULL,
+					       ibmad_port)) < 0)
 			IBWARN("Failed to resolve %s; attempting full scan\n",
 			       switch_guid_str);
 	}
Signature · 6 lines
1.5.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 9 lines · Ira Weiny

From: Ira Weiny <[email protected]>
Date: Wed, 23 Sep 2009 14:26:55 -0700
Subject: [PATCH] infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

Also ibd_sm_id is never valid in this tool as the "-s" option is used for "suppress"

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Ira Weiny
Quoted 18 lines · Ira Weiny

From: Ira Weiny <[email protected]>
Date: Wed, 23 Sep 2009 14:26:55 -0700
Subject: [PATCH] infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

Also ibd_sm_id is never valid in this tool as the "-s" option is used for "suppress"

---
 infiniband-diags/src/ibqueryerrors.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
infiniband-diags/src/ibqueryerrors.c +0 -0
index f73ca6f..892e539 100644

infiniband-diags/src/ibqueryerrors.c int main(int argc, char **argv) · line 444

Quoted 6 lines
infiniband-diags/src/ibqueryerrors.c +1 -2
@@ -441,8 +441,8 @@ int main(int argc, char **argv)
 	} else if (switch_guid_str) {
 		if ((resolved =
 		     ib_resolve_portid_str_via(&portid, switch_guid_str,
-					       IB_DEST_GUID, ibd_sm_id,
-					       ibmad_port)) >= 0)
+					       IB_DEST_GUID, NULL,

BTW, why should 'ibd_sm_id' be replaced by NULL?

Sasha

Quoted 7 lines
infiniband-diags/src/ibqueryerrors.c +1 -0
+					       ibmad_port)) < 0)
 			IBWARN("Failed to resolve %s; attempting full scan\n",
 			       switch_guid_str);
 	}
Signature · 1 line
1.5.4.5
author
#4 lore raw
Quoted 8 lines · On Tue, 29 Sep 2009 17:41:45 +0200 Sasha Khapyorsky…
Quoted 7 lines · Ira Weiny

From: Ira Weiny <[email protected]>
Date: Wed, 23 Sep 2009 14:26:55 -0700
Subject: [PATCH] infiniband-diags/src/ibqueryerrors.c: fix bug when attempting a sub-fabric scan

Also ibd_sm_id is never valid in this tool as the "-s" option is used for "suppress"

To answer your question below:

Because the ibd_sm_id is never going to be overridden because the "-s" option is used for "suppress". So NULL should used for the default for now. I did not want to change the -s option now. Some day I can fix this up to be consistent with the other tools. Sorry.

Quoted 6 lines
Quoted 6 lines
---
 infiniband-diags/src/ibqueryerrors.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

infiniband-diags/src/ibqueryerrors.c int main(int argc, char **argv) · line 444

Quoted 11 lines
infiniband-diags/src/ibqueryerrors.c +1 -2
index f73ca6f..892e539 100644
@@ -441,8 +441,8 @@ int main(int argc, char **argv)
 	} else if (switch_guid_str) {
 		if ((resolved =
 		     ib_resolve_portid_str_via(&portid, switch_guid_str,
-					       IB_DEST_GUID, ibd_sm_id,
-					       ibmad_port)) >= 0)
+					       IB_DEST_GUID, NULL,

BTW, why should 'ibd_sm_id' be replaced by NULL?

See above,
Ira

Quoted 10 lines

Sasha

Quoted 7 lines
infiniband-diags/src/ibqueryerrors.c +1 -0
+					       ibmad_port)) < 0)
 			IBWARN("Failed to resolve %s; attempting full scan\n",
 			       switch_guid_str);
 	}
Signature · 1 line
1.5.4.5
Signature · 9 lines
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html