Skip to contentSkip to conversation

Kirkwood: rd6281a: Add kwbimage build support

PATCH New Prafulla Wadaskar 3 participants 8 messages Sep 21, 2009 – Oct 5, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kirkwood: rd6281a: Add kwbimage build support

This patch adds kwbimage configuration file
(used by mkimage utility)
to support u-boot.kwb target on rd6281a platform.

To create Kirkwood boot image to be flashed on NAND, additional parameter u-boot.kwb need to be passed during make.

---
 board/Marvell/rd6281a/config.mk    |    3 +
 board/Marvell/rd6281a/kwbimage.cfg |  167 ++++++++++++++++++++++++++++++++++++
 2 files changed, 170 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/rd6281a/kwbimage.cfg
board/Marvell/rd6281a/config.mk +3 -0
index a4ea769..2bd9f79 100644
@@ -23,3 +23,6 @@
 #
 
 TEXT_BASE = 0x00600000
+
+# Kirkwood Boot Image configuration file
+KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
board/Marvell/rd6281a/kwbimage.cfg new file +167 -0

167 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 1/1 net: phy: mv88e61xx.c : fixed build warning

following build warning was observed

mv88e61xx.c: In function ?mv88e61xx_busychk?:
mv88e61xx.c:208: warning: dereferencing type-punned pointer will break strict-aliasing rules

This patch fixes the same
Patch tested for rd6281a board build

---
 drivers/net/phy/mv88e61xx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/phy/mv88e61xx.c +2 -2
index 3754e8b..2d1de02 100644
@@ -201,11 +201,11 @@ static void mv88e61xx_port_vlan_config(struct mv88e61xx_config *swconfig,
  */
 static int mv88e61xx_busychk(char *name)
 {
-	u32 reg = 0;
+	u16 reg = 0;
 	u32 timeout = MV88E61XX_PHY_TIMEOUT;
 	do {
 		RD_PHY(name, MV88E61XX_GLB2REG_DEVADR,
-		       MV88E61XX_PHY_CMD, (u16 *) & reg);
+		       MV88E61XX_PHY_CMD, &reg);
 		if (timeout-- == 0) {
 			printf("SMI busy timeout\n");
 			return -1;
Signature · 1 line
1.5.3.3
#2 lore raw

PATCH 1/1 Kirkwood: mv88f6281gtw_ge: Add kwbimage build support

This patch adds kwbimage configuration file (used by mkimage utility)
to support u-boot.kwb target on mv88f6281gtw_ge board.

To create Kirkwood boot image to be flashed on SPI Flash, additional parameter u-boot.kwb need to be passed during make.

---
 board/Marvell/mv88f6281gtw_ge/config.mk    |    3 +
 board/Marvell/mv88f6281gtw_ge/kwbimage.cfg |  165 ++++++++++++++++++++++++++++
 2 files changed, 168 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/mv88f6281gtw_ge/kwbimage.cfg
board/Marvell/mv88f6281gtw_ge/config.mk +3 -0
index a4ea769..2bd9f79 100644
@@ -23,3 +23,6 @@
 #
 
 TEXT_BASE = 0x00600000
+
+# Kirkwood Boot Image configuration file
+KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg
board/Marvell/mv88f6281gtw_ge/kwbimage.cfg new file +165 -0

165 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#3 lore raw

PATCH 1/1 Kirkwood: mv88f6281gtw_ge: Add kwbimage build support

Quoted 16 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, September 21, 2009 8:28 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH] Kirkwood: mv88f6281gtw_ge: Add kwbimage build support

This patch adds kwbimage configuration file (used by mkimage utility)
to support u-boot.kwb target on mv88f6281gtw_ge board.

To create Kirkwood boot image to be flashed on SPI Flash, additional parameter u-boot.kwb need to be passed during make.

Quoted 7 lines
---
 board/Marvell/mv88f6281gtw_ge/config.mk    |    3 +
 board/Marvell/mv88f6281gtw_ge/kwbimage.cfg |  165 
++++++++++++++++++++++++++++
 2 files changed, 168 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/mv88f6281gtw_ge/kwbimage.cfg

Applied to u-boot-marvell master branch

Regards..
Prafulla . .

#4 lore raw

PATCH 1/1 net: phy: mv88e61xx.c : fixed build warning

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 4 lines · In message <[email protected]> you wrote:

following build warning was observed

mv88e61xx.c: In function ???mv88e61xx_busychk???:

Please don't use non-text characters in the commit messages.

(Ben, please edit when applying).

Quoted 9 lines

mv88e61xx.c:208: warning: dereferencing type-punned pointer will break strict-aliasing rules

This patch fixes the same
Patch tested for rd6281a board build

---
 drivers/net/phy/mv88e61xx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Except for that:

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
                                                   -- Francis Picabia
#5 lore raw

PATCH 1/1 net: phy: mv88e61xx.c : fixed build warning

Quoted 11 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Thursday, September 24, 2009 3:38 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ben Warren
Subject: Re: [U-Boot] [PATCH] net: phy: mv88e61xx.c : fixed build warning

Quoted 8 lines

Dear Prafulla Wadaskar,

In message

Quoted 4 lines · <[email protected]> you wrote:

following build warning was observed

mv88e61xx.c: In function ???mv88e61xx_busychk???:

Actually I used "'" here those are converted to these non-text chars by git-send-mail Anybody any Idea, how I should enable use of such chars if needed?

Regards..
Prafulla . .

Quoted 31 lines

Please don't use non-text characters in the commit messages.

(Ben, please edit when applying).

Quoted 1 line

mv88e61xx.c:208: warning: dereferencing type-punned pointer

will break strict-aliasing rules

Quoted 8 lines

This patch fixes the same
Patch tested for rd6281a board build

---
 drivers/net/phy/mv88e61xx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Except for that:

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
                                                   -- Francis Picabia
Applied
#6 lore raw

PATCH 1/1 net: phy: mv88e61xx.c : fixed build warning

In reply to Prafulla Wadaskar

Hi Prafulla,

Quoted 22 lines · Prafulla Wadaskar

following build warning was observed

mv88e61xx.c: In function ?mv88e61xx_busychk?:
mv88e61xx.c:208: warning: dereferencing type-punned pointer will break strict-aliasing rules

This patch fixes the same
Patch tested for rd6281a board build

---
 drivers/net/phy/mv88e61xx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/phy/mv88e61xx.c +0 -0
index 3754e8b..2d1de02 100644
@@ -201,11 +201,11 @@ static void mv88e61xx_port_vlan_config(struct mv88e61xx_config *swconfig,
  */
 static int mv88e61xx_busychk(char *name)
 {

drivers/net/phy/mv88e61xx.c static void mv88e61xx_port_vlan_config(struct mv88e61xx_config *swconfig, · line 211

Quoted 10 lines
drivers/net/phy/mv88e61xx.c +2 -2
-	u32 reg = 0;
+	u16 reg = 0;
 	u32 timeout = MV88E61XX_PHY_TIMEOUT;
 	do {
 		RD_PHY(name, MV88E61XX_GLB2REG_DEVADR,
-		       MV88E61XX_PHY_CMD, (u16 *) & reg);
+		       MV88E61XX_PHY_CMD, &reg);
 		if (timeout-- == 0) {
 			printf("SMI busy timeout\n");
 			return -1;

Applied to net repo.

thanks,
Ben

#7 lore raw

PATCH 1/1 Kirkwood: rd6281a: Add kwbimage build support

In reply to Prafulla Wadaskar
Quoted 16 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, September 21, 2009 8:28 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH] Kirkwood: rd6281a: Add kwbimage build support

This patch adds kwbimage configuration file
(used by mkimage utility)
to support u-boot.kwb target on rd6281a platform.

To create Kirkwood boot image to be flashed on NAND, additional parameter u-boot.kwb need to be passed during make.

Quoted 7 lines
---
 board/Marvell/rd6281a/config.mk    |    3 +
 board/Marvell/rd6281a/kwbimage.cfg |  167 
++++++++++++++++++++++++++++++++++++
 2 files changed, 170 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/rd6281a/kwbimage.cfg

Applied to u-boot-marvell master branch

Regards..
Prafulla . .