ppoll01: add signal() syscall to register the signal handler

The ppoll01 testcase has a signal handler in it but this signal handler is not registered with the kernel through the signal() syscal. The testcase fails when it sends a SIGINT to itself as part of one of the case of the test run.
The following patch
1. Adds a signal() syscall to register the signal handler
2. Corrects the expected 'revents' for the case where ppoll() is called on a file which is only opened in read/write mode, i.e case00.
3. Takes away printing the type of error ( i.e strerror(errno) ) since it only prints the last error seen and does not report the failures seen in the cases before the last failed one. The reporting of NG or OK shoudl take care of
letting the user know the cases that have passed and cases that have
failed.

Signed-off-by Chandru S <[email protected]>

---

ppoll01.c 2009-09-24 01:24:38.706487228 +0530 renamed from ppoll01.c.orig 2009-09-22 19:22:39.371235396 +0530 +2 -0

@@ -106,6 +106,8 @@ extern void cleanup() {
        tst_exit();
 }
 
+void sighandler(int sig);       /* signals handler function for the test
 */
+
 /* Local  Functions */
 

/******************************************************************************/ /*
*/

ppoll01.c 2009-09-24 01:24:38.706487228 +0530 renamed from ppoll01.c.orig 2009-09-22 19:22:39.371235396 +0530 +2 -1

@@ -125,7 +127,8 @@ extern void cleanup() {
 /*
   */
 
 /******************************************************************************/
 void setup() {
-        /* Capture signals if any */
+        /* Capture signals*/
+       signal(SIGINT, &sighandler);
        /* Create temporary directories */

        TEST_PAUSE;
        tst_tmpdir();

ppoll01.c 2009-09-24 01:24:38.706487228 +0530 renamed from ppoll01.c.orig 2009-09-22 19:22:39.371235396 +0530 +2 -2

@@ -191,7 +194,7 @@ struct test_case {
 static struct test_case tcase[] = {
       { // case00
                .ttype          = NORMAL,
-                .expect_revents = POLLOUT,
+                .expect_revents = POLLOUT | POLLIN,
                .ret            = 0,
                .err            = 0,
        },

@@ -463,7 +466,7 @@ int main(int ac, char **av) {
                               break;
 
               default:
-                               tst_resm(TFAIL, "%s failed - errno = %d :
 %s", TCID, TEST_ERRNO, strerror(TEST_ERRNO));
+                               tst_resm(TFAIL, "%s failed", TCID);
                               RPRINTF("NG");
                               cleanup();

                               tst_exit();

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

I applied this patch, and it fixed ppoll01 on an Ubuntu Hardy box which had been failing. Kernel is 2.6.24.

Kelly

Quoted 17 lines · Chandru

The ppoll01 testcase has a signal handler in it but this signal handler is not registered with the kernel through the signal() syscal. The testcase fails when it sends a SIGINT to itself as part of one of the case of the test run.
The following patch
1. Adds a signal() syscall to register the signal handler
2. Corrects the expected 'revents' for the case where ppoll() is called on a file which is only opened in read/write mode, i.e case00.
3. Takes away printing the type of error ( i.e strerror(errno) ) since it only prints the last error seen and does not report the failures seen in the cases before the last failed one. The reporting of NG or OK shoudl take care of
   letting the user know the cases that have passed and cases that have failed.

Signed-off-by Chandru S <[email protected]>

Quoted 7 lines

               default:
-                               tst_resm(TFAIL, "%s failed - errno = %d :
%s", TCID, TEST_ERRNO, strerror(TEST_ERRNO));
+                               tst_resm(TFAIL, "%s failed", TCID); RPRINTF("NG");
                               cleanup();
                               tst_exit();

3. Takes away
printing the type of error ( i.e strerror(errno) ) since it only prints the last error seen and does not report the failures seen in the cases before the last failed one. The reporting of NG or OK shoudl take care of letting the user know the cases that have passed and cases that have failed.

- tst_resm(TFAIL, "%s failed - errno = %d : %s", TCID,
TEST_ERRNO, strerror(TEST_ERRNO));
+ tst_resm(TFAIL, "%s failed", TCID);

Quoted 7 lines · On Thursday 24 September 2009 02:59:32 Chandru wrote:

3. Takes away
printing the type of error ( i.e strerror(errno) ) since it only prints the last error seen and does not report the failures seen in the cases before the last failed one. The reporting of NG or OK shoudl take care of letting the user know the cases that have passed and cases that have failed.

Quoted 3 lines

- tst_resm(TFAIL, "%s failed - errno = %d : %s", TCID,
TEST_ERRNO, strerror(TEST_ERRNO));
+ tst_resm(TFAIL, "%s failed", TCID);

why dont you *fix* the issues you see with this output instead of making the output even more useless ? also, this should be converted to TFAIL|TTERRNO. -mike

I will retain the current existing tst_resm lines and add TFAIL|TTERRNO to it as per your suggestion. The reason being that there is not much gain in making the above changes to the test case.

Quoted 12 lines · On Saturday 26 September 2009 16:55:28 Mike Frysinger wrote:

Quoted 10 lines · On Thursday 24 September 2009 02:59:32 Chandru wrote:

3. Takes away
printing the type of error ( i.e strerror(errno) ) since it only
prints the last error seen and does not report the failures seen in the cases before the last failed one. The reporting of NG or OK shoudl take care of letting the user know the cases that have passed and cases that have failed.

- tst_resm(TFAIL, "%s failed - errno = %d : %s",
TCID, TEST_ERRNO, strerror(TEST_ERRNO));
+ tst_resm(TFAIL, "%s failed", TCID);

Quoted 3 lines

why dont you *fix* the issues you see with this output instead of making the output even more useless ? also, this should be converted to TFAIL|TTERRNO.

em, the change was not useless, the existing reporting of failure was. The
output on failure of only the first case prints as
"ppoll01 1 TFAIL : ppoll01 failed - errno = 0 : Success"

- tst_resm(TFAIL, "%s failed - errno = %d : %s", TCID, TEST_ERRNO,

			strerror(TEST_ERRNO));

+ tst_resm(TPASS, "ppoll result = %d ",result);

+ for (i = 0; i < (int)(sizeof(tcase) / sizeof(tcase[0])); i++)
+ if (tstatus & (1 << i))
+ tst_resm(TFAIL|TTERRNO, "%s failed - errno = %d : %s", TCID,

		 terrno[i], strerror(terrno[i]));