Skip to contentSkip to conversation

nommu: Correct is_vmamloc_or_module_addr() definition.

PATCH In review Paul Mundt 2 participants 3 messages Sep 25, 2009 MM core

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 nommu: Correct is_vmamloc_or_module_addr() definition.

Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.

Cc KAMEZAWA Hiroyuki <[email protected]>

---

 include/linux/mm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -1
index b6eae5e..23e7fd6 100644
@@ -288,7 +288,7 @@ static inline int is_vmalloc_addr(const void *x)
 #ifdef CONFIG_MMU
 extern int is_vmalloc_or_module_addr(const void *x);
 #else
-static int is_vmalloc_or_module_addr(const void *x)
+static inline int is_vmalloc_or_module_addr(const void *x)
 {
 	return 0;
 }
#1 lore raw
Quoted 6 lines · On Fri, 25 Sep 2009 12:07:06 +0900 Paul Mundt <[email protected]> wrote:

Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.

Cc KAMEZAWA Hiroyuki <[email protected]>

Ah, sorry. I think Andrew queues the same patch.

Thanks,
-Kame

Quoted 19 lines

---

 include/linux/mm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -1
index b6eae5e..23e7fd6 100644
@@ -288,7 +288,7 @@ static inline int is_vmalloc_addr(const void *x)
 #ifdef CONFIG_MMU
 extern int is_vmalloc_or_module_addr(const void *x);
 #else
-static int is_vmalloc_or_module_addr(const void *x)
+static inline int is_vmalloc_or_module_addr(const void *x)
 {
 	return 0;
 }
author
#2 lore raw
Quoted 11 lines · KAMEZAWA Hiroyuki
Quoted 6 lines · On Fri, 25 Sep 2009 12:07:06 +0900 Paul Mundt <[email protected]> wrote:

Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.

Cc KAMEZAWA Hiroyuki <[email protected]>

Ah, sorry. I think Andrew queues the same patch.

Ah, I'm too slow, David already caught it:

commit 934831d060ccd5471ecbc562804a8d3ccd6e562c

Author: David Howells <[email protected]>
Date:   Thu Sep 24 12:33:32 2009 +0100

NOMMU: Fallback for is_vmalloc_or_module_addr() should be inline

The NOMMU fallback for is_vmalloc_or_module_addr() should be static inline, not just static, in linux/mm.h.

Sorry for the noise!