Add basic HP iPAQ rx1950 support
PATCH v2 2/5 Add basic HP iPAQ rx1950 support
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-basic-HP-iPAQ-rx1950-support.patch
Type: text/x-patch
Size: 11358 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090927/5b9b44ef/attachment.bin>
PATCH v2 2/5 Add basic HP iPAQ rx1950 support
Quoted 41 lines · Vasily Khoruzhick
From
1490cd5bd21d387b122332edfb2537437d3cb1f3Mon Sep 17 00:00:00 2001
From: Vasily Khoruzhick <[email protected]>
Date: Thu, 24 Sep 2009 21:58:36 +0300
Subject: [PATCH v2 2/5] Add basic HP iPAQ rx1950 supportSigned-off-by Vasily Khoruzhick <[email protected]>--- arch/arm/mach-s3c2442/Kconfig | 10 + arch/arm/mach-s3c2442/Makefile | 2 +- arch/arm/mach-s3c2442/mach-rx1950.c | 368 +++++++++++++++++++++++++++++++++++ 3 files changed, 379 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-s3c2442/mach-rx1950.carch/arm/mach-s3c2442/Kconfig +10
-0@@ -36,6 +36,16 @@ config MACH_NEO1973_GTA02 help Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone +config MACH_RX1950 + bool "HP iPAQ rx1950" + select CPU_S3C2442 + select PM_H1940 if PM + select I2C + select S3C2410_PWM + select S3C2410_IOTIMING if S3C2440_CPUFREQ + select S3C2440_XTAL_16934400 + help + Say Y here if you're using HP iPAQ rx1950 endmenuarch/arm/mach-s3c2442/Makefile +0
-0
arch/arm/mach-s3c2442/Makefile obj-$(CONFIG_CPU_S3C2442) += s3c2442.o · line 17
Quoted 6 lines
arch/arm/mach-s3c2442/Makefile +1
-1@@ -13,6 +13,6 @@ obj-$(CONFIG_CPU_S3C2442) += s3c2442.o obj-$(CONFIG_CPU_S3C2442) += clock.o obj-$(CONFIG_MACH_NEO1973_GTA02) += mach-gta02.o - +obj-$(CONFIG_MACH_RX1950) += mach-rx1950.o # Machine support
you managed to take out a blank line, please don't do that.
arch/arm/mach-s3c2442/mach-rx1950.c line 4
Quoted 10 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +4
-0@@ -0,0 +1,368 @@ +/* linux/arch/arm/mach-s3c2440/mach-rx1950.c +* +* Copyright (c) 2006-2009 Victor Chukhantsev, Denis Grigoriev, +* Copyright (c) 2007-2009 Vasily Khoruzhick
would be good to get the acked-by for the other two authours on this.
Quoted 33 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +33
-0+* based on smdk2440 written by Ben Dooks +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +* +*/ + +#include <linux/kernel.h> +#include <linux/types.h> +#include <linux/interrupt.h> +#include <linux/list.h> +#include <linux/delay.h> +#include <linux/timer.h> +#include <linux/init.h> +#include <linux/gpio.h> +#include <linux/platform_device.h> +#include <linux/serial_core.h> +#include <linux/input.h> +#include <linux/gpio_keys.h> +#include <linux/sysdev.h> +#include <linux/pwm_backlight.h> +#include <linux/pwm.h> +#include <linux/mtd/mtd.h> +#include <linux/mtd/partitions.h> +#include <linux/mmc/host.h> +#include <asm/mach/arch.h> +#include <asm/mach/map.h> +#include <asm/mach-types.h> +#include <mach/regs-gpio.h> +#include <mach/regs-gpioj.h> +#include <mach/h1940.h> +#include <mach/fb.h>
arch/arm/mach-s3c2442/mach-rx1950.c line 47
Quoted 10 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +10
-0+#include <plat/regs-serial.h> +#include <plat/regs-iic.h> +#include <plat/mci.h> +#include <plat/udc.h> +#include <plat/nand.h> +#include <plat/iic.h> +#include <plat/devs.h> +#include <plat/cpu.h> +#include <plat/pm.h> +#include <plat/irq.h>
hmm, blank lines between the groups on includes?
Quoted 14 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +14
-0+static struct map_desc rx1950_iodesc[]__initdata = { +/* ISA IO Space map (memory space selected by A24) */ + { + .virtual = (u32 )S3C24XX_VA_ISA_WORD , + .pfn =__phys_to_pfn (S3C2410_CS2 ), + .length =0x10000 , + .type =MT_DEVICE , + }, + { + .virtual = (u32 )S3C24XX_VA_ISA_WORD +0x10000 , + .pfn =__phys_to_pfn (S3C2410_CS2 + (1 <<24 )), + .length =SZ_4M , + .type =MT_DEVICE , + },
arch/arm/mach-s3c2442/mach-rx1950.c line 71
Quoted 10 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +10
-0+}; + +static struct s3c24xx_uart_clksrc rx1950_serial_clocks[] = { + [0 ] = { + .name ="fclk" , + .divisor =0x0a , + .min_baud =0 , + .max_baud =0 , + } +};
the closing bracket should be as thus:
[0] = {
...stuff...
},note, level and addition of ,
lots of these that need to be fixed.
Quoted 18 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +18
-0+static int rx1950_backlight_notify (int brightness) +{ +static int disabled =1 ; +if (!brightness) { +if (!disabled) { +s3c2410_gpio_setpin (S3C2410_GPB (0 ),0 ); +s3c2410_gpio_pullup (S3C2410_GPB (0 ),0 ); +s3c2410_gpio_cfgpin (S3C2410_GPB (0 ), +S3C2410_GPIO_OUTPUT ); + } + disabled =1 ; + }else { +if (disabled) { +/* LED driver need a "push" to power on */ +s3c2410_gpio_setpin (S3C2410_GPB (0 ),1 ); +s3c2410_gpio_pullup (S3C2410_GPB (0 ),1 ); +/* Warm up backlight for one period of PWM. +* Without this trick its almost impossible to
arch/arm/mach-s3c2442/mach-rx1950.c line 99
Quoted 10 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +10
-0+* enable backlight +*/ +ndelay (48000 ); +s3c2410_gpio_cfgpin (S3C2410_GPB (0 ), +S3C2410_GPB0_TOUT0 ); + } + disabled =0 ; + } +return brightness; +}
Maybe this is something that should be done in the pwm-bl driver?
arch/arm/mach-s3c2442/mach-rx1950.c line 100
Quoted 1 line
arch/arm/mach-s3c2442/mach-rx1950.c new file +1
-0+ {KEY_POWER, S3C2410_GPF(0), 1, "Power button"},
some spacing... named initialisers would have been nice too
arch/arm/mach-s3c2442/mach-rx1950.c line 104
Quoted 4 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +4
-0+static struct platform_device rx1950_device_gpiokeys = { + .name ="gpio-keys" , + .dev = {.platform_data = &rx1950_gpio_keys_data,} +};
how about .dev.platform_data = instead of brackets?
arch/arm/mach-s3c2442/mach-rx1950.c line 106
Quoted 2 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +2
-0+/* Configuring udc pullup */ +s3c2410_gpio_cfgpin (S3C2440_GPJ5 ,S3C2410_GPIO_OUTPUT );
please use gpiolib interface, we're moving away from specific gpio set interface.
arch/arm/mach-s3c2442/mach-rx1950.c line 108
Quoted 2 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +2
-0+/* Configuring mmc ro sense pin */ +s3c2410_gpio_cfgpin (S3C2410_GPH (8 ),S3C2410_GPIO_INPUT );
The MMC driver should be setting this as an input.
arch/arm/mach-s3c2442/mach-rx1950.c line 115
Quoted 7 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +7
-0+/* Configuring mmc power pin */ +s3c2410_gpio_setpin (S3C2440_GPJ1 ,S3C2410_GPIO_OUTPUT ); +/* mmc power is disabled by default */ +s3c2410_gpio_setpin (S3C2440_GPJ1 ,0 ); + +/* Configuring udc vbus pin */ +s3c2410_gpio_setpin (S3C2410_GPG (5 ),S3C2410_GPG5_EINT13 );
no need to, the request_irq() calls the right set_type function which implicitly sets the IRQ.
Quoted 12 lines
arch/arm/mach-s3c2442/mach-rx1950.c new file +12
-0+/* Some udc magic */ +s3c2410_modify_misccr (S3C2410_MISCCR_USBHOST | +S3C2410_MISCCR_USBSUSPND0 | +S3C2410_MISCCR_USBSUSPND1 ,0x0 ); + +s3c24xx_udc_set_platdata (&rx1950_udc_cfg); + +platform_add_devices (rx1950_devices,ARRAY_SIZE (rx1950_devices)); + +s3c_pm_init (); +s3c_irq_wake (IRQ_EINT0 ,1 ); +}
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH v2 2/5 Add basic HP iPAQ rx1950 support
? ????????? ?? 27 ???????? 2009 09:18:02 ????? Ben Dooks ???????:
Quoted 22 lines
Quoted 22 lines
(quoted diff) +22
-0+static int rx1950_backlight_notify(int brightness) +{ + static int disabled = 1; + if (!brightness) { + if (!disabled) { + s3c2410_gpio_setpin(S3C2410_GPB(0), 0); + s3c2410_gpio_pullup(S3C2410_GPB(0), 0); + s3c2410_gpio_cfgpin(S3C2410_GPB(0), + S3C2410_GPIO_OUTPUT); + } + disabled = 1; + } else { + if (disabled) { + /* LED driver need a "push" to power on */ + s3c2410_gpio_setpin(S3C2410_GPB(0), 1); + s3c2410_gpio_pullup(S3C2410_GPB(0), 1); + /* Warm up backlight for one period of PWM. + * Without this trick its almost impossible to + * enable backlight + */ + ndelay(48000); + s3c2410_gpio_cfgpin(S3C2410_GPB(0),
Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ S3C2410_GPB0_TOUT0); + } + disabled = 0; + } + return brightness; +}Maybe this is something that should be done in the pwm-bl driver?
Nope, it's device specific. Btw, all this code will be moved into platform driver that controls LCD and backlight power in future.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ /* Configuring udc pullup */ + s3c2410_gpio_cfgpin(S3C2440_GPJ5, S3C2410_GPIO_OUTPUT);please use gpiolib interface, we're moving away from specific gpio set interface.
I'd like to, but gpiolib interface doesn't support GPJ port :(
Thanks for review!
Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090927/b16a0b10/attachment.sig>