USB: digi_acceleport: Fix broken unthrottle.
Subsystems (2)
PATCH 1/1 USB: digi_acceleport: Fix broken unthrottle.
This patch fixes a regression introduced in39892da44b21b5362eb848ca424d73a25ccc488f.
---
Hi,
This patch is untested as I haven't got the hardware, but seems straight-forward to me.
Can you verify, Oliver?
Thanks,
Johan
drivers/usb/serial/digi_acceleport.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/usb/serial/digi_acceleport.c +4 -4
@@ -898,16 +898,16 @@ static void digi_rx_unthrottle(struct tty_struct *tty)spin_lock_irqsave (&priv->dp_port_lock, flags); -/* turn throttle off */ - priv->dp_throttled =0 ; - priv->dp_throttle_restart =0 ; -/* restart read chain */ if (priv->dp_throttle_restart) { port->read_urb->dev = port->serial->dev; ret =usb_submit_urb (port->read_urb,GFP_ATOMIC ); } +/* turn throttle off */ + priv->dp_throttled =0 ; + priv->dp_throttle_restart =0 ; +spin_unlock_irqrestore (&priv->dp_port_lock, flags);if (ret)
Signature · 1 line
1.6.4.2
Am Dienstag, 29. September 2009 12:39:23 schrieb Johan Hovold:
Quoted 4 lines
This patch is untested as I haven't got the hardware, but seems straight-forward to me.
Can you verify, Oliver?
I would prefer to see a check in usb-serial.c::serial_unthrottle()
Regards
Oliver
Quoted 7 lines · Oliver Neukum
Am Dienstag, 29. September 2009 12:39:23 schrieb Johan Hovold:
Quoted 4 lines
This patch is untested as I haven't got the hardware, but seems straight-forward to me.
Can you verify, Oliver?
I would prefer to see a check in usb-serial.c::serial_unthrottle()
This is completely unrelated to the unthrottle issue discussed elsewhere. :)
The digi_acceleport unthrottle code should (and used to) check priv->dp_throttle_restart to determine whether to resubmit and then cleared the flag. The commit mentioned mistakenly, I assume, reversed this. Plain bug. Right?
Oliver Neukum
Acked-byAm Dienstag, 29. September 2009 13:35:18 schrieb Johan Hovold:
Quoted 9 lines · Oliver Neukum
Quoted 7 lines
Am Dienstag, 29. September 2009 12:39:23 schrieb Johan Hovold:
Quoted 4 lines
This patch is untested as I haven't got the hardware, but seems straight-forward to me.
Can you verify, Oliver?
I would prefer to see a check in usb-serial.c::serial_unthrottle()
Quoted 7 lines
This is completely unrelated to the unthrottle issue discussed elsewhere. :)
The
digi_acceleportunthrottle code should (and used to) checkpriv->dp_throttle_restartto determine whether to resubmit and then cleared the flag. The commit mentioned mistakenly, I assume, reversed this. Plain bug. Right?
Eek. Yes, sorry. Unthrotteling as I currently made it cannot work. Your fix is completely correct.
Regards
Oliver