tty: fix vt_compat_ioctl
PATCH 1/1 tty: fix vt_compat_ioctl
Call compat_unimap_ioctl, not do_unimap_ioctl.
--- drivers/char/vt_ioctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/vt_ioctl.c +1 -1
@@ -1530,7 +1530,7 @@ long vt_compat_ioctl(struct tty_struct *tty, struct file * file,case PIO_UNIMAP :case GIO_UNIMAP : - ret =do_unimap_ioctl (cmd, up, perm, vc); + ret =compat_unimap_ioctl (cmd, up, perm, vc);break ;/*
Signature · 6 lines
1.6.4.4 -- Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Quoted 1 line · Andreas Schwab
Call
compat_unimap_ioctl, notdo_unimap_ioctl.
That's a nice description of what the patch does, but why do we need to do that? What is the problem here? What caused it?
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 1 line · Andreas Schwab
Call
compat_unimap_ioctl, notdo_unimap_ioctl.That's a nice description of what the patch does, but why do we need to do that?
It's a compat ioctl handler, so lets call the compat ioctl handler.
Andreas.
Signature · 3 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Hi!
Quoted 12 lines · On Mon, 28 Sep 2009 21:21:14 +0200 Andreas Schwab <[email protected]> wrote:
Quoted 5 lines · Greg KH
Quoted 1 line · Andreas Schwab
Call
compat_unimap_ioctl, notdo_unimap_ioctl.That's a nice description of what the patch does, but why do we need to do that?
It's a compat ioctl handler, so lets call the compat ioctl handler.
Andreas.
Any other reasons? Why not rename the call then? That would be a functional no-op with the same effect...
Sincerely,
Florian
p.s. maybe it is obvious if one looks at the code (i didnt), but it should be described nonetheless in the commit-log!
Signature · 1 line
A: Because it messes up the order in which people normally read text.
Quoted 3 lines
Q: Why is top-posting such a bad thing?
Quoted 2 lines
A: Top-posting.
Quoted 1 line
Q: What is the most annoying thing in e-mail?
Quoted 10 lines · Andreas Schwab
Quoted 5 lines · Greg KH
Quoted 1 line · Andreas Schwab
Call
compat_unimap_ioctl, notdo_unimap_ioctl.That's a nice description of what the patch does, but why do we need to do that?
It's a compat ioctl handler, so lets call the compat ioctl handler.
My bad, sorry.
I broke it in e9216651 evidently, thanks for debugging this.
The compat_unimap_ioctl was originally called do_unimap_ioctl in fs/compat_ioctl.h which got moved to drivers/char/vt_ioctl.c. In that patch, the caller was not updated and consequently called the native handler.
Arnd <><