Skip to contentSkip to conversation

Fix memory leaks in libxc python bindings

PATCH In review Jiri Denemark 2 participants 3 messages Sep 29, 2009 Arm/actions semi architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix memory leaks in libxc python bindings

Hi,

Reference counters are not correctly decreased for python object in several places in python bindings for libxc. Most of them are around PyList_Append(), which unlike PyList_SetItem() does increment reference counter of the object being added to a list.

tools/python/xen/lowlevel/xc/xc.c +18 -6
diff -r bd376919f03a tools/python/xen/lowlevel/xc/xc.c
@@ -387,8 +387,11 @@
     cpulist = PyList_New(0);
     for ( i = 0; cpumap != 0; i++ )
     {
-        if ( cpumap & 1 )
-            PyList_Append(cpulist, PyInt_FromLong(i));
+        if ( cpumap & 1 ) {
+            PyObject *pyint = PyInt_FromLong(i);
+            PyList_Append(cpulist, pyint);
+            Py_DECREF(pyint);
+        }
         cpumap >>= 1;
     }
     PyDict_SetItemString(info_dict, "cpumap", cpulist);
@@ -1104,22 +1107,31 @@
     {
         PyObject *cpus = PyList_New(0);
         for ( j = 0; j <= max_cpu_id; j++ )
-            if ( i == map[j])
-                PyList_Append(cpus, PyInt_FromLong(j));
+            if ( i == map[j]) {
+                PyObject *pyint = PyInt_FromLong(j);
+                PyList_Append(cpus, pyint);
+                Py_DECREF(pyint);
+            }
         PyList_Append(node_to_cpu_obj, cpus); 
+        Py_DECREF(cpus);
     }
 
     node_to_memory_obj = PyList_New(0);
 
     for ( i = 0; i < info.nr_nodes; i++ )
     {
+        PyObject *pyint;
+
         xc_availheap(self->xc_handle, 0, 0, i, &free_heap);
-        PyList_Append(node_to_memory_obj,
-                      PyInt_FromLong(free_heap / 1024));
+        pyint = PyInt_FromLong(free_heap / 1024);
+        PyList_Append(node_to_memory_obj, pyint);
+        Py_DECREF(pyint);
     }
 
     PyDict_SetItemString(ret_obj, "node_to_cpu", node_to_cpu_obj);
+    Py_DECREF(node_to_cpu_obj);
     PyDict_SetItemString(ret_obj, "node_to_memory", node_to_memory_obj);
+    Py_DECREF(node_to_memory_obj);
  
     return ret_obj;
 #undef MAX_CPU_ID

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 3 lines · Jiri Denemark

Hi,

Reference counters are not correctly decreased for python object in several

I am curious how did you find this? Is there a python 'valgrind' that can help track this? Or is there a python flag to be report such abnormalities?

#2 lore raw
Quoted 4 lines
Quoted 1 line

Reference counters are not correctly decreased for python object in several

I am curious how did you find this? Is there a python 'valgrind' that can help track this? Or is there a python flag to be report such abnormalities?

None that I know of. I just used the source code. I found it because long running xend managed by libvirt was consuming increasing amount of memory. From the only repeatedly executed command virsh list I got to xm info and xc_physinfo(). And then I just looked for all other calls to PyDict_* and PyList_Append and fixed them.

Jirka