Skip to contentSkip to conversation

TI: DaVinci: GPIO header file and definitions

PATCH Superseded s-paulraj at ti.com 4 participants 8 messages Sep 29, 2009 – Sep 30, 2009

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

From: Sandeep Paulraj <[email protected]>

Some DaVinci SOC's use GPIOs to enable EMAC and DM9000. This patch adds some definitions for GPIO registers and also adds structures for GPIO.
A separate header file is being added so that in future we can have a DaVinci GPIO driver similer to OMAP.

---
 include/asm-arm/arch-davinci/gpio_defs.h |   53 ++++++++++++++++++++++++++++++
 1 files changed, 53 insertions(+), 0 deletions(-)
 create mode 100644 include/asm-arm/arch-davinci/gpio_defs.h
include/asm-arm/arch-davinci/gpio_defs.h new file +53 -0
new file mode 100644
index 0000000..99ef896
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2009 Texas Instruments Incorporated
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+#ifndef _GPIO_DEFS_H_
+#define _GPIO_DEFS_H_
+
+#define DAVINCI_GPIO_BINTEN	0x01C67008
+#define DAVINCI_GPIO_BANK01	0x01C67010
+#define DAVINCI_GPIO_BANK23	0x01C67038
+#define DAVINCI_GPIO_BANK45	0x01C67060
+#define DAVINCI_GPIO_BANK67	0x01C67088
+
+struct davinci_gpio {
+	unsigned int	dir;
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
+	unsigned int	set_falling;
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};
+
+struct davinci_gpio_bank {
+	int num_gpio;
+	unsigned int irq_num;
+	unsigned int irq_mask;
+	unsigned long *in_use;
+	unsigned long base;
+};
+
+#endif
+
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Quoted 52 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

Some DaVinci SOC's use GPIOs to enable EMAC and DM9000. This patch adds some definitions for GPIO registers and also adds structures for GPIO.
A separate header file is being added so that in future we can have a DaVinci GPIO driver similer to OMAP.

---
 include/asm-arm/arch-davinci/gpio_defs.h |   53 ++++++++++++++++++++++++++++++
 1 files changed, 53 insertions(+), 0 deletions(-)
 create mode 100644 include/asm-arm/arch-davinci/gpio_defs.h
include/asm-arm/arch-davinci/gpio_defs.h new file +32 -0
new file mode 100644
index 0000000..99ef896
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2009 Texas Instruments Incorporated
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+#ifndef _GPIO_DEFS_H_
+#define _GPIO_DEFS_H_
+
+#define DAVINCI_GPIO_BINTEN	0x01C67008
+#define DAVINCI_GPIO_BANK01	0x01C67010
+#define DAVINCI_GPIO_BANK23	0x01C67038
+#define DAVINCI_GPIO_BANK45	0x01C67060
+#define DAVINCI_GPIO_BANK67	0x01C67088
+
+struct davinci_gpio {
+	unsigned int	dir;

include/asm-arm/arch-davinci/gpio_defs.h line 42

Quoted 10 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +10 -0
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
+	unsigned int	set_falling;
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};

Convert the tabs to spaces in the in the whitespace between type and elemement names
unsigned int dir; -> unsigned int dir;
For all of the elements

Tom

Quoted 11 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +11 -0
+
+struct davinci_gpio_bank {
+	int num_gpio;
+	unsigned int irq_num;
+	unsigned int irq_mask;
+	unsigned long *in_use;
+	unsigned long base;
+};
+
+#endif
+
#2 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Dear Tom,

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 10 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +9 -0
+struct davinci_gpio {
+	unsigned int	dir;
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
+	unsigned int	set_falling;
Quoted 8 lines

include/asm-arm/arch-davinci/gpio_defs.h line 42

Quoted 3 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +3 -0
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};

Convert the tabs to spaces in the in the whitespace between type and elemement names
unsigned int dir; -> unsigned int dir;
For all of the elements

Why? It is not really important here, but especially when mixing data types, TABs are preferred, as they will allow for nice vertical alignment.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price of curiosity is a terminal experience.
                         - Terry Pratchett, _The Dark Side of the Sun_
#3 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Quoted 20 lines · Wolfgang Denk

Dear Tom,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 8 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +8 -0
+struct davinci_gpio {
+	unsigned int	dir;
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
Quoted 8 lines

include/asm-arm/arch-davinci/gpio_defs.h line 42

Quoted 4 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +4 -0
+	unsigned int	set_falling;
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};

Convert the tabs to spaces in the in the whitespace between type and elemement names
unsigned int dir; -> unsigned int dir;
For all of the elements

Quoted 4 lines

Why? It is not really important here, but especially when mixing data types, TABs are preferred, as they will allow for nice vertical alignment.

OK. TABs are preferred.

The structure defined below it used a single space. When looked at together, it seemed to me to be inconsistent.

Tom

Quoted 4 lines

Best regards,

Wolfgang Denk

#4 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Quoted 28 lines
Quoted 20 lines · Wolfgang Denk

Dear Tom,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 8 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +8 -0
+struct davinci_gpio {
+	unsigned int	dir;
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
Quoted 8 lines

include/asm-arm/arch-davinci/gpio_defs.h line 42

Quoted 4 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +4 -0
+	unsigned int	set_falling;
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};

Convert the tabs to spaces in the in the whitespace between type and elemement names
unsigned int dir; -> unsigned int dir;
For all of the elements

Quoted 4 lines

Why? It is not really important here, but especially when mixing data types, TABs are preferred, as they will allow for nice vertical alignment.

Quoted 6 lines

OK. TABs are preferred.

The structure defined below it used a single space. When looked at together, it seemed to me to be inconsistent.

Tom

What do about this patch. You ACK'ed it
Do you want me to revert to the original patch ?

Quoted 6 lines
Quoted 5 lines

Best regards,

Wolfgang Denk

#5 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Dear "Paulraj, Sandeep",

Quoted 5 lines · In message <[email protected]> you…
Quoted 5 lines
Quoted 4 lines

Why? It is not really important here, but especially when mixing data types, TABs are preferred, as they will allow for nice vertical alignment.

Quoted 8 lines
Quoted 6 lines

OK. TABs are preferred.

The structure defined below it used a single space. When looked at together, it seemed to me to be inconsistent.

Tom

What do about this patch. You ACK'ed it
Do you want me to revert to the original patch ?

No. Please leave as is. The difference really is not important here.

I just did not understand why the change was requested in the first place, but now it has been done, we should not throw even more efforts on it.

Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Pull the wool over your own eyes!"                - J.R. "Bob" Dobbs
#6 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

In reply to Paulraj
Quoted 24 lines · Sandeep
Quoted 24 lines
Quoted 23 lines · Wolfgang Denk

Dear Tom,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 8 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +8 -0
+struct davinci_gpio {
+	unsigned int	dir;
+	unsigned int	out_data;
+	unsigned int	set_data;
+	unsigned int	clr_data;
+	unsigned int	in_data;
+	unsigned int	set_rising;
+	unsigned int	clr_rising;
Quoted 8 lines

include/asm-arm/arch-davinci/gpio_defs.h line 42

Quoted 4 lines
include/asm-arm/arch-davinci/gpio_defs.h new file +4 -0
+	unsigned int	set_falling;
+	unsigned int	clr_falling;
+	unsigned int	intstat;
+};

Convert the tabs to spaces in the in the whitespace between type and elemement names
unsigned int dir; -> unsigned int dir;
For all of the elements

Why? It is not really important here, but especially when mixing data types, TABs are preferred, as they will allow for nice vertical alignment.

Quoted 8 lines
Quoted 6 lines

OK. TABs are preferred.

The structure defined below it used a single space. When looked at together, it seemed to me to be inconsistent.

Tom

What do about this patch. You ACK'ed it
Do you want me to revert to the original patch ?

I will defer to Wolfgang on this.
Since I caused the problem, I will fix it.
Tom

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

Best regards,

Wolfgang Denk

#7 lore raw

PATCH 1/1 TI: DaVinci: GPIO header file and definitions

Dear Tom,

Quoted 3 lines · In message <[email protected]> you wrote:

I will defer to Wolfgang on this.
Since I caused the problem, I will fix it.

It's not a problem. I just wanted to make sure we are not too narrow with our rules.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Power is danger.
	-- The Centurion, "Balance of Terror", stardate 1709.2