Skip to contentSkip to conversation

b43: Don't use struct wldev after detach.

PATCH New Michael Buesch 1 participant 1 message Oct 1, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: Don't use struct wldev after detach.

Don't use struct wldev after detach. This fixes an oops on access.

---
 drivers/net/wireless/b43/leds.c |    4 ++--
 drivers/net/wireless/b43/leds.h |    4 ++--
 drivers/net/wireless/b43/main.c |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/b43/leds.c +2 -2
@@ -348,9 +348,9 @@ void b43_leds_register(struct b43_wldev 
 	}
 }
 
-void b43_leds_unregister(struct b43_wldev *dev)
+void b43_leds_unregister(struct b43_wl *wl)
 {
-	struct b43_leds *leds = &dev->wl->leds;
+	struct b43_leds *leds = &wl->leds;
 
 	b43_unregister_led(&leds->led_tx);
 	b43_unregister_led(&leds->led_rx);
drivers/net/wireless/b43/leds.h +2 -2
@@ -60,7 +60,7 @@ enum b43_led_behaviour {
 };
 
 void b43_leds_register(struct b43_wldev *dev);
-void b43_leds_unregister(struct b43_wldev *dev);
+void b43_leds_unregister(struct b43_wl *wl);
 void b43_leds_init(struct b43_wldev *dev);
 void b43_leds_exit(struct b43_wldev *dev);
 void b43_leds_stop(struct b43_wldev *dev);
@@ -76,7 +76,7 @@ struct b43_leds {
 static inline void b43_leds_register(struct b43_wldev *dev)
 {
 }
-static inline void b43_leds_unregister(struct b43_wldev *dev)
+static inline void b43_leds_unregister(struct b43_wl *wl)
 {
 }
 static inline void b43_leds_init(struct b43_wldev *dev)
drivers/net/wireless/b43/main.c +1 -1
@@ -4997,7 +4997,7 @@ static void b43_remove(struct ssb_device
 
 	if (list_empty(&wl->devlist)) {
 		b43_rng_exit(wl);
-		b43_leds_unregister(wldev);
+		b43_leds_unregister(wl);
 		/* Last core on the chip unregistered.
 		 * We can destroy common struct b43_wl.
 		 */
Signature · 1 line
Greetings, Michael.