ACPI: EC: Restart command even if no interrupts from EC

PATCH Applied Alexey Starikovskiy 2 participants 2 messages Oct 1, 2009 – Oct 2, 2009 ACPI

Share & tools

Alexey Starikovskiy

author

2009-10-01 22:53 UTC #0 lore raw

PATCH 1/1 ACPI: EC: Restart command even if no interrupts from EC

EC may forget a command without sending any "reset" interrupt, thus we need to lessen the requirement for transaction restart.

Reference: http://bugzilla.kernel.org/show_bug.cgi?id=14247

Signed-off-by Alexey Starikovskiy <[email protected]>

---

 drivers/acpi/ec.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

drivers/acpi/ec.c +1 -3

index da7da37..9c34515 100644
@@ -234,10 +234,8 @@ static int ec_poll(struct acpi_ec *ec)
 			}
 			advance_transaction(ec, acpi_ec_read_status(ec));
 		} while (time_before(jiffies, delay));
-		if (!ec->curr->irq_count ||
-		    (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF))
+		if (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF)
 			break;
-		/* try restart command if we get any false interrupts */
 		pr_debug(PREFIX "controller reset, restart transaction\n");
 		spin_lock_irqsave(&ec->curr_lock, flags);
 		start_transaction(ec);

Len Brown

reviewer Applied

2009-10-02 14:00 UTC #1 lore raw

applied

thanks,
Len Brown, Intel Open Source Technology Center