Skip to contentSkip to conversation

Soc: wm8940: Fix check on error code form snd_soc_codec_set_cache_io

PATCH Applied Jonathan Cameron 2 participants 2 messages Oct 2, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Soc: wm8940: Fix check on error code form snd_soc_codec_set_cache_io

Soc: wm8940: Fix check on error code form snd_soc_codec_set_cache_io

Fix for typo in commit 8d50e447d19fec64adebeef55f2b60d695435412
ASoC: Factor out I/O for Wolfson 8 bit data 16 bit register CODECs

---

 sound/soc/codecs/wm8940.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8940.c +1 -1
index da97aae..1ef2454 100644
@@ -790,7 +790,7 @@ static int wm8940_register(struct wm8940_priv *wm8940,
 	codec->reg_cache = &wm8940->reg_cache;
 
 	ret = snd_soc_codec_set_cache_io(codec, 8, 16, control);
-	if (ret == 0) {
+	if (ret < 0) {
 		dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
 		return ret;
 	}
Signature · 1 line
1.6.3.3
Applied
#1 lore raw
Quoted 2 lines · Jonathan Cameron

Soc: wm8940: Fix check on error code form snd_soc_codec_set_cache_io

Applied, thanks.

Please don't duplicate the first line of the commit message into the message body like this, it means the commit message needs to be manually mangled after applying.

Quoted 32 lines

Fix for typo in commit 8d50e447d19fec64adebeef55f2b60d695435412
ASoC: Factor out I/O for Wolfson 8 bit data 16 bit register CODECs

---

 sound/soc/codecs/wm8940.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8940.c +1 -1
index da97aae..1ef2454 100644
@@ -790,7 +790,7 @@ static int wm8940_register(struct wm8940_priv *wm8940,
 	codec->reg_cache = &wm8940->reg_cache;
 
 	ret = snd_soc_codec_set_cache_io(codec, 8, 16, control);
-	if (ret == 0) {
+	if (ret < 0) {
 		dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
 		return ret;
 	}
Signature · 6 lines
1.6.3.3

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Signature · 1 line
"You grabbed my hand and we fell into it, like a daydream - or a fever."