staging: comedi: cleanup formating in drivers/8255.c
PATCH 2/2 staging: comedi: cleanup formating in drivers/8255.c
Fix the formatting in this driver to conform to the standard. Move EXPORT_SYMBOL to under the exported funtion, and add KERN_INFO to some diagnostic printks.
Signed-off-by Bruce Jones <[email protected]>
--- drivers/staging/comedi/drivers/8255.c | 21 ++++++++++----------- 1 files changed, 10 insertions(+), 11 deletions(-)
drivers/staging/comedi/drivers/8255.c +10 -11
@@ -132,6 +132,7 @@ void subdev_8255_interrupt(struct comedi_device *dev,comedi_event (dev, s); } +EXPORT_SYMBOL (subdev_8255_interrupt);static int subdev_8255_cb (int dir,int port,int data,unsigned long arg) {
@@ -345,6 +346,7 @@ int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,return 0 ; } +EXPORT_SYMBOL (subdev_8255_init); int subdev_8255_init_irq(struct comedi_device *dev, struct comedi_subdevice *s, int (*cb) (int, int, int, unsigned long),
@@ -364,6 +366,7 @@ int subdev_8255_init_irq(struct comedi_device *dev, struct comedi_subdevice *s,return 0 ; } +EXPORT_SYMBOL (subdev_8255_init_irq);void subdev_8255_cleanup (struct comedi_device *dev,struct comedi_subdevice *s) {
@@ -376,6 +379,7 @@ void subdev_8255_cleanup(struct comedi_device *dev, struct comedi_subdevice *s)kfree (s->private); } } +EXPORT_SYMBOL (subdev_8255_cleanup);/*
@@ -390,7 +394,7 @@ static int dev_8255_attach(struct comedi_device *dev,unsigned long iobase;int i; -printk ("comedi%d: 8255:" , dev->minor); +printk (KERN_INFO "comedi%d: 8255:" , dev->minor); dev->board_name ="8255" ;
@@ -400,7 +404,7 @@ static int dev_8255_attach(struct comedi_device *dev,break ; }if (i ==0 ) { -printk (" no devices specified\n" ); +printk (KERN_INFO " no devices specified\n" );return -EINVAL ; }
@@ -411,9 +415,9 @@ static int dev_8255_attach(struct comedi_device *dev,for (i =0 ; i < dev->n_subdevices; i++) { iobase = it->options[i]; -printk (" 0x%04lx" , iobase); +printk (KERN_INFO " 0x%04lx" , iobase);if (!request_region (iobase, _8255_SIZE,"8255" )) { -printk (" (I/O port conflict)" ); +printk (KERN_INFO " (I/O port conflict)" ); dev->subdevices[i].type =COMEDI_SUBD_UNUSED ; }else {
@@ -422,7 +426,7 @@ static int dev_8255_attach(struct comedi_device *dev, } } -printk ("\n" ); +printk (KERN_INFO "\n" );return 0 ; }
@@ -433,7 +437,7 @@ static int dev_8255_detach(struct comedi_device *dev)unsigned long iobase;struct comedi_subdevice *s; -printk ("comedi%d: 8255: remove\n" , dev->minor); +printk (KERN_INFO "comedi%d: 8255: remove\n" , dev->minor);for (i =0 ; i < dev->n_subdevices; i++) { s = dev->subdevices + i;
@@ -446,8 +450,3 @@ static int dev_8255_detach(struct comedi_device *dev)return 0 ; } - -EXPORT_SYMBOL (subdev_8255_init); -EXPORT_SYMBOL (subdev_8255_init_irq); -EXPORT_SYMBOL (subdev_8255_cleanup); -EXPORT_SYMBOL (subdev_8255_interrupt);
Quoted 3 lines · Bruce Jones
Fix the formatting in this driver to conform to the standard. Move
EXPORT_SYMBOLto under the exported funtion, and addKERN_INFOto some diagnostic printks.
Same rejection problem here, someone beat you to it.
sorry,
greg k-h