staging: comedi: CodingStyle cleanup for drivers/acl722b.c
PATCH 1/1 staging: comedi: CodingStyle cleanup for drivers/acl722b.c
Cleanup this file as per the coding style. Adding KERN_INFO to the printks.
Signed-off-by Bruce Jones <[email protected]>
--- drivers/staging/comedi/drivers/acl7225b.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/acl7225b.c +3 -3
@@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev, iobase = it->options[0 ]; iorange = this_board->io_range; -printk ("comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, +printk (KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, this_board->name, iobase);if (!request_region (iobase, iorange,"acl7225b" )) {printk ("I/O port conflict\n" );
@@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev, s->range_table = &range_digital; s->private = (void *)ACL7225_DI_LO ; -printk ("\n" ); +printk (KERN_INFO "\n" );return 0 ; }static int acl7225b_detach (struct comedi_device *dev) { -printk ("comedi%d: acl7225b: remove\n" , dev->minor); +printk (KERN_INFO "comedi%d: acl7225b: remove\n" , dev->minor);if (dev->iobase)release_region (dev->iobase, this_board->io_range);
Signature · 1 line
1.6.5.rc2
Quoted 22 lines · Bruce Jones
Cleanup this file as per the coding style. Adding
KERN_INFOto the printks.Signed-off-by Bruce Jones <[email protected]>--- drivers/staging/comedi/drivers/acl7225b.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/staging/comedi/drivers/acl7225b.c +1
-1@@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev, iobase = it->options[0 ]; iorange = this_board->io_range; -printk ("comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, +printk (KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, this_board->name, iobase);if (!request_region (iobase, iorange,"acl7225b" )) {printk ("I/O port conflict\n" );
drivers/staging/comedi/drivers/acl7225b.c static int acl7225b_attach(struct comedi_device *dev, · line 140
Quoted 5 lines
drivers/staging/comedi/drivers/acl7225b.c +1
-1@@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev, s->range_table = &range_digital; s->private = (void *)ACL7225_DI_LO ; -printk ("\n" ); +printk (KERN_INFO "\n" );
This one change isn't needed, the \n has to be sent as the earlier printk didn't terminate the line. I applied it without this change, so no worries.
thanks,
greg k-h
Quoted 22 lines · Bruce Jones
Cleanup this file as per the coding style. Adding
KERN_INFOto the printks.Signed-off-by Bruce Jones <[email protected]>--- drivers/staging/comedi/drivers/acl7225b.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/staging/comedi/drivers/acl7225b.c +1
-1@@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev, iobase = it->options[0 ]; iorange = this_board->io_range; -printk ("comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, +printk (KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x " , dev->minor, this_board->name, iobase);if (!request_region (iobase, iorange,"acl7225b" )) {printk ("I/O port conflict\n" );
drivers/staging/comedi/drivers/acl7225b.c static int acl7225b_attach(struct comedi_device *dev, · line 140
Quoted 5 lines
drivers/staging/comedi/drivers/acl7225b.c +1
-1@@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev, s->range_table = &range_digital; s->private = (void *)ACL7225_DI_LO ; -printk ("\n" ); +printk (KERN_INFO "\n" );
Oh nevermind, I took your later patch, sorry for the confusion.
greg k-h