net: Fix problem with 405EZ ethernet interrupt
PATCH 1/1 net: Fix problem with 405EZ ethernet interrupt
From: James Clough <[email protected]>
On 405EZ the RX-/TX-interrupts are coalesced into one IRQ bit in the UIC. We need to acknowledge the RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well.
This problem was introduced with commitd1631fe1 [ppc4xx: Consolidate PPC4xx UIC defines]
--- drivers/net/4xx_enet.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/net/4xx_enet.c +9 -0
@@ -1717,6 +1717,15 @@ int enetInt (struct eth_device *dev) rc =0 ; } } +#if defined(CONFIG_405EZ ) +/* +* On 405EZ the RX-/TX-interrupts are coalesced into +* one IRQ bit in the UIC. We need to acknowledge the +* RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well. +*/ +mtsdr (SDR0_ICINTSTAT , +SDR_ICRX_STAT |SDR_ICTX0_STAT |SDR_ICTX1_STAT ); +#endif /* defined(CONFIG_405EZ) */ }while (serviced);return (rc);
Signature · 1 line
1.6.4.1
Ben Warren
AppliedPATCH 1/1 net: Fix problem with 405EZ ethernet interrupt
Quoted 26 lines · Stefan Roese
From: James Clough <[email protected]>
On 405EZ the RX-/TX-interrupts are coalesced into one IRQ bit in the UIC. We need to acknowledge the RX-/TX-interrupts in the
SDR0_ICINTSTATreg as well.This problem was introduced with commit
d1631fe1[ppc4xx: Consolidate PPC4xx UIC defines]Signed-off-by James Clough <[email protected]>Signed-off-by Stefan Roese <[email protected]>--- drivers/net/4xx_enet.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)drivers/net/4xx_enet.c +2
-0@@ -1717,6 +1717,15 @@ int enetInt (struct eth_device *dev) rc =0 ; } } +#if defined(CONFIG_405EZ ) +/*
drivers/net/4xx_enet.c int enetInt (struct eth_device *dev) · line 1731
Quoted 10 lines
drivers/net/4xx_enet.c +7
-0+* On 405EZ the RX-/TX-interrupts are coalesced into +* one IRQ bit in the UIC. We need to acknowledge the +* RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well. +*/ +mtsdr (SDR0_ICINTSTAT , +SDR_ICRX_STAT |SDR_ICTX0_STAT |SDR_ICTX1_STAT ); +#endif /* defined(CONFIG_405EZ) */ }while (serviced);return (rc);
Applied to net repo.
thanks,
Ben
PATCH 1/1 net: Fix problem with 405EZ ethernet interrupt
Dear Ben Warren,
Quoted 1 line · In message <[email protected]> you wrote:
...
Quoted 1 line
Applied to net repo.
Do you intend to send a pull request any time soon?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Quote from a recent meeting: "We are going to continue having these meetings everyday until I find out why no work is getting done."
PATCH 1/1 net: Fix problem with 405EZ ethernet interrupt
Quoted 9 lines · Wolfgang Denk
Dear Ben Warren,
Quoted 1 line · In message <[email protected]> you wrote:
...
Quoted 1 line
Applied to net repo.
Do you intend to send a pull request any time soon?
Quoted 7 lines
Yes I do. Very soon.
Best regards,
Wolfgang Denk
regards,
Ben