be2net: Bug fix to properly update ethtool tx-checksumming after ethtool -K <ifname> tx off
Subsystems (2)
PATCH 3/3 be2net: Bug fix to properly update ethtool tx-checksumming after ethtool -K <ifname> tx off
This is a fix for a bug which was a result of wrong use of checksum offload flag. The status of tx-checksumming was not changed from on to off
after a 'ethtool -K <ifname> tx off' operation.
Use the proper checksum offload flag NETIF_F_HW_CSUM instead of NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM.
Patch is against net-2.6 tree.
--- drivers/net/benet/be_ethtool.c | 2 +- drivers/net/benet/be_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/benet/be_ethtool.c +1 -1
@@ -358,7 +358,7 @@ const struct ethtool_ops be_ethtool_ops = { .get_rx_csum = be_get_rx_csum, .set_rx_csum = be_set_rx_csum, .get_tx_csum = ethtool_op_get_tx_csum, - .set_tx_csum = ethtool_op_set_tx_csum, + .set_tx_csum = ethtool_op_set_tx_hw_csum, .get_sg = ethtool_op_get_sg, .set_sg = ethtool_op_set_sg, .get_tso = ethtool_op_get_tso,
drivers/net/benet/be_main.c +2 -2
@@ -1899,8 +1899,8 @@ static void be_netdev_init(struct net_device *netdev)struct be_adapter *adapter =netdev_priv (netdev); netdev->features |=NETIF_F_SG |NETIF_F_HW_VLAN_RX |NETIF_F_TSO | -NETIF_F_HW_VLAN_TX |NETIF_F_HW_VLAN_FILTER |NETIF_F_IP_CSUM | -NETIF_F_IPV6_CSUM |NETIF_F_GRO ; +NETIF_F_HW_VLAN_TX |NETIF_F_HW_VLAN_FILTER |NETIF_F_HW_CSUM | +NETIF_F_GRO ; netdev->flags |=IFF_MULTICAST ;
Signature · 1 line
1.6.0.4
From: Ajit Khaparde <[email protected]>
Date: Mon, 5 Oct 2009 17:52:19 +0530
Quoted 8 lines
This is a fix for a bug which was a result of wrong use of checksum offload flag. The status of tx-checksumming was not changed from on to off
after a 'ethtool -K <ifname> tx off' operation.
Use the proper checksum offload flagNETIF_F_HW_CSUMinstead ofNETIF_F_IP_CSUMandNETIF_F_IPV6_CSUM.
Patch is against net-2.6 tree.Signed-off-by Ajit Khaparde <[email protected]>
Applied.