Skip to contentSkip to conversation

asus_atk0110: refactor and support for new

PATCH In review Luca Tettamanti 2 participants 3 messages Oct 6, 2009

lore
Share & tools
lore
#0 lore raw

cover asus_atk0110: refactor and support for new

Hello Jean,
I'm sending two patches for asus_atk0110:
- the first one is mostly refactoring to allow easier extension of the driver; it also extends GITM to handle buffers larger than 8 bytes.
- the second one add support for enabling/disabling EC

Luca

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Re: [lm-sensors] [PATCH 0/2] asus_atk0110: refactor and support for

Hi Luca,

Quoted 5 lines · Luca Tettamanti

Hello Jean,
I'm sending two patches for asus_atk0110:
- the first one is mostly refactoring to allow easier extension of the driver; it also extends GITM to handle buffers larger than 8 bytes.
- the second one add support for enabling/disabling EC

I've applied both patches. Should I delay them until kernel 2.6.33, or is it desirable (and safe) to have them in kernel 2.6.32?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

Re: [lm-sensors] [PATCH 0/2] asus_atk0110: refactor and support for

In reply to Luca Tettamanti
Quoted 11 lines · Jean Delvare

Hi Luca,

Quoted 5 lines · Luca Tettamanti

Hello Jean,
I'm sending two patches for asus_atk0110:
- the first one is mostly refactoring to allow easier extension of the driver;   it also extends GITM to handle buffers larger than 8 bytes.
- the second one add support for enabling/disabling EC

I've applied both patches. Should I delay them until kernel 2.6.33, or is it desirable (and safe) to have them in kernel 2.6.32?

The driver as-is loads fine on newer board but spams the log with failure messages (fixed by the first patch).
The patch that might cause problem is the second one (I've kept the patch separated and bisectable for this reason); however without that patch users with new boards won't get updated readings.
So I'd say that it's desirable to have both of them in 2.6.32.

Luca

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors