Changes to integrate RAR with SEP and fix RAR problems
PATCH 1/1 Changes to integrate RAR with SEP and fix RAR problems
SEP stands for Security Processor; a dedicated processor that does encryption, decryption, key management, and secure storage.
RAR stands for Restricted Access Region; this is memory aboard the MID platform that is restricted (via hardware) from access by software running on the x86 processor. Dedicated 'smart' peripherals such as sound, video, and encryption can access these regions of memory. They are here to help protect copyrighted midia from being illegally copied.
This is upstream revision 4 of the RAR driver.
This is a patch referenced from the linux-next repository as pulled on October 6, 2009; from the following URL:
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
This is a modified RAR driver to include integration with the SEP driver
Plese be aware that the SEP driver requires this driver in order to compile and run. There are API function calls within this driver that are required by the SEP driver.
Other drivers being developed in the future will also require this driver.
Date: October 06, 2009
drivers/staging/Kconfig | 2 +- drivers/staging/Makefile | 2 +- drivers/staging/rar/Kconfig | 17 - drivers/staging/rar/Makefile | 2 - drivers/staging/rar/rar_driver.c | 444 --- drivers/staging/rar/rar_driver.h | 99 - drivers/staging/rar_register/Kconfig | 15 + drivers/staging/rar_register/Makefile | 3 + drivers/staging/rar_register/rar_register.c | 661 +++++ include/linux/rar/memrar.h | 172 ++ include/linux/rar/rar_register.h | 79 + delete mode 100644 drivers/staging/rar/Kconfig delete mode 100644 drivers/staging/rar/Makefile delete mode 100644 drivers/staging/rar/rar_driver.c delete mode 100644 drivers/staging/rar/rar_driver.h create mode 100644 drivers/staging/rar_register/Kconfig create mode 100644 drivers/staging/rar_register/Makefile create mode 100644 drivers/staging/rar_register/rar_register.c create mode 100644 include/linux/rar/memrar.h create mode 100644 include/linux/rar/rar_register.h
drivers/staging/Kconfig +1 -1
@@ -121,7 +121,7 @@ source "drivers/staging/hv/Kconfig" source "drivers/staging/vme/Kconfig" -source "drivers/staging/rar/Kconfig" +source "drivers/staging/rar_register/Kconfig" source "drivers/staging/sep/Kconfig"
drivers/staging/Makefile +1 -1
@@ -42,7 +42,7 @@ obj-$(CONFIG_VT6656) += vt6656/ obj-$(CONFIG_FB_UDL) += udlfb/ obj-$(CONFIG_HYPERV) += hv/ obj-$(CONFIG_VME_BUS) += vme/ -obj-$(CONFIG_RAR_REGISTER) += rar/ +obj-$(CONFIG_RAR_REGISTER) += rar_register/ obj-$(CONFIG_DX_SEP) += sep/ obj-$(CONFIG_IIO) += iio/ obj-$(CONFIG_COWLOOP) += cowloop/
drivers/staging/rar/Kconfig deleted +0 -17
@@ -1,17 +0,0 @@ -# -# RAR device configuration -# - -menu "RAR Register Driver" -# -# Restricted Access Register Manager -# -config RAR_REGISTER - tristate "Restricted Access Region Register Driver" - default n - ---help--- - This driver allows other kernel drivers access to the - contents of the restricted access region control - registers. - -endmenu
drivers/staging/rar/Makefile deleted +0 -2
@@ -1,2 +0,0 @@ -EXTRA_CFLAGS += -DLITTLE__ENDIAN -obj-$(CONFIG_RAR_REGISTER) += rar_driver.o
drivers/staging/rar/rar_driver.c deleted +0 -444
444 lines not on this page · raw message
drivers/staging/rar/rar_driver.h deleted +0 -99
99 lines not on this page · raw message
drivers/staging/rar_register/Kconfig new file +15 -0
@@ -0,0 +1,15 @@ +# +# Serial device configuration +# + +menu "RAR Register Driver" + +config RAR_REGISTER + tristate "Intel Restricted Access Region Register Driver" + depends on X86_MRST + default n + ---help--- + This driver allows other kernel drivers access to the + contents of the restricted access region registers. + +endmenu
drivers/staging/rar_register/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +EXTRA_CFLAGS += -DLITTLE__ENDIAN +obj-$(CONFIG_RAR_REGISTER) += rar_register.o +rar_register_driver-objs := rar_register.o
drivers/staging/rar_register/rar_register.c new file +661 -0
661 lines not on this page · raw message
include/linux/rar/memrar.h new file +172 -0
172 lines not on this page · raw message
include/linux/rar/rar_register.h new file +79 -0
79 lines not on this page · raw message
Signature · 1 line
1.6.0.6
Quoted 10 lines · Mark Allyn
SEP stands for Security Processor; a dedicated processor that does encryption, decryption, key management, and secure storage.
RAR stands for Restricted Access Region; this is memory aboard the MID platform that is restricted (via hardware) from access by software running on the x86 processor. Dedicated 'smart' peripherals such as sound, video, and encryption can access these regions of memory. They are here to help protect copyrighted midia from being illegally copied.
How does it allow "fair-use" copying? To prevent that is considered illegal in some juristictions :)
Quoted 4 lines
This is upstream revision 4 of the RAR driver.
This is a patch referenced from the linux-next repository as pulled on October 6, 2009; from the following URL:
Why are you deleting the existing driver entirely? Why not just patch it to have whatever new things you need here?
Quoted 11 lines
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.gitThis is a modified RAR driver to include integration with the SEP driver
Plese be aware that the SEP driver requires this driver in order to compile and run. There are API function calls within this driver that are required by the SEP driver.
Other drivers being developed in the future will also require this driver.
What drivers? In what way will it be required?
Your patch contains a number of obvious problems that scripts/checkpatch.pl would have caught. Please run it through that before submitting it again.
I'll not take this version for the above reasons.
thanks,
greg k-h
drivers/staging/Kconfig source "drivers/staging/hv/Kconfig" · line 124
Quoted 6 lines
drivers/staging/Kconfig +1
-1@@ -121,7 +121,7 @@ source "drivers/staging/hv/Kconfig" source "drivers/staging/vme/Kconfig" -source "drivers/staging/rar/Kconfig" +source "drivers/staging/rar_register/Kconfig"
Its impossible to compare changes in diffs if you move them around and then diff them. Please don't do that. Produce the diffs using the same directory - it can move anyway when the thing comes out of staging
If you must move something then do the move and the changes as two separate patches so it is clear. You do seem to have also done things like reformatted the code, or worked off an old tree not the kernel one for the changes which isn't helpful.