Skip to contentSkip to conversation

PPC4xx: Denali core: Fix incorrect DDR row bits

PATCH New Mike Nuss 2 participants 2 messages Oct 5, 2009 – Oct 7, 2009

lore
Share & tools
lore

Mike Nuss

author
#0 lore raw

PATCH 1/1 PPC4xx: Denali core: Fix incorrect DDR row bits

The SPD detection code for the Denali memory controller used on some ppc4xx
processors incorrectly encodes DDR0_42. With certain memory configurations,
this can cause the bootwrapper to incorrectly calculate the installed memory
size, because the number of row bits is wrong. This patch fixes that encoding.

cpu/ppc4xx/denali_spd_ddr2.c +1 -1
index 4705e21..5858cb3 100644
@@ -1159,7 +1159,7 @@ phys_size_t initdram(int board_type)
 
 	mtsdram(DDR0_31, DDR0_31_XOR_CHECK_BITS_ENCODE(0x0000));
 
-	mtsdram(DDR0_42, DDR0_42_ADDR_PINS_DECODE(14 - rows) |
+	mtsdram(DDR0_42, DDR0_42_ADDR_PINS_ENCODE(14 - rows) |
 		DDR0_42_CASLAT_LIN_GATE_ENCODE(2 * cas_latency));
 
 	program_ddr0_43(dimm_ranks, iic0_dimm_addr, num_dimm_banks,

sdram_freq,

#1 lore raw

PATCH 1/1 PPC4xx: Denali core: Fix incorrect DDR row bits

Quoted 8 lines · On Monday 05 October 2009 18:33:28 Mike Nuss wrote:

The SPD detection code for the Denali memory controller used on some ppc4xx
processors incorrectly encodes DDR0_42. With certain memory configurations,
this can cause the bootwrapper to incorrectly calculate the installed memory
size, because the number of row bits is wrong. This patch fixes that encoding.

Applied to u-boot-ppc4xx. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de