Skip to contentSkip to conversation

Samsung Backlight Patch

PATCH Mike Lothian 3 participants 10 messages Oct 7, 2009 – Oct 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

Regards

Mike

drivers/platform/x86/Kconfig +12 -0
index 77c6097..6810625 100644
@@ -425,4 +425,16 @@ config ACPI_TOSHIBA
 
 	  If you have a legacy free Toshiba laptop (such as the Libretto L1
 	  series), say Y.
+
+config SAMSUNG_LAPTOP
+        tristate "Samsung Laptop driver"
+        depends on BACKLIGHT_CLASS_DEVICE
+        depends on DMI
+        ---help---
+          This driver adds support to control the backlight on a number of
+          Samsung laptops, like the N130, and control for some of the LEDs
+
+          It will only be loaded on laptops that properly need it, so it is
+          safe to say Y here.
+
 endif # X86_PLATFORM_DEVICES
drivers/platform/x86/Makefile +1 -0
index 641b8bf..8ccfadc 100644
@@ -20,3 +20,4 @@ obj-$(CONFIG_INTEL_MENLOW)	+= intel_menlow.o
 obj-$(CONFIG_ACPI_WMI)		+= wmi.o
 obj-$(CONFIG_ACPI_ASUS)		+= asus_acpi.o
 obj-$(CONFIG_ACPI_TOSHIBA)	+= toshiba_acpi.o
+obj-$(CONFIG_SAMSUNG_LAPTOP)    += samsung-laptop.o
drivers/platform/x86/samsung-laptop.c new file +420 -0

420 lines not on this page · raw message

#1 lore raw
Quoted 6 lines · Mike Lothian

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

greg k-h

#2 lore raw

2009/10/7 Greg KH <[email protected]>:

Quoted 8 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

Quoted 9 lines

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

greg k-h

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

Who should sign it off?

I think there's a few other models that can be added to this patch too

Regards

Mike

#3 lore raw
Quoted 16 lines · Mike Lothian

2009/10/7 Greg KH <[email protected]>:

Quoted 15 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

Quoted 7 lines
Quoted 2 lines

greg k-h

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
From: Greg Kroah-Hartman <[email protected]>

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain. Someone needs to sign off on it...

Quoted 1 line

I think there's a few other models that can be added to this patch too

I do too.

Note, if you look at the git tree I have for the driver, it is totally rewritten to not use a structure, and instead, use offsets properly. But it removed support for your laptop, which is not what you probably want :(

thanks,

greg k-h

#4 lore raw

2009/10/7 Greg KH <[email protected]>:

Quoted 39 lines · Mike Lothian
Quoted 16 lines

2009/10/7 Greg KH <[email protected]>:

Quoted 15 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

Quoted 7 lines
Quoted 2 lines

greg k-h

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
       From: Greg Kroah-Hartman <[email protected]>

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain.  Someone needs to sign off on it...

Quoted 1 line

I think there's a few other models that can be added to this patch too

I do too.

Quoted 9 lines

Note, if you look at the git tree I have for the driver, it is totally rewritten to not use a structure, and instead, use offsets properly. But it removed support for your laptop, which is not what you probably want :(

thanks,

greg k-h

What git tree?

#5 lore raw
Quoted 45 lines · Mike Lothian

2009/10/7 Greg KH <[email protected]>:

Quoted 44 lines · Mike Lothian
Quoted 16 lines

2009/10/7 Greg KH <[email protected]>:

Quoted 15 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

Quoted 7 lines
Quoted 2 lines

greg k-h

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
       From: Greg Kroah-Hartman <[email protected]>

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain.  Someone needs to sign off on it...

Quoted 1 line

I think there's a few other models that can be added to this patch too

I do too.

Note, if you look at the git tree I have for the driver, it is totally rewritten to not use a structure, and instead, use offsets properly. But it removed support for your laptop, which is not what you probably want :(

Quoted 6 lines
Quoted 4 lines

thanks,

greg k-h

What git tree?

http://github.com/gregkh/samsung-backlight

Look at the "laptop" branch for the latest stuff.

Also supports rfkill and "silent" mode for the N130/N128 machines.

thanks,

greg k-h

#6 lore raw

2009/10/8 Greg KH <[email protected]>:

Quoted 55 lines · Mike Lothian
Quoted 45 lines

2009/10/7 Greg KH <[email protected]>:

Quoted 44 lines · Mike Lothian
Quoted 16 lines

2009/10/7 Greg KH <[email protected]>:

Quoted 15 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

thanks,

Quoted 7 lines
Quoted 2 lines

greg k-h

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
       From: Greg Kroah-Hartman <[email protected]>

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain.  Someone needs to sign off on it...

Quoted 1 line

I think there's a few other models that can be added to this patch too

I do too.

Note, if you look at the git tree I have for the driver, it is totally rewritten to not use a structure, and instead, use offsets properly. But it removed support for your laptop, which is not what you probably want :(

Quoted 6 lines
Quoted 4 lines

thanks,

greg k-h

What git tree?

http://github.com/gregkh/samsung-backlight

Quoted 8 lines

Look at the "laptop" branch for the latest stuff.

Also supports rfkill and "silent" mode for the N130/N128 machines.

thanks,

greg k-h

Tomorrow I'll try this updated patch with my laptop added and see if it works

#7 lore raw
Quoted 2 lines · Mike Lothian

Tomorrow I'll try this updated patch with my laptop added and see if it works

Unless you have a custom BIOS from Samsung, I can almost guarantee it will not, sorry.

greg k-h

#8 lore raw
In reply to Greg KH
Quoted 14 lines · Greg KH
Quoted 13 lines · Mike Lothian

2009/10/7 Greg KH <[email protected]>:

Quoted 12 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

...

Quoted 8 lines
Quoted 4 lines

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
From: Greg Kroah-Hartman <[email protected]>

Quoted 6 lines

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain. Someone needs to sign off on it...

That's quite crazy, no?

DCO, a). You say you created the patch. Do you want to say you did not have right to submit it? Or do you want to say it is not under GPL?

What is going on?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#9 lore raw
Quoted 24 lines · Pavel Machek
Quoted 14 lines · Greg KH
Quoted 13 lines · Mike Lothian

2009/10/7 Greg KH <[email protected]>:

Quoted 12 lines · Mike Lothian
Quoted 6 lines

Hi

I was hoping the following patch could be included in 2.6.32 so it would hopefully end up in the next round of distros

It adds backlight support for some Samsung laptops

You seem to have lost the original authorship of this patch, and not included your signed-off-by for it.

Which means it can't be applied :(

...

Quoted 8 lines
Quoted 4 lines

It definitely has +MODULE_AUTHOR("Greg Kroah-Hartman <[email protected]>"); at the bottom

I certainly wasn't trying to steal credit for your work

I mean on the patch, when submitting it, you need a:
From: Greg Kroah-Hartman <[email protected]>

Quoted 8 lines
Quoted 6 lines

as the first line.

Quoted 1 line

Who should sign it off?

As I stated before, I can not sign off on this patch anymore, but I would like my authorship to remain. Someone needs to sign off on it...

That's quite crazy, no?

Yes it is.

Quoted 5 lines

DCO, a). You say you created the patch. Do you want to say you did not have right to submit it? Or do you want to say it is not under GPL?

What is going on?

I can not say, sorry.

greg k-h