70a3341a71 broke omap_hsmmc?
Subsystems (2)
Hello,
commit 70a3341a711f27ae77714ae7dd360a4e7e2d5e7c changed registering of omap_hsmmc_host from using platform_driver_probe to using platform_driver_register. But omap_hsmmc_driver doesn't have a probe entry. So I expect that the driver doesn't bind correctly.
The fix is either convert back to platform_driver_probe or (add platform_driver_probe to omap_hsmmc_driver and move it to section .devinit.text).
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Hi,
A fix for this is pushed in Linux-omap.
Regards,
Madhu
commit fa7705edb1355a52cdca0adfcfe007923bfff7dc
Author: Roger Quadros <[email protected]> Date: Mon Oct 5 13:50:06 2009 -0700
omap_hsmmc: Add missing probe handler hook to platform driver data
The missing probe handler hook will never probe the driver. Add it back. Fixes broken MMC on OMAP.
We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable device.
drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {static int __init omap_hsmmc_init (void ) {/* Register the MMC driver */ -return platform_driver_register (&omap_hsmmc_driver); +return platform_driver_probe (&omap_hsmmc_driver, omap_hsmmc_probe); } static void __exit omap_hsmmc_cleanup(void)
Quoted 19 lines
Hello,
commit
70a3341a711f27ae77714ae7dd360a4e7e2d5e7cchanged registering ofomap_hsmmc_hostfrom usingplatform_driver_probeto usingplatform_driver_register. Butomap_hsmmc_driverdoesn't have a probe entry. So I expect that the driver doesn't bind correctly.The fix is either convert back to
platform_driver_probeor (addplatform_driver_probetoomap_hsmmc_driverand move it to section .devinit.text).Best regards
Uwe--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |