Skip to contentSkip to conversation

staging: where to put system-wide includes

DISCUSSION Pavel Machek 3 participants 5 messages Oct 8, 2009 – Oct 17, 2009

lore
Share & tools
lore
#0 lore raw

Hi!

In staging, I need some includes that will become "system-wide" at the end.

Is it acceptable to create drivers/staging/include/linux (and friends), and then use -I magic to include those headers?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 7 lines · Pavel Machek

Hi!

In staging, I need some includes that will become "system-wide" at the end.

Is it acceptable to create drivers/staging/include/linux (and friends), and then use -I magic to include those headers?

No, keep them in the subdir for the drivers you are adding please and reference them by the location directly, no -I magic.

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg KH
Quoted 7 lines · Pavel Machek

Hi!

In staging, I need some includes that will become "system-wide" at the end.

Is it acceptable to create drivers/staging/include/linux (and friends), and then use -I magic to include those headers?

No, keep them in the subdir for the drivers you are adding please and reference them by the location directly, no -I magic.

That will make moving drivers to final place "interesting", but I'll do as you wish.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
In reply to Pavel Machek
Quoted 7 lines · Pavel Machek

Hi!

In staging, I need some includes that will become "system-wide" at the end.

Is it acceptable to create drivers/staging/include/linux (and friends), and then use -I magic to include those headers?

If you need system-wide inclusions it's pretty good sign that what you add is not a simple driver and thus should not just go into the staging tree. Given that you're a long-timer kernel hackers what's the problem with getting your code fully up to kernel standards anyway?

#4 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 5 lines · Pavel Machek

Hi!

In staging, I need some includes that will become "system-wide" at the end.

Quoted 7 lines
Quoted 2 lines

Is it acceptable to create drivers/staging/include/linux (and friends), and then use -I magic to include those headers?

If you need system-wide inclusions it's pretty good sign that what you add is not a simple driver and thus should not just go into the staging tree. Given that you're a long-timer kernel hackers what's the problem with getting your code fully up to kernel standards anyway?

Well, it is not exactly my code -- I'm trying to merge HTC Dream support. Problem with "simply cleaning it up" is that its 122Kloc.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html