qemu: reset-related fixes
cover qemu: reset-related fixes
Quoted 6 lines · Avi Kivity
Quoted 3 lines
Reset BARs and a couple of other registers on bus reset, as per PCI spec.
This commit breaks Windows XP restart. After a restart Windows switches from 800x600 cirrus logic vga to 640x480 standard vga.
So I think this is a bios bug. Patchset fixing this applied.
So, what's the best way to propagate the fixes upstream? Avi, Anthony, please advise.
Avi, after applying this, you need to generate a new bios binary.
Anthony, qemu keeps bios binaries in source tree.
I can't post a patch changing these, can I?
Only people with git access can change them.
BTW, can't we keep the sources around the like qemu-kvm does? It would be best if pc-bios used git, then we would include a submodule, as it is we can set up a git-cvs mirror at qemu site, and then include a submodule. Makes sense?
Michael S. Tsirkin (3):
pc-bios: enable io/memory unconditionally
qemu: make cirrus init value pci spec compliant
qemu: cleanup unused macros in cirrus
hw/cirrus_vga.c | 38 +------------------------------------- kvm/bios/rombios32.c | 18 +++++++----------- 2 files changed, 8 insertions(+), 48 deletions(-)
Signature · 1 line
MST
Quoted 19 lines · Michael S. Tsirkin
Quoted 6 lines · Avi Kivity
Quoted 3 lines
Reset BARs and a couple of other registers on bus reset, as per PCI spec.
This commit breaks Windows XP restart. After a restart Windows switches from 800x600 cirrus logic vga to 640x480 standard vga.
So I think this is a bios bug. Patchset fixing this applied.
So, what's the best way to propagate the fixes upstream? Avi, Anthony, please advise.
Avi, after applying this, you need to generate a new bios binary.
Anthony, qemu keeps bios binaries in source tree.
I can't post a patch changing these, can I?
Only people with git access can change them.
Quoted 5 lines
BTW, can't we keep the sources around the like qemu-kvm does? It would be best if pc-bios used git, then we would include a submodule, as it is we can set up a git-cvs mirror at qemu site, and then include a submodule. Makes sense?
On this last point, it was pointed out to me that this is what we have already. Sorry about the noise.
Quoted 13 lines
Michael S. Tsirkin (3):
pc-bios: enable io/memory unconditionally
qemu: make cirrus init value pci spec compliant
qemu: cleanup unused macros in cirrushw/cirrus_vga.c | 38 +------------------------------------- kvm/bios/rombios32.c | 18 +++++++----------- 2 files changed, 8 insertions(+), 48 deletions(-)Signature · 1 line
MST
Quoted 20 lines · Michael S. Tsirkin
Quoted 6 lines · Avi Kivity
Quoted 4 lines
Reset BARs and a couple of other registers on bus reset, as per PCI spec.
This commit breaks Windows XP restart. After a restart Windows switches from 800x600 cirrus logic vga to 640x480 standard vga.
So I think this is a bios bug. Patchset fixing this applied.
So, what's the best way to propagate the fixes upstream? Avi, Anthony, please advise.
Avi, after applying this, you need to generate a new bios binary.
Anthony, qemu keeps bios binaries in source tree.
I can't post a patch changing these, can I?
Only people with git access can change them.
Quoted 6 lines
BTW, can't we keep the sources around the like qemu-kvm does? It would be best if pc-bios used git, then we would include a submodule, as it is we can set up a git-cvs mirror at qemu site, and then include a submodule. Makes sense?
This is exactly what we do. Look at roms/pc-bios.
Signature · 3 lines
Regards, Anthony Liguori