omap fixes for v2.6.32-rc3

GIT PULL Tony Lindgren 7 participants 18 messages Oct 7, 2009 – Oct 10, 2009

lore

Share & tools

lore

Tony Lindgren

author

2009-10-07 18:51 UTC #0 lore raw

Linus,

Please pull omap fixes from:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus

Regards,

Tony

The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
Linus Torvalds (1):

        Linux 2.6.32-rc3

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus

Artem Bityutskiy (1):
OMAP3: PM: introduce a new powerdomain walk helper

Daniel Walker (1):
omap: iovmm: Add missing mutex_unlock

Hiroshi DOYU (1):
omap: iovmm: Fix incorrect spelling

Jon Hunter (1):
OMAP3: PM: Prevent hang in prcm_interrupt_handler

Kevin Hilman (1):
OMAP3: PM: Enable GPIO module-level wakeups

Paul Walmsley (2):
OMAP3: PM: PRCM interrupt: check MPUGRPSEL register
OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts

Rajendra Nayak (1):
omap: Lock DPLL5 at boot

Sergio Aguirre (1):
omapfb: Condition mutex acquisition

Tommi Rantala (2):
omapfb: Blizzard: fix pointer to be const
omapfb: Blizzard: constify register address tables

Tony Lindgren (2):
omap: Fix incorrect 730 vs 850 detection
Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus

Vikram Pandita (1):
OMAP3: PM: USBHOST: clear wakeup events on both hosts

ye janboe (1):
omap: SRAM: flush the right address after memcpy in omap_sram_push

 arch/arm/mach-omap2/clock34xx.c               |   35 +++++
 arch/arm/mach-omap2/pm-debug.c                |    4 +-
 arch/arm/mach-omap2/pm34xx.c                  |  187 ++++++++++++++-----------
 arch/arm/mach-omap2/powerdomain.c             |   39 ++++--
 arch/arm/plat-omap/include/mach/cpu.h         |   37 ++---
 arch/arm/plat-omap/include/mach/powerdomain.h |    2 +
 arch/arm/plat-omap/iovmm.c                    |    9 +-
 arch/arm/plat-omap/sram.c                     |    3 +-
 drivers/video/omap/blizzard.c                 |   10 +-
 drivers/video/omap/omapfb_main.c              |   22 ++-
 10 files changed, 212 insertions(+), 136 deletions(-)

Felipe Contreras

2009-10-08 21:29 UTC #1 lore raw

Quoted 52 lines · Tony Lindgren

Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus

Quoted 5 lines

Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push

The beagleboard is still not booting for me with this branch, I need to add these two patches:

* http://patchwork.kernel.org/patch/50721/

This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y

* http://patchwork.kernel.org/patch/50970/

This is needed because most people boot from an MMC.

You can add my 'tested-by' line if you want.

Cheers.

Signature · 1 line

Felipe Contreras

Tony Lindgren

author

2009-10-08 21:41 UTC #2 lore raw

Quoted 56 lines · Felipe Contreras

Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts

Quoted 8 lines

Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/

This should go to the mainline kernel via Samuel as it's drivers/mfd related.

Quoted 6 lines

This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.

And this should go in via the mmc list.

So little more patience is still needed :)

Cheers,

Tony

Quoted 7 lines

You can add my 'tested-by' line if you want.
Cheers.
Signature · 1 line
Felipe Contreras

Felipe Contreras

2009-10-08 22:13 UTC #3 lore raw

Quoted 69 lines · Tony Lindgren

Quoted 56 lines · Felipe Contreras
Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
Quoted 8 lines
Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.

Quoted 8 lines

Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
And this should go in via the mmc list.

Should it?

Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2

And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2

I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().

Signature · 1 line

Felipe Contreras

Felipe Contreras

2009-10-08 22:20 UTC #4 lore raw

Quoted 79 lines · Felipe Contreras

Quoted 69 lines · Tony Lindgren
Quoted 56 lines · Felipe Contreras
Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
Quoted 8 lines
Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.
Quoted 8 lines
Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
And this should go in via the mmc list.

Quoted 8 lines

Should it?
Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2

Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Quoted 2 lines

I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().

Signature · 1 line

Felipe Contreras

Tony Lindgren

author

2009-10-08 23:26 UTC #5 lore raw

Quoted 6 lines · Felipe Contreras

Quoted 4 lines · Felipe Contreras
Quoted 3 lines · Tony Lindgren
Quoted 2 lines · Felipe Contreras
On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <[email protected]> wrote:

Quoted 24 lines

Quoted 24 lines
Quoted 9 lines
Quoted 5 lines
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.
Quoted 8 lines
Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
And this should go in via the mmc list.
Should it?
Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2

Quoted 6 lines

Quoted 2 lines
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Right, looks like Roger forgot to Cc linux-mmc.

Quoted 2 lines

Quoted 2 lines
I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().

I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get merged soon:

http://www.mail-archive.com/linux-mmc at vger.kernel.org/msg00539.html

Regards,

Tony

Felipe Contreras

2009-10-09 12:08 UTC #6 lore raw

Quoted 1 line · Tony Lindgren

* Felipe Contreras <[email protected]> [091008 15:20]:

<snip/>

Quoted 13 lines

Quoted 10 lines
Quoted 6 lines
Here you can see Uwe Kleine-König sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2
Right, looks like Roger forgot to Cc linux-mmc.

Quoted 7 lines

Quoted 2 lines
Quoted 2 lines
I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().
I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get merged soon:
http://www.mail-archive.com/[email protected]/msg00539.html

I don't see what's specific about mmc in that patch, nor omap. It's just a fix for an obvious mistake that must be picked ASAP and can't possibly be NAK'ed.

There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

And one for includecheck:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6

What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew Morton because I think they might interested in fixing these kinds of issues quickly in the future.

Cheers.

Signature · 1 line

Felipe Contreras

Greg KH

2009-10-09 14:49 UTC #7 lore raw

Quoted 33 lines · Felipe Contreras

Quoted 1 line · Tony Lindgren
* Felipe Contreras <[email protected]> [091008 15:20]:
<snip/>
Quoted 13 lines
Quoted 10 lines
Quoted 6 lines
Here you can see Uwe Kleine-K??nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2
Right, looks like Roger forgot to Cc linux-mmc.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().
I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get merged soon:
http://www.mail-archive.com/[email protected]/msg00539.html
I don't see what's specific about mmc in that patch, nor omap. It's just a fix for an obvious mistake that must be picked ASAP and can't possibly be NAK'ed.
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

Quoted 6 lines

And one for includecheck:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew Morton because I think they might interested in fixing these kinds of issues quickly in the future.

What kind of issues? Why would I be interested, where is the problem?

confused,

greg k-h

Felipe Contreras

2009-10-09 17:29 UTC #8 lore raw

Quoted 34 lines · Greg KH

Quoted 33 lines · Felipe Contreras
Quoted 1 line · Tony Lindgren
* Felipe Contreras <[email protected]> [091008 15:20]:
<snip/>
Quoted 13 lines
Quoted 10 lines
Quoted 6 lines
Here you can see Uwe Kleine-K??nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2
Right, looks like Roger forgot to Cc linux-mmc.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().
I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get merged soon:
http://www.mail-archive.com/[email protected]/msg00539.html
I don't see what's specific about mmc in that patch, nor omap. It's just a fix for an obvious mistake that must be picked ASAP and can't possibly be NAK'ed.
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

Quoted 8 lines

Quoted 6 lines
And one for includecheck:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew Morton because I think they might interested in fixing these kinds of issues quickly in the future.
What kind of issues? Why would I be interested, where is the problem?

The obvious-brain-dead-duh kind of issues, like this one.

The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.

To me it's not clear who should push the patch, it seems it doesn't belong on linux-omap, so Tony is pushing it through linux-mmc, which I don't think is the right place. They should be handling mmc-related issues, not obvious breakage.

In order to keep the engines oiled I think there must be a process to flag obvious generic breakage so it's immediately picked; maybe an 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial', 'includecheck', and similar, or maybe nothing needs to be done. Up to you to decide.

Cheers.

Signature · 1 line

Felipe Contreras

Greg KH

2009-10-09 19:26 UTC #9 lore raw

Quoted 42 lines · Felipe Contreras

Quoted 41 lines · Greg KH
Quoted 39 lines · Felipe Contreras
Quoted 1 line · Tony Lindgren
* Felipe Contreras <[email protected]> [091008 15:20]:
<snip/>
Quoted 13 lines
Quoted 10 lines
Quoted 6 lines
Here you can see Uwe Kleine-K??nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
And it was unintentionally broken by this one:
http://marc.info/?l=linux-mmc&m=125249763422227&w=2
Er, actually that one was ok, the problem was introduced only in the final version:
http://marc.info/?l=linux-mmc&m=125366315417006&w=2
Right, looks like Roger forgot to Cc linux-mmc.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I don't see what we are waiting for, the code is clearly broken, even the compiler warns that nobody is using omap_hsmmc_probe().
I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get merged soon:
http://www.mail-archive.com/[email protected]/msg00539.html
I don't see what's specific about mmc in that patch, nor omap. It's just a fix for an obvious mistake that must be picked ASAP and can't possibly be NAK'ed.
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
And one for includecheck:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6
What's the procedure for obvious fixes? I'm CC'ing Greg KH and Andrew Morton because I think they might interested in fixing these kinds of issues quickly in the future.

Quoted 8 lines

Quoted 1 line
What kind of issues? Why would I be interested, where is the problem?
The obvious-brain-dead-duh kind of issues, like this one.
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.

Has the patches been sent from the maintainer to Linus?

Who is the maintainer? Who normally sends this stuff?

Quoted 4 lines

To me it's not clear who should push the patch, it seems it doesn't belong on linux-omap, so Tony is pushing it through linux-mmc, which I don't think is the right place. They should be handling mmc-related issues, not obvious breakage.

Well, mmc related breakage is fine to handle :)

Quoted 5 lines

In order to keep the engines oiled I think there must be a process to flag obvious generic breakage so it's immediately picked; maybe an 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial', 'includecheck', and similar, or maybe nothing needs to be done. Up to you to decide.

Andrew usually sends stuff like this at times.

thanks,

greg k-h

Andrew Morton

2009-10-09 21:33 UTC #10 lore raw

Quoted 21 lines · On Fri, 9 Oct 2009 12:26:42 -0700 Greg KH <[email protected]> wrote:

Quoted 9 lines
Quoted 2 lines
What kind of issues? __Why would I be interested, where is the problem?
The obvious-brain-dead-duh kind of issues, like this one.
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus?
Who is the maintainer? Who normally sends this stuff?
Quoted 4 lines
To me it's not clear who should push the patch, it seems it doesn't belong on linux-omap, so Tony is pushing it through linux-mmc, which I don't think is the right place. They should be handling mmc-related issues, not obvious breakage.
Well, mmc related breakage is fine to handle :)

Quoted 7 lines

Quoted 5 lines
In order to keep the engines oiled I think there must be a process to flag obvious generic breakage so it's immediately picked; maybe an 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial', 'includecheck', and similar, or maybe nothing needs to be done. Up to you to decide.
Andrew usually sends stuff like this at times.

yeah, when in doubt, send it to me. When not in doubt send it to me anyway ;)

I'll take care of bugging the appropriate maintainer or merging it directly.

Felipe Contreras

2009-10-10 10:39 UTC #11 lore raw

Quoted 30 lines · Andrew Morton

Quoted 27 lines · On Fri, 9 Oct 2009 12:26:42 -0700 Greg KH <[email protected]> wrote:
Quoted 9 lines
Quoted 2 lines
What kind of issues? __Why would I be interested, where is the problem?
The obvious-brain-dead-duh kind of issues, like this one.
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus?
Who is the maintainer? Who normally sends this stuff?
Quoted 4 lines
To me it's not clear who should push the patch, it seems it doesn't belong on linux-omap, so Tony is pushing it through linux-mmc, which I don't think is the right place. They should be handling mmc-related issues, not obvious breakage.
Well, mmc related breakage is fine to handle :)
Quoted 5 lines
In order to keep the engines oiled I think there must be a process to flag obvious generic breakage so it's immediately picked; maybe an 'obvious-fixes' tree, or a 'simple-fixes' that has 'trivial', 'includecheck', and similar, or maybe nothing needs to be done. Up to you to decide.

Quoted 6 lines

Quoted 1 line
Andrew usually sends stuff like this at times.
yeah, when in doubt, send it to me. When not in doubt send it to me anyway ;)
I'll take care of bugging the appropriate maintainer or merging it directly.

Ah, that's exactly what I wanted to know, thanks :)

Signature · 5 lines

Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jiri Kosina

2009-10-09 21:43 UTC #12 lore raw

In reply to Greg KH

Quoted 2 lines · Greg KH

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

Well, as this is quite a high-priority functional fix, I'd suggest using other channels that trivial tree, as this one is primarily intended for simple fixes that are not really urgent.

Quoted 6 lines

Quoted 4 lines
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus? Who is the maintainer? Who normally sends this stuff?

The problem is that MMC now doesn't have proper maintainer, since Pierre stepped down from maintaining this stuff.

Still, for the fix mentioned on

	http://www.mail-archive.com/[email protected]/msg00539.html

the most appropriate contact would probably be Madhusudhan Chikkature. Adding him to CC of this thread.

Signature · 2 lines

Jiri Kosina
SUSE Labs, Novell Inc.

Andrew Morton

2009-10-09 21:58 UTC #13 lore raw

Quoted 19 lines · On Fri, 9 Oct 2009 23:42:27 +0200 (CEST) Jiri Kosina <[email protected]> wrote:

Quoted 2 lines · Greg KH
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
Well, as this is quite a high-priority functional fix, I'd suggest using other channels that trivial tree, as this one is primarily intended for simple fixes that are not really urgent.
Quoted 6 lines
Quoted 4 lines
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus? Who is the maintainer? Who normally sends this stuff?
The problem is that MMC now doesn't have proper maintainer, since Pierre stepped down from maintaining this stuff.

Quoted 6 lines

Still, for the fix mentioned on
	http://www.mail-archive.com/[email protected]/msg00539.html
the most appropriate contact would probably be Madhusudhan Chikkature. Adding him to CC of this thread.

hm. What's all the fuss about? That patch was sent To:me and affects only MMC and is clearly a bugfix. I'll merge it when i get to it (hopefully tomorrow) then all is good?

Madhusudhan

2009-10-09 22:33 UTC #14 lore raw

In reply to Jiri Kosina

Quoted 30 lines

-----Original Message-----
From: Jiri Kosina [mailto:[email protected]]
Sent: Friday, October 09, 2009 4:42 PM
To: Greg KH
Cc: Felipe Contreras; Tony Lindgren; Linus Torvalds; linux- [email protected]; [email protected]; Denis Karpov; Uwe Kleine-K??nig; Andrew Morton; Madhusudhan Chikkature
Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3
Quoted 2 lines · Greg KH
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
There's a tree for trivial fixes:
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
Well, as this is quite a high-priority functional fix, I'd suggest using other channels that trivial tree, as this one is primarily intended for simple fixes that are not really urgent.
Quoted 6 lines
Quoted 4 lines
The problem is that OMAP devices (like beagleboard) are not booting correctly right now because of a wrong merge. It has been identified, tested, and acked, but nobody has picked it up for a pull request, so it's not clear it will be on -rc4.
Has the patches been sent from the maintainer to Linus? Who is the maintainer? Who normally sends this stuff?
The problem is that MMC now doesn't have proper maintainer, since Pierre stepped down from maintaining this stuff.

Quoted 7 lines

Still, for the fix mentioned on
	http://www.mail-archive.com/[email protected]/msg00539.html
the most appropriate contact would probably be Madhusudhan Chikkature. Adding him to CC of this thread.

Since this fix was posted in Linux-omap, Tony pointed this out to Andrew so that the fix will go upstream. That should this fix this mmc issue.

Regards,
Madhu

Quoted 3 lines

--
Jiri Kosina
SUSE Labs, Novell Inc.

Uwe Kleine-König

2009-10-09 08:02 UTC #15 lore raw

In reply to Felipe Contreras

Hello,

Quoted 77 lines · Felipe Contreras

Quoted 76 lines · Tony Lindgren
Quoted 56 lines · Felipe Contreras
Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
Quoted 8 lines
Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.
Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.

Quoted 7 lines

Quoted 1 line
And this should go in via the mmc list.
Should it?
Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2

Note these are different patches. Mine fixes a section problem as the probe function used to live in .init.text but was still used with platform_driver_register.

Other than that you can add my Acked-by: for "omap_hsmmc: Add missing probe handler hook to platform driver data".

Best regards
Uwe

Signature · 2 lines

Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Felipe Contreras

2009-10-09 08:25 UTC #16 lore raw

2009/10/9 Uwe Kleine-K?nig <[email protected]>:

Quoted 82 lines

Hello,
Quoted 79 lines · Felipe Contreras
Quoted 77 lines · Tony Lindgren
Quoted 56 lines · Felipe Contreras
Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
Quoted 8 lines
Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.
Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
And this should go in via the mmc list.

Quoted 8 lines

Quoted 5 lines
Should it?
Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
Note these are different patches. ?Mine fixes a section problem as the probe function used to live in .init.text but was still used with platform_driver_register.

Maybe you looked at the wrong diff. This is the patch that is going to be pushed eventually:
http://marc.info/?l=linux-mmc&m=125504287632070&w=2

As you can see it's restoring back what you intended in the original patch.

Signature · 1 line

Felipe Contreras

Uwe Kleine-König

2009-10-09 08:30 UTC #17 lore raw

Hello,

Quoted 92 lines · Felipe Contreras

2009/10/9 Uwe Kleine-K?nig <[email protected]>:
Quoted 82 lines
Hello,
Quoted 79 lines · Felipe Contreras
Quoted 77 lines · Tony Lindgren
Quoted 56 lines · Felipe Contreras
Quoted 55 lines · Tony Lindgren
Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 374576a8b6f865022c0fd1ca62396889b23d66dd:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.32-rc3
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus
Artem Bityutskiy (1):
? ? ?OMAP3: PM: introduce a new powerdomain walk helper
Daniel Walker (1):
? ? ?omap: iovmm: Add missing mutex_unlock
Hiroshi DOYU (1):
? ? ?omap: iovmm: Fix incorrect spelling
Jon Hunter (1):
? ? ?OMAP3: PM: Prevent hang in prcm_interrupt_handler
Kevin Hilman (1):
? ? ?OMAP3: PM: Enable GPIO module-level wakeups
Paul Walmsley (2):
? ? ?OMAP3: PM: PRCM interrupt: check MPUGRPSEL register ? ? ?OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts
Rajendra Nayak (1):
? ? ?omap: Lock DPLL5 at boot
Sergio Aguirre (1):
? ? ?omapfb: Condition mutex acquisition
Tommi Rantala (2):
? ? ?omapfb: Blizzard: fix pointer to be const ? ? ?omapfb: Blizzard: constify register address tables
Tony Lindgren (2):
? ? ?omap: Fix incorrect 730 vs 850 detection
? ? ?Merge branch 'pm-fixes-32' of git://git.kernel.org/.../khilman/linux-omap-pm into omap-fixes-for-linus
Vikram Pandita (1):
? ? ?OMAP3: PM: USBHOST: clear wakeup events on both hosts
Quoted 8 lines
Quoted 2 lines
ye janboe (1):
? ? ?omap: SRAM: flush the right address after memcpy in omap_sram_push
The beagleboard is still not booting for me with this branch, I need to add these two patches:
* http://patchwork.kernel.org/patch/50721/
This should go to the mainline kernel via Samuel as it's drivers/mfd related.
Quoted 6 lines
This one is needed because the defconfig has:
CONFIG_TWL4030_USB=y
* http://patchwork.kernel.org/patch/50970/
This is needed because most people boot from an MMC.
And this should go in via the mmc list.
Quoted 8 lines
Quoted 5 lines
Should it?
Here you can see Uwe Kleine-K?nig sending the original patch without even CC'ing the mmc list:
http://marc.info/?l=linux-kernel&m=124820861213849&w=2
Note these are different patches. ?Mine fixes a section problem as the probe function used to live in .init.text but was still used with platform_driver_register.

Quoted 5 lines

Maybe you looked at the wrong diff. This is the patch that is going to be pushed eventually:
http://marc.info/?l=linux-mmc&m=125504287632070&w=2
As you can see it's restoring back what you intended in the original patch.

Yes, but back then it was broken in a different way. Now the driver's probe function hasn't been called at all. My fix addressed a possible oops because it could be called when is was already discarded.

Best regards
Uwe

Signature · 2 lines

Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |