kmemleak: Use GFP_ATOMIC for early_alloc().
Subsystems (2)
Catalin Marinas
maintainerPATCH 1/2 kmemleak: Use GFP_ATOMIC for early_alloc().
We can't use GFP_KERNEL inside rcu_read_lock().
--- mm/kmemleak.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/kmemleak.c +1 -1
@@ -833,7 +833,7 @@ static void early_alloc(struct early_log *log)*/ rcu_read_lock (); object =create_object ((unsigned long )log->ptr, log->size, - log->min_count,GFP_KERNEL ); + log->min_count,GFP_ATOMIC );spin_lock_irqsave (&object->lock, flags);for (i =0 ; i < log->trace_len; i++) object->trace[i] = log->trace[i];
Catalin Marinas
maintainerPATCH 2/2 kmemleak: Check for NULL pointer returned by create_object()
This patch adds NULL pointer checking in the early_alloc() function.
--- mm/kmemleak.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
mm/kmemleak.c +3 -0
@@ -834,11 +834,14 @@ static void early_alloc(struct early_log *log)rcu_read_lock (); object =create_object ((unsigned long )log->ptr, log->size, log->min_count,GFP_ATOMIC ); +if (!object) + goto out;spin_lock_irqsave (&object->lock, flags);for (i =0 ; i < log->trace_len; i++) object->trace[i] = log->trace[i]; object->trace_len = log->trace_len;spin_unlock_irqrestore (&object->lock, flags); +out:rcu_read_unlock (); }
Re: [PATCH 2/2] kmemleak: Check for NULL pointer returned by create_object()
Quoted 4 lines · Catalin Marinas
This patch adds NULL pointer checking in the
early_alloc()function.Reported-by Paul E. McKenney <[email protected]>Signed-off-by Catalin Marinas <[email protected]>
Quoted 30 lines
---
mm/kmemleak.c | 3 +++1 files changed, 3 insertions(+), 0 deletions(-)mm/kmemleak.c +3
-1@@ -834,11 +834,14 @@ static void early_alloc(struct early_log *log) rcu_read_lock(); object = create_object((unsigned long)log->ptr, log->size, log->min_count, GFP_ATOMIC); + if (!object) + goto out; spin_lock_irqsave(&object->lock, flags); for (i = 0; i < log->trace_len; i++) object->trace[i] = log->trace[i]; object->trace_len = log->trace_len; spin_unlock_irqrestore(&object->lock, flags); +out: rcu_read_unlock(); } --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] kmemleak: Check for NULL pointer returned by create_object()
In reply to Catalin MarinasQuoted 1 line · Catalin Marinas
This patch adds NULL pointer checking in the
early_alloc()function.
Quoted 26 lines
Reported-by Paul E. McKenney <[email protected]>Signed-off-by Catalin Marinas <[email protected]>--- mm/kmemleak.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)mm/kmemleak.c +3
-0@@ -834,11 +834,14 @@ static void early_alloc(struct early_log *log)rcu_read_lock (); object =create_object ((unsigned long )log->ptr, log->size, log->min_count,GFP_ATOMIC ); +if (!object) + goto out;spin_lock_irqsave (&object->lock, flags);for (i =0 ; i < log->trace_len; i++) object->trace[i] = log->trace[i]; object->trace_len = log->trace_len;spin_unlock_irqrestore (&object->lock, flags); +out:rcu_read_unlock (); }
Catalin Marinas
maintainerQuoted 4 lines · Catalin Marinas
We can't use
GFP_KERNELinsidercu_read_lock().Signed-off-by Tetsuo Handa <[email protected]>Signed-off-by Catalin Marinas <[email protected]>
I mistakenly dropped the author information. The correct patch should have a "From: Tetsuo" line. I'll re-post in reply to this message.
Signature · 1 line
Catalin
Catalin Marinas
maintainerPATCH 1/1 kmemleak: Use GFP_ATOMIC for early_alloc().
In reply to Catalin MarinasFrom: Tetsuo Handa <[email protected]>
We can't use GFP_KERNEL inside rcu_read_lock().
---
Please ignore [PATCH 1/2] with the same subject as it didn't have the correct author information. Thanks.
mm/kmemleak.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/kmemleak.c +1 -1
@@ -833,7 +833,7 @@ static void early_alloc(struct early_log *log)*/ rcu_read_lock (); object =create_object ((unsigned long )log->ptr, log->size, - log->min_count,GFP_KERNEL ); + log->min_count,GFP_ATOMIC );spin_lock_irqsave (&object->lock, flags);for (i =0 ; i < log->trace_len; i++) object->trace[i] = log->trace[i];